Re: Maven's ArtifactMetadataSource's bad role-hint

2007-03-05 Thread Andrew Williams
OK, that is done. The change should not affect anything not using plexus-container- default < alpha-19-SNAPSHOT, which includes the core maven build atm, as I have not upgraded it. Want more testing done first :) Andy On 5 Mar 2007, at 01:56, Brett Porter wrote: I agree - it's going to enab

Re: Maven's ArtifactMetadataSource's bad role-hint

2007-03-05 Thread Andrew Williams
Yes, it does add "default". I think Jason was referring to the use of CDC irrespective if whether hints were in or not. After all, CDC does not need a hint at all, and the container will fill the blanks at runtime. Andy On 5 Mar 2007, at 08:56, Trygve Laugstøl wrote: Jason van Zyl wrote:

Re: Maven's ArtifactMetadataSource's bad role-hint

2007-03-05 Thread Trygve Laugstøl
Jason van Zyl wrote: On 4 Mar 07, at 3:18 AM 4 Mar 07, Andrew Williams wrote: Are there an objections, or reasons not to change the role-hint of MavenMetadataSource in maven-project from "maven" to "default". I think that's fine, but we should also annotating all the plexus components and

Re: Maven's ArtifactMetadataSource's bad role-hint

2007-03-04 Thread Brett Porter
Oh yeah, that works too :) I use CDC so much that I forget (but even then, you can merge in the extra def). - Brett On 04/03/2007, at 5:58 PM, Andrew Williams wrote: I had a more cunning plan... I can just advertise it over both hints in the components.xml (works in the tests I have done her

Re: Maven's ArtifactMetadataSource's bad role-hint

2007-03-04 Thread Andrew Williams
I had a more cunning plan... I can just advertise it over both hints in the components.xml (works in the tests I have done here :) ). Andy On 5 Mar 2007, at 01:56, Brett Porter wrote: I agree - it's going to enable plugins that reference it successfully by role alone now to continue working.

Re: Maven's ArtifactMetadataSource's bad role-hint

2007-03-04 Thread Brett Porter
I agree - it's going to enable plugins that reference it successfully by role alone now to continue working. However, something may reference it directly by the maven role-hint: I suggest a subclass with not modifications except the alternate role- hint be made (and deprecated) for that case

Re: Maven's ArtifactMetadataSource's bad role-hint

2007-03-04 Thread Jason van Zyl
On 4 Mar 07, at 3:18 AM 4 Mar 07, Andrew Williams wrote: Are there an objections, or reasons not to change the role-hint of MavenMetadataSource in maven-project from "maven" to "default". I think that's fine, but we should also annotating all the plexus components and I think we can make

Maven's ArtifactMetadataSource's bad role-hint

2007-03-04 Thread Andrew Williams
Are there an objections, or reasons not to change the role-hint of MavenMetadataSource in maven-project from "maven" to "default". The latest plexus code (will shortly...) be more strict on hints and no longer allow components to grab "whatever is configured", if a hint exists it must be ho