Re: MRELEASE-985(again)

2019-04-22 Thread Robert Scholte
Hi Petar, can you confirm that only dependency versions are picked up from commandline, and not any other property? And if you do a release, please make it a M1 (milestone 1), because there are quite some changes that should be part of the final 3.0.0 thanks, Robert On Mon, 22 Apr 2019 08:

Re: MRELEASE-985(again)

2019-04-21 Thread Petar Tahchiev
Hello, if somebody would confirm my changes are OK, I'd like to perform a release of the maven-release-plugin - the last release is almost 4 years old. На нд, 21.04.2019 г. в 13:29 ч. Petar Tahchiev написа: > Hi Robert, > and thank you for your response. I have pushed a test which fails if I >

Re: MRELEASE-985(again)

2019-04-21 Thread Petar Tahchiev
Hi Robert, and thank you for your response. I have pushed a test which fails if I revert my changes. The test passes with my changes. Please could someone have a look at what I have changed and if it is OK. Thank you. На нд, 21.04.2019 г. в 12:27 ч. Robert Scholte написа: > Hi Petar, > > IIRC t

Re: MRELEASE-985(again)

2019-04-21 Thread Robert Scholte
Hi Petar, IIRC the idea behind the original setup was to keep the original builder immutable and to keep a clear separation between what was configured by descriptor and what by commandline. And IIRC there's a set of properties that should NEVER be overridden via commandline. Also, if this is

MRELEASE-985(again)

2019-04-20 Thread Petar Tahchiev
Hey guys, a while ago I raised this issue https://issues.apache.org/jira/browse/MRELEASE-985 and also I made a pull-request: https://github.com/apache/maven-release/pull/18 but it was closed, because I believe after a few years the code was very much out of sync with the master. However, I che