[GitHub] maven pull request #161: [MNG-6370] Fix typo in list filtering ConcurrencyDe...

2018-03-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven/pull/161 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #161: [MNG-6370] Fix typo in list filtering ConcurrencyDependenc...

2018-03-07 Thread slachiewicz
Github user slachiewicz commented on the issue: https://github.com/apache/maven/pull/161 Sure, unit test are always funny part:) done --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional comm

[GitHub] maven issue #161: [MNG-6370] Fix typo in list filtering ConcurrencyDependenc...

2018-03-06 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/maven/pull/161 @slachiewicz I am ready to merge, @rfscholte [requested a unit test](https://www.mail-archive.com/dev@maven.apache.org/msg116360.html). Can you add one and I will merge it with a smile= ---

Re: MNG-6370

2018-03-05 Thread Robert Scholte
Looks like it should be very easy to write a unittest for this. Please do so as well. thanks, Robert On Tue, 06 Mar 2018 01:47:23 +0100, Michael Osipov wrote: Who seconds MNG-6370 for 3.5.4? A simple bug fix, all ITs pass locally here. Michael

Re: MNG-6370

2018-03-05 Thread Hervé BOUTEMY
+1 Regards, Hervé Le mardi 6 mars 2018, 01:47:23 CET Michael Osipov a écrit : > Who seconds MNG-6370 for 3.5.4? > > A simple bug fix, all ITs pass locally here. > > Michael > > - > To unsubscri

Re: MNG-6370

2018-03-05 Thread Olivier Lamy
+1 On 6 March 2018 at 10:47, Michael Osipov wrote: > Who seconds MNG-6370 for 3.5.4? > > A simple bug fix, all ITs pass locally here. > > Michael > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apa

MNG-6370

2018-03-05 Thread Michael Osipov
Who seconds MNG-6370 for 3.5.4? A simple bug fix, all ITs pass locally here. Michael - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request #161: [MNG-6370] Fix typo in list filtering ConcurrencyDe...

2018-03-05 Thread slachiewicz
GitHub user slachiewicz opened a pull request: https://github.com/apache/maven/pull/161 [MNG-6370] Fix typo in list filtering ConcurrencyDependencyGraph.getU… …nfinishedProjects You can merge this pull request into a Git repository by running: $ git pull https://github.com