Re: MNG-5868 for 3.5.0

Hi, On 01/02/17 21:15, Christian Schulte wrote: @Karl Heinz: Consider the MNG-5868 branch yours :-) I take it ...Thanks. Kind regards Karl Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additio

Re: MNG-5868 for 3.5.0

@Karl Heinz: Consider the MNG-5868 branch yours :-) - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

Re: MNG-5868 for 3.5.0

Am 02/01/17 um 11:22 schrieb Stephen Connolly: > On 1 February 2017 at 10:15, Karl Heinz Marbaise wrote: > >> Hi, >> >> On 01/02/17 10:50, Stephen Connolly wrote: >> >>> But doesn't the shade plugin want to do exactly that... namely attach >>> the shaded jar *to replace* the jar attached by the j

Re: MNG-5868 for 3.5.0

On 1 February 2017 at 10:34, Karl Heinz Marbaise wrote: > Hi Stephen, > > On 01/02/17 11:22, Stephen Connolly wrote: > >> >> >> On 1 February 2017 at 10:15, Karl Heinz Marbaise > > wrote: >> >> Hi, >> >> On 01/02/17 10:50, Stephen Connolly wrote: >> >> Bu

Re: MNG-5868 for 3.5.0

Hi Stephen, On 01/02/17 11:22, Stephen Connolly wrote: On 1 February 2017 at 10:15, Karl Heinz Marbaise mailto:khmarba...@gmx.de>> wrote: Hi, On 01/02/17 10:50, Stephen Connolly wrote: But doesn't the shade plugin want to do exactly that... namely attach the

Re: MNG-5868 for 3.5.0

On 1 February 2017 at 10:15, Karl Heinz Marbaise wrote: > Hi, > > On 01/02/17 10:50, Stephen Connolly wrote: > >> But doesn't the shade plugin want to do exactly that... namely attach >> the shaded jar *to replace* the jar attached by the jar plugin? >> > > Yes but if the maven-source-plugin does

Re: MNG-5868 for 3.5.0

Hi, On 01/02/17 10:50, Stephen Connolly wrote: But doesn't the shade plugin want to do exactly that... namely attach the shaded jar *to replace* the jar attached by the jar plugin? Yes but if the maven-source-plugin does the same and attach a source package which means you have two artifacts

Re: MNG-5868 for 3.5.0

But doesn't the shade plugin want to do exactly that... namely attach the shaded jar *to replace* the jar attached by the jar plugin? On 1 February 2017 at 08:51, Karl Heinz Marbaise wrote: > Hi, > > fixing this issue will produce a WARNING in cases where different plugins > attach the same ar

Re: MNG-5868 for 3.5.0

Hi, fixing this issue will produce a WARNING in cases where different plugins attach the same artifact multiple times which gives a hint on a wrong build configuration... Examples: maven-sources-plugin attaches a jar and another plugin will do the same thing...which results in complains that

Re: MNG-5868 for 3.5.0

Didn't we agree on v3.5.0 to be a drop-in replacement for v3.3.9? IMO fixing MNG-5868 wouldn't fit in that. I'm sorry to say, but I think we're heading back to where we were before the reset. /Anders On Wed, Feb 1, 2017 at 8:42 AM, Hervé BOUTEMY wrote: > https://issues.apache.org/jira/browse/M

Re: MNG-5868 for 3.5.0

https://issues.apache.org/jira/browse/MNG-5868 Adding serval times the same artifact via MavenProjectHelper (attachArtifact) does not produce a failure by reading the Jira entry, I can't understand what has been done and what is the effective impact: IIUC, Maven core becomes more picky, expected

MNG-5868 for 3.5.0

Hi, I'd like to make MNG-5868 FIX-3.5.0. There have been plugin issues solved by this. I know Karl-Heinz worked on some of those plugin issues. If this does not get released, those plugin issues may need to be re-opened. Anyone second FIX-3.5.0? Regards, -- Christian ---