Github user barthel commented on the issue:
https://github.com/apache/maven-integration-testing/pull/14
Relabelling commit from MNG-3092 to MNG-6049.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user barthel commented on the issue:
https://github.com/apache/maven/pull/70
Relabelling commit from MNG-3092 to MNG-6049.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/70
@barthel Perfect, already assigned. Just waiting for an updated PR and all
will be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-3092";>MNG-3092.
+ *
+ *
+ *
+ *
+ * org.apache.maven.its.mng3092
+ * a
+ * [1.0,2.0)
+ *
+ *
+ *
+ *
+ * @author Benjamin Bentman
Github user barthel commented on the issue:
https://github.com/apache/maven-integration-testing/pull/14
@michael-o Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled a
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-3092";>MNG-3092.
+ *
+ *
+ *
+ *
+ * org.apache.maven.its.mng3092
+ * a
+ * [1.0,2.0)
+ *
+ *
+ *
+ *
+ * @author Benjamin Bentman
Github user barthel commented on the issue:
https://github.com/apache/maven/pull/70
@michael-o Please take a look at
https://issues.apache.org/jira/browse/MNG-6049
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-3092";>MNG-3092.
+ *
+ *
+ *
+ *
+ * org.apache.maven.its.mng3092
+ * a
+ * [1.0,2.0)
+ *
+ *
+ *
+ *
+ * @author Benjamin Bentman
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-3092";>MNG-3092.
+ *
+ *
+ *
+ *
+ * org.apache.maven.its.mng3092
+ * a
+ * [1.0,2.0)
+ *
+ *
+ *
+ *
+ * @author Benjamin Bentman
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/70
@barthel ITs pass. I am now willing to merge both PRs. Just waiting for
your comment on the previous message.
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/70
I am already working on your PRs. I think, committing this under MNG-3092
is wrong and will explain why. I we cannot close the issue, people won't see
this in the changelog. They won't s
Github user barthel commented on the issue:
https://github.com/apache/maven-integration-testing/pull/14
@michael-o Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled a
Github user barthel commented on the issue:
https://github.com/apache/maven/pull/70
@michael-o Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user barthel commented on a diff in the pull request:
https://github.com/apache/maven-integration-testing/pull/14#discussion_r67776474
--- Diff:
core-it-suite/src/test/resources/mng-3092/filter-extension/pom.xml ---
@@ -0,0 +1,73 @@
+
+
+
+
+http
Github user barthel commented on a diff in the pull request:
https://github.com/apache/maven-integration-testing/pull/14#discussion_r67776182
--- Diff:
core-it-suite/src/test/resources/mng-3092/repo/org/apache/maven/its/mng3092/a/2.0-SNAPSHOT/a-2.0-20100408.111215-1.pom
Github user barthel commented on the issue:
https://github.com/apache/maven-integration-testing/pull/14
@michael-o Missing JARs added and changes included.
Integration tests run successfully:
```
[â¦]
---
T E
Github user barthel commented on the issue:
https://github.com/apache/maven/pull/70
@michael-o I'm working on integration tests right now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/70
@barthel Very good. Did you have a chance to work on the other issues I
have written?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user barthel commented on the issue:
https://github.com/apache/maven/pull/70
@michael-o Indent changes reverted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven/pull/70#discussion_r6723
--- Diff:
maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java
---
@@ -290,7 +312,7 @@ private Versionin
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven/pull/70#discussion_r67234380
--- Diff:
maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java
---
@@ -193,19 +216,18 @@ public VersionR
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven/pull/70#discussion_r67234423
--- Diff:
maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java
---
@@ -193,19 +216,18 @@ public VersionR
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven/pull/70#discussion_r67234434
--- Diff:
maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java
---
@@ -255,7 +277,7 @@ public VersionRan
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven/pull/70#discussion_r67234360
--- Diff:
maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java
---
@@ -136,15 +152,22 @@ public DefaultV
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven/pull/70#discussion_r67234340
--- Diff:
maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java
---
@@ -136,15 +152,22 @@ public DefaultV
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven/pull/70#discussion_r67234319
--- Diff:
maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java
---
@@ -136,15 +152,22 @@ public DefaultV
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven/pull/70#discussion_r67234272
--- Diff:
maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java
---
@@ -88,19 +91,27 @@
@Require
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven/pull/70#discussion_r67234247
--- Diff:
maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java
---
@@ -88,19 +91,27 @@
@Require
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven/pull/70#discussion_r67234207
--- Diff:
maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java
---
@@ -63,14 +64,16 @@
import java.
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven-integration-testing/pull/14#discussion_r67233942
--- Diff:
core-it-suite/src/test/resources/mng-3092/repo/org/apache/maven/its/mng3092/a/2.0-SNAPSHOT/a-2.0-20100408.111215-1.pom
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven-integration-testing/pull/14#discussion_r67233825
--- Diff:
core-it-suite/src/test/resources/mng-3092/filter-extension/src/main/java/org/apache/maven/its/extensions
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven-integration-testing/pull/14#discussion_r67233789
--- Diff:
core-it-suite/src/test/resources/mng-3092/filter-extension/src/main/java/org/apache/maven/its/extensions
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven-integration-testing/pull/14#discussion_r67233439
--- Diff:
core-it-suite/src/test/resources/mng-3092/filter-extension/pom.xml ---
@@ -0,0 +1,73 @@
+
+
+
+
+http
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven-integration-testing/pull/14#discussion_r67233418
--- Diff:
core-it-suite/src/test/resources/mng-3092/filter-extension/pom.xml ---
@@ -0,0 +1,73 @@
+
+
+
+
+http
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven-integration-testing/pull/14#discussion_r67233328
--- Diff:
core-it-suite/src/test/resources/mng-3092/filter-extension/pom.xml ---
@@ -0,0 +1,73 @@
+
+
+
+
+http
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven-integration-testing/pull/14#discussion_r67233290
--- Diff:
core-it-suite/src/test/resources/mng-3092/filter-extension/pom.xml ---
@@ -0,0 +1,73 @@
+
+
+
+
+http
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven-integration-testing/pull/14#discussion_r67233223
--- Diff:
core-it-suite/src/test/resources/mng-3092/filter-extension/pom.xml ---
@@ -0,0 +1,74 @@
+
+
+
+
+http
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-3092";>MNG-3092.
+ *
+ *
+ *
+ *
+ * org.apache.maven.its.mng3092
+ * a
+ * [1.0,2.0)
+ *
+ *
+ *
+ *
+ * @author Benjamin Bentman
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-3092";>MNG-3092.
+ *
+ *
+ *
+ *
+ * org.apache.maven.its.mng3092
+ * a
+ * [1.0,2.0)
+ *
+ *
+ *
+ *
+ * @author Benjamin Bentman
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-3092";>MNG-3092.
+ *
+ *
+ *
+ *
+ * org.apache.maven.its.mng3092
+ * a
+ * [1.0,2.0)
+ *
+ *
+ *
+ *
+ * @author Benjamin Bentman
it:
[INFO]
[INFO] Building Maven Integration Test :: MNG-3092 0.1
[INFO]
[INFO] Downloading:
file:///D:/Entwicklung
Github user barthel commented on the issue:
https://github.com/apache/maven-integration-testing/pull/14
@michael-o I changed something based on your comments.
* Duplication of version number removed in
```mng-3092/filter-extensionpom.xml```
* Version number changed in JavaDoc
Github user barthel commented on a diff in the pull request:
https://github.com/apache/maven-integration-testing/pull/14#discussion_r67101198
--- Diff:
core-it-suite/src/test/resources/mng-3092/filter-extension/pom.xml ---
@@ -0,0 +1,74 @@
+
+
+
+
+http
Github user barthel commented on a diff in the pull request:
https://github.com/apache/maven-integration-testing/pull/14#discussion_r67099834
--- Diff:
core-it-suite/src/test/resources/mng-3092/filter-extension/src/main/java/org/apache/maven/its/extensions
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven-integration-testing/pull/14#discussion_r67063784
--- Diff:
core-it-suite/src/test/resources/mng-3092/filter-extension/src/main/java/org/apache/maven/its/extensions
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven-integration-testing/pull/14#discussion_r67059400
--- Diff:
core-it-suite/src/test/resources/mng-3092/filter-extension/src/main/java/org/apache/maven/its/extensions
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven-integration-testing/pull/14#discussion_r67059367
--- Diff:
core-it-suite/src/test/resources/mng-3092/filter-extension/pom.xml ---
@@ -0,0 +1,74 @@
+
+
+
+
+http
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven-integration-testing/pull/14#discussion_r67059339
--- Diff:
core-it-suite/src/test/resources/mng-3092/filter-extension/pom.xml ---
@@ -0,0 +1,74 @@
+
+
+
+
+http
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-3092";>MNG-3092.
+ *
+ *
+ *
+ *
+ * org.apache.maven.its.mng3092
+ * a
+ * [1.0,2.0)
+ *
+ *
+ *
+ *
+ * @author Benjamin Bentman
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-3092";>MNG-3092.
+ *
+ *
+ *
+ *
+ * org.apache.maven.its.mng3092
+ * a
+ * [1.0,2.0)
+ *
+ *
+ *
+ *
+ * @author Benjamin Bentman
Github user barthel commented on the issue:
https://github.com/apache/maven/pull/70
I would like to look at ```ContextualSnapshotVersionFilter``` solution, if
the Aether code was moved back to Apache Maven.
---
If your project is set up for it, you can reply to this email and have yo
Github user barthel commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-198910133
@dinoboy197: Sorry, I haven't had time to look at @ChristianSchulte
suggestion until now.
@jvanzyl @michael-o: Suggestion: Merge this solution. I'll evaluate the
```Co
Github user dinoboy197 commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-198031554
@michael-o @jvanzyl @barthel - just checking in to see if any progress has
been made on reviewing this.
---
If your project is set up for it, you can reply to this ema
Github user ChristianSchulte commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-188009400
@barthel: See
[c31be833a6f8d9266990a708efe624d09fa06dec](https://github.com/ChristianSchulte/maven/commit/c31be833a6f8d9266990a708efe624d09fa06dec)
---
If your p
Github user barthel commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-187570913
@ChristianSchulte : Sounds interesting. I'll take a look on it at the end
of this week.
---
If your project is set up for it, you can reply to this email and have your
re
Github user michael-o commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-185895693
@barthel much but I won't be able to take a closer at it before next week.
@jvanzyl if you can do it sooner, just go again and do it.
---
If your project is set up for
Github user barthel commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-185894318
@dinoboy197 : Fantastic. Thanks for your help. After reading your post, it
sounds so logical.
@michael-o , @jvanzyl : Now the merge comes true? :-D
---
If your p
Github user dinoboy197 commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-185839435
@barthel - I think all you should need to do is to rebase your feature
branch (MNG-3092) against upstream/master.
Something like this should do it (assuming
Github user barthel commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-184374596
@michael-o Sorry I've no idea how to remove the merge 'noise' from this
really old branch. The only change of mine is ```28fd43d```.
---
If your project is set up for it,
Github user michael-o commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-184350865
This commit is huge and has a lot of merge noise. Do you think you can
squeeze it down to your changes only?
---
If your project is set up for it, you can reply to this
Github user barthel commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-184328357
@jvanzyl @michael-o : Read to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user barthel commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-184327161
Integration test pull request:
https://github.com/apache/maven-integration-testing/pull/14
---
If your project is set up for it, you can reply to this email and have your
GitHub user barthel opened a pull request:
https://github.com/apache/maven-integration-testing/pull/14
MNG-3092: Adds integration tests for version range result filter behaviour
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user barthel commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-184308767
Use JSR 330 annotation instead of the Plexus annotation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user barthel commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-184304203
@jvanzyl : Thanks for your tip. Now it works. :-D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-183894970
I suggest looking at more recent integration tests which are similar to
yours where there is a default implementation and new implementations can be
used. Take a look at M
Github user barthel commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-183661203
@jvanzyl , @michael-o : I start working on the integration tests. It's
more complicated than I thought.
The default handling works but I have difficulties to inje
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-180506499
Not critical, I can add the annotations later. More important are
integration tests if you haven't started those yet. If you have, great!
---
If your project is set up fo
Github user barthel commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-180504355
It's an old branch. So I merged the actual master into it and use Maven
3.4.0-SNAPSHOT instead.
Only the last commit reflects the MNG-3092 sol
Github user barthel commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-178390879
@jvanzyl , @michael-o : Sorry for the delay. I'm busy right now. I will try
to do the change to Maven 3.4 (and JSR330) and add a integration test. But not
before friday th
Github user michael-o commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-174671286
This is what I have expected you to say ;-)
@barthel or anyone else, can you craft up an IT for that?
---
If your project is set up for it, you can reply to this ema
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-174668942
For a feature like that there should be an integration test as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user michael-o commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-174666838
@jvanzyl There are unit tests in the commit. Isn't that enough? Otherwise,
I'd ask @barthel for it.
---
If your project is set up for it, you can reply to this email an
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-174664828
If there are integration tests don't wait for me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user pSub commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-174664718
I would appreciate a merge, too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user michael-o commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-174656884
Can we make any progress here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-160451976
We're looking at the new year for the next core release so you have time. I
might have my JSR330 changes done by then. I have 15 super nasty uses of Plexus
to get around b
Github user barthel commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-160448962
I'm busy the next few days. But I will give it a try if these changes have
a chance to merge in 3.3.10.
---
If your project is set up for it, you can reply to this email
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-159774308
@barthel I ask this to be done because with some recent changes in Sisu I
actually have a chance to land my JSR330 branch which entirely removes Plexus
from Maven. @mccull
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-159774014
@barthel I mean using the JSR330 equivalents for @Component and
@Requirement. For @Component we replace them with @Named and @Singleton used
together at the class level, a
Github user michael-o commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-159743197
@barthel While I am not a Git expert. I extract a patch/stash fo the work.
Branch master, apply stash and commit again.
[This](http://stackoverflow.com/q/16358418/696632
Github user barthel commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-159729295
@jvanzyl Did you mean ```@Requirement``` and ```@Component```?
I'm following the coding style found in the classes around.
Please point me to the replacements f
Github user barthel commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-159728334
@michael-o Indent size and inside issues solved. Commits squashed and amend
on last commit in branch.
What can I do to avoid the merge commit? If I merge the master int
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-159585971
Just looking through here and you also switch these to use JSR330
annotations instead of the plexus annotations. Any additions I'd like to see
use JSR330 which is what we
Github user michael-o commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-159546743
There are still some issues with the branch. You did not replay on top of
master. It is creating a merge commit which I'd like to avoid. Some other
issues will be commen
Github user barthel commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-159399815
Organize import in ```DefaultVersionRangeResolver``` and squash commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user michael-o commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-159366801
@barthel Git gives me:
> git merge --no-commit barthel/MNG-3092
Auto-merging
maven-aether-provider/src/main/java/org/apache/maven/repository/inter
Github user michael-o commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-159078734
Thanks, I will test and merge tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user barthel commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-159076106
POM file adapted. Use parent version 3.3.10-SNAPSHOT and remove
```commons-lang``` dependency.
---
If your project is set up for it, you can reply to this email and have
Github user michael-o commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-159062461
@barthel See my inline comments. Then I will take it from there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user barthel commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-159059568
@michael-o see my comment Oct 19:
> Please remove version property for commons-lang when merging into the
master.
That's the rework you suggest with working on
Github user michael-o commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-159045732
@barthel GitHub tells me that this branch has conflicts. Can you kindly
check if rebase on top of master if necessary?
---
If your project is set up for it, you can rep
Github user barthel commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-159011269
I would like to see this changes in the next Maven (3.3.10) release.
@michael-o @jvanzyl Please don't forget to merge :-)
---
If your project is set up for it, you can
I was trying to cut the release first but I’m going to have to roll it again. I
will integrate your work after the release.
> On Nov 2, 2015, at 9:46 PM, Uwe Barthel wrote:
>
> My PR for “Adds version range result filter behaviour”
> (https://github.com/apache/maven/pull/70) is ready for mergi
My PR for “Adds version range result filter behaviour”
(https://github.com/apache/maven/pull/70) is ready for merging and needs a
willing committer to merge into master.
Please take a look and leave a comment if I could support the merging somehow.
mit freundlichen Grüßen
Uwe Barthel
--
bart..
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-151499565
Then I donât see an issue with merging it.
> On Oct 27, 2015, at 4:38 AM, barthel wrote:
>
> The default behavior is do nothing. The ITs doesn't show an
Changing the default behaviour of anything resolution related mid 3.x line is
likely not a good idea. We definitely need to run the ITs with any changes like
these to see what happens. Changing the way resolution works is definitely a
4.x thing.
> On Oct 27, 2015, at 1:42 AM, michael-o wrote:
Github user barthel commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-151463857
The default behavior is ``do nothing``. The ITs doesn't show any errors at
this modifications.
---
If your project is set up for it, you can reply to this email and have
Github user michael-o commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-151415114
@jvanzyl Are you saying that you dislike to change the default behavior,
i.e., no merge? @barthel Did you run the ITs before and after your change?
---
If your project
Github user barthel commented on the pull request:
https://github.com/apache/maven/pull/70#issuecomment-151395866
Can I do anything to support the merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
1 - 100 of 137 matches
Mail list logo
