Re: Logger and Embedded Maven Core ITs

2013-03-17 Thread Jason van Zyl
Thanks Ceki, the change you made works. On Mar 17, 2013, at 1:10 PM, ceki wrote: > > > On 17.03.2013 00:47, Jason van Zyl wrote: >> If that's the case Ceki might be able to add the clearing of the logger map >> to the reset method. >> >> Ceki, would this be hard to change? > > I just added

Re: Logger and Embedded Maven Core ITs

2013-03-17 Thread Jason van Zyl
Thanks! We can try it with the helper we currently have. jvz On 2013-03-17, at 1:10 PM, ceki wrote: > > > On 17.03.2013 00:47, Jason van Zyl wrote: >> If that's the case Ceki might be able to add the clearing of the logger map >> to the reset method. >> >> Ceki, would this be hard to change

Re: Logger and Embedded Maven Core ITs

2013-03-17 Thread ceki
On 17.03.2013 00:47, Jason van Zyl wrote: If that's the case Ceki might be able to add the clearing of the logger map to the reset method. Ceki, would this be hard to change? I just added a reset method to SimpleLoggerFactory. See https://github.com/qos-ch/slf4j/commit/6dd3a60ee77a5cd17e f

Re: Logger and Embedded Maven Core ITs

2013-03-16 Thread Stuart McCulloch
On 16 Mar 2013, at 23:38, Stuart McCulloch wrote: > On 16 Mar 2013, at 13:58, Jason van Zyl wrote: > >> Hervé, >> >> Can you take a look at the logging changes you made to try and use the SLF4J >> package private method for resetting the logger? The streams are being reset >> correctly but th

Re: Logger and Embedded Maven Core ITs

2013-03-16 Thread Jason van Zyl
If that's the case Ceki might be able to add the clearing of the logger map to the reset method. Ceki, would this be hard to change? On Mar 16, 2013, at 4:38 PM, Stuart McCulloch wrote: > On 16 Mar 2013, at 13:58, Jason van Zyl wrote: > >> Hervé, >> >> Can you take a look at the logging cha

Re: Logger and Embedded Maven Core ITs

2013-03-16 Thread Stuart McCulloch
On 16 Mar 2013, at 13:58, Jason van Zyl wrote: > Hervé, > > Can you take a look at the logging changes you made to try and use the SLF4J > package private method for resetting the logger? The streams are being reset > correctly but the logging level doesn't appear to be reset which causes the

Logger and Embedded Maven Core ITs

2013-03-16 Thread Jason van Zyl
Hervé, Can you take a look at the logging changes you made to try and use the SLF4J package private method for resetting the logger? The streams are being reset correctly but the logging level doesn't appear to be reset which causes the embedded ITs to fail. Thanks, Jason ---