Hi,
Sorry for being late to the discussion. Here are my thoughts on the subject.
I agree that we should turn on Rat by default for all our projects
within Apache Maven. There are still a bunch of projects that
currently fail the Rat check, see private area in svn for more info.
Some of them fail
Hello,
I was speaking about the Rat report for the whole project (which is the parent
of the core). The Rat-Plugin in the site creation seems to run for 107s on my
machine (the Javadoc runs 17s).
But maybe I read the output wrong, maven logs can be quite confusing:
73090 [INFO] Generating "Rat
+1
I think we should have rat on every build by default, and only avoid it if it
ever cause real performance issue (which doesn't seem to happen)
https://issues.apache.org/jira/browse/MPOM-52 created
Regards,
Hervé
Le dimanche 18 mai 2014 14:38:56 Jason van Zyl a écrit :
> It's the site phase
+1
On Sunday, 18 May 2014, Jason van Zyl wrote:
> Right now though we require all files to have license headers we do not
> run the check to verify this by default.
>
> It kept dinging me until I turned it on by default in Maven core. Someone
> currently trying to contribute has no idea this is
It's the site phase itself that takes a long time.
On the commons-vfs core module it's takes little time:
https://gist.github.com/jvanzyl/69c038c0f100803f10db
I argue that the release should always be in a ready state to release, all
requirements need to be met at all times in order for this to
On May 18, 2014, at 1:43 PM, Jason Pyeron wrote:
>> -Original Message-
>> From: Jason van Zyl
>> Sent: Sunday, May 18, 2014 13:05
>>
>> Right now though we require all files to have license headers
>> we do not run the check to verify this by default.
>>
>
> Can it be turned off by
Currently the Rat Report in the Site phase of commons-vfs takes enormous time,
for really no good use when the commits are reviewed anyway (and it has all
kinds of excludes and warnings you manually need to check).
So I argue it would be better to run it only in relase (candidate) builds. Not
> -Original Message-
> From: Jason van Zyl
> Sent: Sunday, May 18, 2014 13:05
>
> Right now though we require all files to have license headers
> we do not run the check to verify this by default.
>
Can it be turned off by option?
> It kept dinging me until I turned it on by default i
Right now though we require all files to have license headers we do not run the
check to verify this by default.
It kept dinging me until I turned it on by default in Maven core. Someone
currently trying to contribute has no idea this is a requirement and is not
told so because it doesn't run b
