Re: [maven-integration-testing] branch master updated: Sort ITs in reverse numerical order

2020-08-09 Thread Martin Kanters
to a > > consensus. > > > > Regards, > > Martin > > > > [1] > > > https://github.com/apache/maven-integration-testing/commit/077b9d3c9d9efcd9192082516d358b943ea3edcf#diff-02304634c9e39f8f1ec68f6cb88d51edR89 > > > > Op wo 5 aug. 2020 om 20

Re: [maven-integration-testing] branch master updated: Sort ITs in reverse numerical order

2020-08-09 Thread Michael Osipov
ng of this list is to order them on the date of implementation [1]. The rationale being that the latest implemented tests are potentially the least stable. I personally do not have a strong preference, but we should come to a consensus. Regards, Martin [1] https://github.com/apache/maven-integrati

Re: [maven-integration-testing] branch master updated: Sort ITs in reverse numerical order

2020-08-09 Thread Martin Kanters
ensus. Regards, Martin [1] https://github.com/apache/maven-integration-testing/commit/077b9d3c9d9efcd9192082516d358b943ea3edcf#diff-02304634c9e39f8f1ec68f6cb88d51edR89 Op wo 5 aug. 2020 om 20:57 schreef : > This is an automated email from the ASF dual-hosted git repository. > > michaelo p

Use Java 8 in maven-integration-testing

2020-05-04 Thread Maarten Mulders
Hi all, While working on a new feature in Maven, I was writing some integration tests as well. I wanted to use Paths.get(...) and Files.newBufferedReader(...), but then I noticed that maven-integration-testing is (still) being built with Java 7 [1]. I understand it is important we can test

Re: Next Generation Integration Testing for Plugins/Core

2019-11-01 Thread Romain Manni-Bucau
Hi everyone, Yesterday I needed to test a maven plugin around graal so wrote a junit5 extension relying on testcontainers. Think it is close to this thread so sharing the idea/code: https://gitbox.apache.org/repos/asf?p=geronimo-arthur.git;a=blob;f=integration-test/src/test/java/org/apache/geronim

Re: Next Generation Integration Testing for Plugins/Core

2019-10-31 Thread Tibor Digana
am, programming language is our toy ;-) everybody has some preferences, so i respect them and i understand that even the Lambda would be a big jump for us nevertheless the Groovy or Kotlin. i saw the parameterized tests, re-runs in Groovy, log result of assertion statements, and I spoke with Benedi

Re: Next Generation Integration Testing for Plugins/Core

2019-10-31 Thread Vladimir Sitnikov
Karl>on the language features but since JDK8 I don't see any advantage What about Kotlin? There are nice things there: the language is statically compiled, great Java interop, there are extension functions, multiline strings, helpful standard library, default parameters. Kotlin is great for creat

Re: Next Generation Integration Testing for Plugins/Core

2019-10-30 Thread Paul Hammant
Integration test choices include the excellent Spock as mentioned. I've used it and it's very solid. Two more choices include: Another choice is Cuppa - https://github.com/cuppa-framework/cuppa I've used this too, and it's great - no right-click-run-this-one in Intellij though. I wish it had more

Re: Next Generation Integration Testing for Plugins/Core

2019-10-30 Thread Paul Hammant
Oops. Blog entry linking to video of 16s build - https://paulhammant.com/2017/02/05/a-16-second-java-webapp-build-including-webdriver-tests/

Re: Next Generation Integration Testing for Plugins/Core

2019-10-30 Thread Enrico Olivelli
Karl (Sorry for top posting) Thank you very much for moving this forward. In my personal experience one real blocker in contributions to Maven, expecially plugins, is to write integration tests. So having a nice way to create tests is very welcome. Having a way to run tests as simple unit tests fro

Re: Next Generation Integration Testing for Plugins/Core

2019-10-30 Thread Karl Heinz Marbaise
Hi, let me conclude some of the things together: The decision which I have made against Spock was based on several reasons: * People often tend to write Java code (which is valid), cause they don't know Groovy or don't want to learn a new language just to write tests. This means in th

Re: Next Generation Integration Testing for Plugins/Core

2019-10-30 Thread Romain Manni-Bucau
Not sure I understand it well Tibor, do you encourage to multiply the number of potential solutions to request more time to contributor to see how to do things? Don't think it is good, a single simple solution sounds more promising - once again from my past experience. Once again Tibor, all I'm wr

Re: Next Generation Integration Testing for Plugins/Core

2019-10-30 Thread Tibor Digana
Romain, the Java has not made any significant progress in language after Java 9. Yes, some JVM features in J13 were really great but not in language. All fixes about switch-case in several versions, strings, preliminary feature. Nothing very progressive for developers! And I think the frequent rele

Re: Next Generation Integration Testing for Plugins/Core

2019-10-30 Thread Romain Manni-Bucau
@Tibor: do you agree we write the tests with chai (js)? It is the same to use groovy for a java dev today since java caught up its lateness. Not stacking layers and avoiding useless abstractions is the best way to enable people to contribute from my experience. As soon as you add a layer which has

Re: Next Generation Integration Testing for Plugins/Core

2019-10-30 Thread Tibor Digana
Romain, I am glad that you are with me. Attracting the contributors! I hope we all voted for Java 8 sources in Maven Core. And Spock is the same story. Java is the like C++ old style. Lambda makes this language more moderns a bit. Regarding issues with Java 14, all can be fixed, just give the Sp

Re: Next Generation Integration Testing for Plugins/Core

2019-10-30 Thread Romain Manni-Bucau
@Tibor: one goal we should focus on on any new feature is to enable us to attract more new contributors, spock has the disadvantage to not be mainstream at all + to be on groovy which has some issues to support recent java version so it will not help it to be more adopted, therefore I guess jupiter

Re: Next Generation Integration Testing for Plugins/Core

2019-10-30 Thread Karl Heinz Marbaise
Hi, On 30.10.19 15:23, Stephen Connolly wrote: On Tue, 29 Oct 2019 at 22:16, Romain Manni-Bucau wrote: Le mar. 29 oct. 2019 à 22:58, Karl Heinz Marbaise a écrit : Hi Romain, On 29.10.19 22:40, Romain Manni-Bucau wrote: Hi Karl Not sure id do a MavenIT annotation - test is enough probabl

Re: Next Generation Integration Testing for Plugins/Core

2019-10-30 Thread Tibor Digana
Karl, where you define CLI command in each test? Regarding the f/w you have selected. If I had to decide between JUnit5 or Groovy/Spock, I would decide for Spock. On Tue, Oct 29, 2019 at 9:47 PM Karl Heinz Marbaise wrote: > Hi to all, > > I've invested some time to get a thing working in a diffe

Re: Next Generation Integration Testing for Plugins/Core

2019-10-30 Thread Tibor Digana
well, you have use different JVMs if you expect different env vars. On Wed, Oct 30, 2019 at 3:23 PM Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > On Tue, 29 Oct 2019 at 22:16, Romain Manni-Bucau > wrote: > > > Le mar. 29 oct. 2019 à 22:58, Karl Heinz Marbaise a > > écrit : > > >

Re: Next Generation Integration Testing for Plugins/Core

2019-10-30 Thread Romain Manni-Bucau
Good point so guess it can be combined with a config (more a system properties) to run in memory or forked and therefore the fs can be either in mem or just populated from the spec (annotations). Was looking to get something more fluent on the full setup than matching multiple resources which is -

Re: Next Generation Integration Testing for Plugins/Core

2019-10-30 Thread Stephen Connolly
On Tue, 29 Oct 2019 at 22:16, Romain Manni-Bucau wrote: > Le mar. 29 oct. 2019 à 22:58, Karl Heinz Marbaise a > écrit : > > > Hi Romain, > > > > On 29.10.19 22:40, Romain Manni-Bucau wrote: > > > Hi Karl > > > > > > Not sure id do a MavenIT annotation - test is enough probably - but i > > > like

Re: Next Generation Integration Testing for Plugins/Core

2019-10-29 Thread Romain Manni-Bucau
Le mar. 29 oct. 2019 à 22:58, Karl Heinz Marbaise a écrit : > Hi Romain, > > On 29.10.19 22:40, Romain Manni-Bucau wrote: > > Hi Karl > > > > Not sure id do a MavenIT annotation - test is enough probably - but i > > like jupiter style. > > MavenIT[1] annotation contains more information like glob

Re: Next Generation Integration Testing for Plugins/Core

2019-10-29 Thread Karl Heinz Marbaise
Hi Romain, On 29.10.19 22:40, Romain Manni-Bucau wrote: Hi Karl Not sure id do a MavenIT annotation - test is enough probably - but i like jupiter style. MavenIT[1] annotation contains more information like global/local cache, the default goals which are used for the build, debugging or not (

Re: Next Generation Integration Testing for Plugins/Core

2019-10-29 Thread Romain Manni-Bucau
Hi Karl Not sure id do a MavenIT annotation - test is enough probably - but i like jupiter style. Im less exited by assertj but it is probably a habit thing. Wonder if you evaluated to run in a fake filesystem like jimfs or so and enable the pom+files to be defined on the test method? Goal would

Next Generation Integration Testing for Plugins/Core

2019-10-29 Thread Karl Heinz Marbaise
Hi to all, I've invested some time to get a thing working in a different way which nags me for a long time. Integration tests for maven plugins and for maven core... So created a prototype based on a JUnit Jupiter extension. The following is the JUnit Jupiter extension (currently very hacky co

Re: [maven-integration-testing] branch master updated: [MNG-6725] Skip '.mavenrc' via MAVEN_SKIP_RC=1 and '-Dmaven.skip.rc=true' on child ITs (by default on Jenkins CI).

2019-08-03 Thread Hervé BOUTEMY
issue fixed, this commit causes more harm than anything else -1, please revert Regards, Hervé Le mercredi 31 juillet 2019, 19:01:29 CEST Hervé BOUTEMY a écrit : > doing > > > +if ( MAVEN_SKIP_RC ) > > +{ > > +verifier.setEnvironmentVariable( "MAVEN_SKIP_RC", "1" ); >

Re: [maven-integration-testing] branch master updated: [MNG-6725] Skip '.mavenrc' via MAVEN_SKIP_RC=1 and '-Dmaven.skip.rc=true' on child ITs (by default on Jenkins CI).

2019-07-31 Thread Hervé BOUTEMY
doing > +if ( MAVEN_SKIP_RC ) > +{ > +verifier.setEnvironmentVariable( "MAVEN_SKIP_RC", "1" ); > +} requires forked execution of Maven this de-facto disables embedder mode as a consequence, we can see on ASF Jenkins server [1] that build time for core ITs has d

Re: [maven-integration-testing] branch master updated: [MNG-6481] Fix Wagon sample plugin to pass tests with Java 11

2018-11-10 Thread Robert Scholte
This is an interesting change, I noticed this failure on my local machine as well. However, I wonder if this a JDK bug or an intended change. Will try to get the answer next week. Robert On Sat, 10 Nov 2018 02:47:24 +0100, wrote: -File file = new File( "target/wagon.properties"

Re: [maven-integration-testing] 01/01: [MNG-5667] Either install or deploy

2018-09-22 Thread Enrico Olivelli
Il sab 22 set 2018, 21:38 Robert Scholte ha scritto: > Hi, > > up until now the lifecycle used to be linear, but there are cases where > it > makes more sense to make decision. The choice between install and deploy > is the first one. > This will be the new definition of the default lifecycle, so

Re: [maven-integration-testing] 01/01: [MNG-5667] Either install or deploy

2018-09-22 Thread Robert Scholte
Hi, up until now the lifecycle used to be linear, but there are cases where it makes more sense to make decision. The choice between install and deploy is the first one. This will be the new definition of the default lifecycle, so there's no legacy mode. And to be honest, is there such a ne

Re: [maven-integration-testing] 01/01: [MNG-5667] Either install or deploy

2018-09-22 Thread Enrico Olivelli
Hi, I can't see any flag to switch to legacy mode, is this intended? We are adding a new 'choice' element, will it be documented or is it for internal use ? Enrico Il sab 22 set 2018, 20:44 ha scritto: > This is an automated email from the ASF dual-hosted git repository. > > rfscholte pushed a

[GitHub] maven-integration-testing pull request #26: [MNG-6298] 3.5.2: ClassNotFoundE...

2017-12-04 Thread bengtsod
GitHub user bengtsod opened a pull request: https://github.com/apache/maven-integration-testing/pull/26 [MNG-6298] 3.5.2: ClassNotFoundException Test for https://github.com/apache/maven/pull/139 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] maven-integration-testing pull request #25: Importing a BOM works even when ...

2017-11-28 Thread jglick
Github user jglick commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/25#discussion_r153657657 --- Diff: core-it-suite/src/test/java/org/apache/maven/it/MavenIT0199CyclicImportScopeTest.java --- @@ -0,0 +1,56 @@ +package

[GitHub] maven-integration-testing pull request #25: Importing a BOM works even when ...

2017-11-28 Thread jglick
Github user jglick commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/25#discussion_r153657727 --- Diff: core-it-suite/src/test/java/org/apache/maven/it/MavenIT0199CyclicImportScopeTest.java --- @@ -0,0 +1,56 @@ +package

[GitHub] maven-integration-testing pull request #25: Importing a BOM works even when ...

2017-11-28 Thread jglick
Github user jglick commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/25#discussion_r153657505 --- Diff: core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java --- @@ -654,6 +654,7 @@ public static Test suite

[GitHub] maven-integration-testing pull request #25: Importing a BOM works even when ...

2017-11-28 Thread jglick
GitHub user jglick opened a pull request: https://github.com/apache/maven-integration-testing/pull/25 Importing a BOM works even when it has the same components in dep mgmt Does not correspond to any known bug, but it seems like a potentially unusual practice deserving of test

[GitHub] maven-integration-testing issue #21: [MNG-6127] Add plugin execution configu...

2017-08-15 Thread mkrizmanic
Github user mkrizmanic commented on the issue: https://github.com/apache/maven-integration-testing/pull/21 already merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] maven-integration-testing pull request #21: [MNG-6127] Add plugin execution ...

2017-08-15 Thread mkrizmanic
Github user mkrizmanic closed the pull request at: https://github.com/apache/maven-integration-testing/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] maven-integration-testing issue #24: Add test for MNG-6255 jvm.config line e...

2017-07-26 Thread grkvlt
Github user grkvlt commented on the issue: https://github.com/apache/maven-integration-testing/pull/24 Removed *CR* test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] maven-integration-testing issue #23: [MNG-6265] Integration test for Maven s...

2017-07-19 Thread etzelc
Github user etzelc commented on the issue: https://github.com/apache/maven-integration-testing/pull/23 Thanks for your testing effort. I am surprised both tests pass in your Windows environment with 3.5.0. I tested the IT with two different clients (Windows 7 and Windows 10) and

[GitHub] maven-integration-testing issue #24: Add test for MNG-6255 jvm.config line e...

2017-07-18 Thread grkvlt
Github user grkvlt commented on the issue: https://github.com/apache/maven-integration-testing/pull/24 Tested on OSX; passes when change from https://github.com/apache/maven/pull/127 are made to the `mvn` script. --- If your project is set up for it, you can reply to this email and

[GitHub] maven-integration-testing pull request #24: Add test for MNG-6255 jvm.config...

2017-07-18 Thread grkvlt
GitHub user grkvlt opened a pull request: https://github.com/apache/maven-integration-testing/pull/24 Add test for MNG-6255 jvm.config line endings Integration test for fix made in https://github.com/apache/maven/pull/127 You can merge this pull request into a Git repository by

[GitHub] maven-integration-testing issue #23: [MNG-6265] Integration test for Maven s...

2017-07-17 Thread Tunaki
Github user Tunaki commented on the issue: https://github.com/apache/maven-integration-testing/pull/23 I ran the IT with 3.5.0 on Windows, but it passed. Since the issue resolves around the error message that is printed on the console, I think the two files `folder-with- -space

[GitHub] maven-integration-testing pull request #23: [MNG-6265] Integration test for ...

2017-07-17 Thread etzelc
GitHub user etzelc opened a pull request: https://github.com/apache/maven-integration-testing/pull/23 [MNG-6265] Integration test for Maven script can break if "-f" path contains special characters Add the integration test for issue MNG-6256 (pull request apache/maven#1

[GitHub] maven-integration-testing pull request #22: [MNG-5965] Parallel build multip...

2017-07-05 Thread dbmeneses
GitHub user dbmeneses opened a pull request: https://github.com/apache/maven-integration-testing/pull/22 [MNG-5965] Parallel build multiplies work if multiple goals are given You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] maven-integration-testing pull request #21: [MNG-6127] Add plugin execution ...

2017-05-05 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/21#discussion_r115065672 --- Diff: core-it-suite/src/test/resources/mng-6127/plugin/pom.xml --- @@ -0,0 +1,55 @@ + + + + +http

[GitHub] maven-integration-testing pull request #21: [MNG-6127] Add plugin execution ...

2017-05-05 Thread mkrizmanic
Github user mkrizmanic commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/21#discussion_r115063523 --- Diff: core-it-suite/src/test/resources/mng-6127/plugin/pom.xml --- @@ -0,0 +1,55 @@ + + + + +http

[GitHub] maven-integration-testing pull request #21: [MNG-6127] Add plugin execution ...

2017-05-05 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/21#discussion_r115049986 --- Diff: core-it-suite/src/test/resources/mng-6127/plugin/pom.xml --- @@ -0,0 +1,55 @@ + + + + +http

[GitHub] maven-integration-testing pull request #21: [MNG-6127] Add plugin execution ...

2017-04-12 Thread mkrizmanic
GitHub user mkrizmanic opened a pull request: https://github.com/apache/maven-integration-testing/pull/21 [MNG-6127] Add plugin execution configuration interference test You can merge this pull request into a Git repository by running: $ git pull https://github.com/mkrizmanic

Re: maven-integration-testing git commit: Add some exotic test environments

2017-04-03 Thread Stephen Connolly
are faster to provision, but for the non-linux based OSes I think Vagrantfile is the best solution On 3 April 2017 at 12:00, wrote: > Repository: maven-integration-testing > Updated Branches: > refs/heads/master 5c8219531 -> 09bc7b54c > > > Add some exotic test environment

[GitHub] maven-integration-testing pull request #20: Integration tests for various JI...

2017-03-25 Thread ChristianSchulte
GitHub user ChristianSchulte opened a pull request: https://github.com/apache/maven-integration-testing/pull/20 Integration tests for various JIRA issues. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ChristianSchulte/maven

Re: Build failed in Jenkins: core-integration-testing-maven-3-embedded #7571

2017-03-25 Thread Hervé BOUTEMY
idea? Regards, Hervé Le samedi 25 mars 2017, 10:37:58 CET Apache Jenkins Server a écrit : > See > <https://builds.apache.org/job/core-integration-testing-maven-3-embedded/75 > 71/display/redirect?page=changes> > > Changes: > > [hboutemy] upgraded parent pom

[GitHub] maven-integration-testing pull request #19: [MNG-6173] MavenSession.getAllPr...

2017-03-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven-integration-testing/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] maven-integration-testing pull request #19: [MNG-6173] MavenSession.getAllPr...

2017-03-04 Thread cboehme
GitHub user cboehme opened a pull request: https://github.com/apache/maven-integration-testing/pull/19 [MNG-6173] MavenSession.getAllProjects() should return all projects in the reactor Integration tests for issue [MNG-6173](https://issues.apache.org/jira/browse/MNG-6173) as

Re: maven-integration-testing git commit: 3.5.0-alpha-1 < 3.5.0

2017-02-24 Thread Christian Schulte
Am 02/24/17 um 20:48 schrieb steph...@apache.org: > Repository: maven-integration-testing > Updated Branches: > refs/heads/master 3883e005e -> c4cd8cf3b > > > 3.5.0-alpha-1 < 3.5.0 Thanks. - To

Re: maven-integration-testing git commit: Provide a mechanism whereby tests can indicate versions of Maven expected to fail

2017-02-01 Thread Christian Schulte
Am 02/02/17 um 01:35 schrieb Stephen Connolly: > Well we want that test the other way, we want it to pass everywhere except > the buggy releases 3.3.0 and 3.3.9 Ok. Means I do not need to change anything about that test and can leave it the way it was. I just need a way to indicate the expected fa

Re: maven-integration-testing git commit: Provide a mechanism whereby tests can indicate versions of Maven expected to fail

2017-02-01 Thread Stephen Connolly
Well we want that test the other way, we want it to pass everywhere except the buggy releases 3.3.0 and 3.3.9 Having a test to cover broken behaviour is exactly not what we want imho On Wed 1 Feb 2017 at 23:15, Christian Schulte wrote: > Am 02/02/17 um 00:10 schrieb Stephen Connolly: > > Sorry

Re: maven-integration-testing git commit: Provide a mechanism whereby tests can indicate versions of Maven expected to fail

2017-02-01 Thread Christian Schulte
Am 02/02/17 um 00:10 schrieb Stephen Connolly: > Sorry we want the inverse, > > "(,3.3.0),(3.3.0,3.3.9),(3.3.9,)" > > If the test is expected to fail on everything except 3.3.0 and 3.3.9 but > such a test is not the usecase for this tool That's what I was looking for. I have that use case for th

Re: maven-integration-testing git commit: Provide a mechanism whereby tests can indicate versions of Maven expected to fail

2017-02-01 Thread Stephen Connolly
Sorry we want the inverse, "(,3.3.0),(3.3.0,3.3.9),(3.3.9,)" If the test is expected to fail on everything except 3.3.0 and 3.3.9 but such a test is not the usecase for this tool On Wed 1 Feb 2017 at 23:09, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > With the range "[3.3.0],[3.

Re: maven-integration-testing git commit: Provide a mechanism whereby tests can indicate versions of Maven expected to fail

2017-02-01 Thread Stephen Connolly
With the range "[3.3.0],[3.3.9]" On Wed 1 Feb 2017 at 23:04, Christian Schulte wrote: > Out of curiosity: How would I specify the test to fail on all Maven > versions but 3.3.0 and 3.3.9? > > > - > To unsubscribe, e-mail: dev-un

Re: maven-integration-testing git commit: Provide a mechanism whereby tests can indicate versions of Maven expected to fail

2017-02-01 Thread Christian Schulte
Out of curiosity: How would I specify the test to fail on all Maven versions but 3.3.0 and 3.3.9? - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

Re: maven-integration-testing git commit: Provide a mechanism whereby tests can indicate versions of Maven expected to fail

2017-02-01 Thread Stephen Connolly
kedBooter.runSuitesInProcess(ForkedBooter.java:153) > at > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103) > > Results : > Failed tests: > > MavenITmng5958LifecyclePhaseBinaryCompat>AbstractMavenIntegrationTestCase.runTest:244 > Expected failure wh

[GitHub] maven-integration-testing pull request #18: [MNG-5958] restore binary compat...

2017-01-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven-integration-testing/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] maven-integration-testing pull request #18: [MNG-5958] restore binary compat...

2017-01-15 Thread atanasenko
GitHub user atanasenko opened a pull request: https://github.com/apache/maven-integration-testing/pull/18 [MNG-5958] restore binary compatibility of Lifecycle.setPhases Modify tests for MNG-5805 You can merge this pull request into a Git repository by running: $ git pull https

Re: maven-integration-testing git commit: [MNG-3599] Need to use --legacy-local-repository on newer maven versions

2017-01-11 Thread Arnaud Héritier
ix for the issue? > > > > > > > > > > (I could add a FIXME to the test as a marker that we intend to fix the > > > > > test > > > > > more correctly at a future point in time) > > > > > > > > > > On Wed 11

Re: maven-integration-testing git commit: [MNG-3599] Need to use --legacy-local-repository on newer maven versions

2017-01-11 Thread Stephen Connolly
Wed 11 Jan 2017 at 17:02, Stephen Connolly < > > > stephen.alan.conno...@gmail.com> wrote: > > > > > >> I don't like this... but it fixes the test... unless anyone has a better > > >> proposal I will merge this to master > > >> > &

Re: maven-integration-testing git commit: [MNG-3599] Need to use --legacy-local-repository on newer maven versions

2017-01-11 Thread Robert Scholte
< stephen.alan.conno...@gmail.com> wrote: I don't like this... but it fixes the test... unless anyone has a better proposal I will merge this to master On 11 January 2017 at 13:57, wrote: Repository: maven-integration-testing Updated Branches: refs/heads/mng-3599 03c07e10b -> a2

Re: maven-integration-testing git commit: [MNG-3599] Need to use --legacy-local-repository on newer maven versions

2017-01-11 Thread Stephen Connolly
, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > I don't like this... but it fixes the test... unless anyone has a better > proposal I will merge this to master > > On 11 January 2017 at 13:57, wrote: > > Repository: maven-integration-testing > > > Up

Re: maven-integration-testing git commit: [MNG-3599] Need to use --legacy-local-repository on newer maven versions

2017-01-11 Thread Stephen Connolly
I don't like this... but it fixes the test... unless anyone has a better proposal I will merge this to master On 11 January 2017 at 13:57, wrote: > Repository: maven-integration-testing > Updated Branches: > refs/heads/mng-3599 03c07e10b -> a27d19f88 > > > [MNG-

[GitHub] maven-integration-testing pull request #15: [MNG-6084] Add test for JSR250 s...

2016-12-21 Thread dantran
Github user dantran closed the pull request at: https://github.com/apache/maven-integration-testing/pull/15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] maven-integration-testing issue #15: [MNG-6084] Add test for JSR250 support

2016-12-21 Thread dantran
Github user dantran commented on the issue: https://github.com/apache/maven-integration-testing/pull/15 already merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] maven-integration-testing issue #15: [MNG-6084] Add test for JSR250 support

2016-12-21 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/maven-integration-testing/pull/15 @dantran Can you squash? I will have a look and will merge soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] maven-integration-testing pull request #17: [MNG-6127] add integration test ...

2016-11-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven-integration-testing/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] maven-integration-testing pull request #17: [MNG-6127] add integration test ...

2016-11-26 Thread mkrizmanic
GitHub user mkrizmanic opened a pull request: https://github.com/apache/maven-integration-testing/pull/17 [MNG-6127] add integration test to suite Sorry, I haven't included the MNG-6127 integration test to the test suite in the previous PR: https://github.com/apache/maven/pu

[GitHub] maven-integration-testing pull request #16: [MNG-6127] Add plugin execution ...

2016-11-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven-integration-testing/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] maven-integration-testing pull request #16: [MNG-6127] Add plugin execution ...

2016-11-23 Thread mkrizmanic
GitHub user mkrizmanic opened a pull request: https://github.com/apache/maven-integration-testing/pull/16 [MNG-6127] Add plugin execution configuration interference test You can merge this pull request into a Git repository by running: $ git pull https://github.com/mkrizmanic

[GitHub] maven-integration-testing pull request #15: [MNG-6084] Add test for JSR250 s...

2016-11-20 Thread mfriedenhagen
Github user mfriedenhagen commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/15#discussion_r88809229 --- Diff: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6084Jsr250PluginTest.java --- @@ -0,0 +1,84 @@ +package

[GitHub] maven-integration-testing pull request #15: [MNG-6084] Add test for JSR250 s...

2016-11-20 Thread dantran
GitHub user dantran opened a pull request: https://github.com/apache/maven-integration-testing/pull/15 [MNG-6084] Add test for JSR250 support You can merge this pull request into a Git repository by running: $ git pull https://github.com/dantran/maven-integration-testing

Re: maven-integration-testing git commit: [MNG-6049] Add behavior to filter resolved version ranges of an artifact

2016-06-25 Thread Michael Osipov
where the proxy is available only. Too often some ITs try to access Central. But on ASF Jenkins, only direct central is available: see the build log https://builds.apache.org/view/M-R/view/Maven/job/core-integration-testing-maven-3-embedded/ws/core-integration-testing-trunk/core-it-suite/target

Re: maven-integration-testing git commit: [MNG-6049] Add behavior to filter resolved version ranges of an artifact

2016-06-25 Thread Hervé BOUTEMY
I suppose that you have in local a settings with a local repository manager that gives access to 3.4.0-SNAPSHOT Maven core artifacts But on ASF Jenkins, only direct central is available: see the build log https://builds.apache.org/view/M-R/view/Maven/job/core-integration-testing-maven-3-embedded

Re: maven-integration-testing git commit: [MNG-6049] Add behavior to filter resolved version ranges of an artifact

2016-06-25 Thread Michael Osipov
Jekins. Michael Le mercredi 22 juin 2016 20:00:00 micha...@apache.org a écrit : Repository: maven-integration-testing Updated Branches: refs/heads/master cfc6098c1 -> a2777f151 [MNG-6049] Add behavior to filter resolved version ranges of an artifact Appropriate IT for the issue. T

Re: maven-integration-testing git commit: [MNG-6049] Add behavior to filter resolved version ranges of an artifact

2016-06-25 Thread Hervé BOUTEMY
this IT fails on ASF Jenkins: it references artifacts that are not in the bootstrap process can you fix it, please? Regards, Hervé Le mercredi 22 juin 2016 20:00:00 micha...@apache.org a écrit : > Repository: maven-integration-testing > Updated Branches: > refs/heads/master

[GitHub] maven-integration-testing pull request #14: MNG-6049: Adds integration tests...

2016-06-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven-integration-testing/pull/14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] maven-integration-testing issue #14: MNG-6049: Adds integration tests for ve...

2016-06-21 Thread barthel
Github user barthel commented on the issue: https://github.com/apache/maven-integration-testing/pull/14 @michael-o Done. ITs passed. Merge conflict solved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] maven-integration-testing issue #14: MNG-6049: Adds integration tests for ve...

2016-06-21 Thread barthel
Github user barthel commented on the issue: https://github.com/apache/maven-integration-testing/pull/14 @michael-o Rename already done. ITs running locally right now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] maven-integration-testing issue #14: MNG-6049: Adds integration tests for ve...

2016-06-21 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/maven-integration-testing/pull/14 @barthel Can you also take care of the file names in the PR? `mng3092` to `mng-6049`. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] maven-integration-testing issue #14: MNG-3092: Adds integration tests for ve...

2016-06-21 Thread barthel
Github user barthel commented on the issue: https://github.com/apache/maven-integration-testing/pull/14 Relabelling commit from MNG-3092 to MNG-6049. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

2016-06-21 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/14#discussion_r67946906 --- Diff: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3092VersionRangeResultFilterExtensionTest.java --- @@ -0,0 +1,132

[GitHub] maven-integration-testing issue #14: MNG-3092: Adds integration tests for ve...

2016-06-21 Thread barthel
Github user barthel commented on the issue: https://github.com/apache/maven-integration-testing/pull/14 @michael-o Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

2016-06-21 Thread barthel
Github user barthel commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/14#discussion_r67945228 --- Diff: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3092VersionRangeResultFilterExtensionTest.java --- @@ -0,0 +1,132

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

2016-06-21 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/14#discussion_r67942011 --- Diff: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3092VersionRangeResultFilterExtensionTest.java --- @@ -0,0 +1,132

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

2016-06-21 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/14#discussion_r67941526 --- Diff: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3092VersionRangeResultFilterExtensionTest.java --- @@ -0,0 +1,132

[GitHub] maven-integration-testing issue #14: MNG-3092: Adds integration tests for ve...

2016-06-20 Thread barthel
Github user barthel commented on the issue: https://github.com/apache/maven-integration-testing/pull/14 @michael-o Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

2016-06-20 Thread barthel
Github user barthel commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/14#discussion_r67776474 --- Diff: core-it-suite/src/test/resources/mng-3092/filter-extension/pom.xml --- @@ -0,0 +1,73 @@ + + + + +http

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

2016-06-20 Thread barthel
Github user barthel commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/14#discussion_r67776182 --- Diff: core-it-suite/src/test/resources/mng-3092/repo/org/apache/maven/its/mng3092/a/2.0-SNAPSHOT/a-2.0-20100408.111215-1.pom

[GitHub] maven-integration-testing issue #14: MNG-3092: Adds integration tests for ve...

2016-06-20 Thread barthel
Github user barthel commented on the issue: https://github.com/apache/maven-integration-testing/pull/14 @michael-o Missing JARs added and changes included. Integration tests run successfully: ``` […] --- T

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

2016-06-15 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/14#discussion_r67233942 --- Diff: core-it-suite/src/test/resources/mng-3092/repo/org/apache/maven/its/mng3092/a/2.0-SNAPSHOT/a-2.0-20100408.111215-1.pom

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

2016-06-15 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/14#discussion_r67233825 --- Diff: core-it-suite/src/test/resources/mng-3092/filter-extension/src/main/java/org/apache/maven/its/extensions

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

2016-06-15 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/14#discussion_r67233789 --- Diff: core-it-suite/src/test/resources/mng-3092/filter-extension/src/main/java/org/apache/maven/its/extensions

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

2016-06-15 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/14#discussion_r67233439 --- Diff: core-it-suite/src/test/resources/mng-3092/filter-extension/pom.xml --- @@ -0,0 +1,73 @@ + + + + +http

  1   2   3   4   >