Re: Help with maven-jmod-plugin issues

2019-01-17 Thread Robert Scholte
I've added review comments for both PRs. I would expect a better solution for MJMOD-8, I can help with that. The rest is mostly a matter of cleaning up: removing things from the pom that don't add anything to the IT and write Groovy as Groovy ;) Robert On Thu, 17 Jan 2019 16:02:38 +0100, And

Help with maven-jmod-plugin issues

2019-01-17 Thread Andre Tadeu de Carvalho
Hello people! Thank you all for being supportive. Could someone help me reviewing the following PRs? MJMOD-8: https://github.com/apache/maven-jmod-plugin/pull/2 MJMOD-20: https://github.com/apache/maven-jmod-plugin/pull/1 I could use these fixes successfully to build the following demos: - h