Re: Halve the logging

Ok, thanks for the clarification. As I mentioned on the PR, it is merely a "technical demo" to see how it would look, nothing more. The PR is intentionally marked as "experiment" and left as draft, is not meant to be merged or anything like that. T On Mon, Feb 20, 2023 at 2:14 PM Romain Manni-Buc

Re: Halve the logging

There are two issues which can be technically solved by using a logger per transfer listener callback method (which will keep it stateless): * It uses System.out so if you use a logger override of the slf4j binding which does not use System.out but the fd directly then log lines and transfer lines

Re: Halve the logging

Resolver TransferListener implementations are stateless (or ideally should be), everything they need is in event. Unsure what "interleaving" issue you mention, as now listener emits two (mutually exclusive) events only: - transfer succeeded - transfer failed T On Mon, Feb 20, 2023 at 1:55 PM Roma

Re: Halve the logging

Hi, Doesn't it move the issue to the "next event"? Guess it should be fully customizable or not at all. Also it keeps the logging interleaving issue - this is why the logger solution sounded neat to me. Romain Manni-Bucau @rmannibucau | Blog

Re: Halve the logging

Created this PR as "experiment": https://github.com/apache/maven/pull/1003 It will produce "nearly" the upcoming Maven 3.9.1 and has a dirty hack: -Dmaven.resolver.transfer.logging=full(as before)|half(the new default) As expected, one IT fails that asserts the "DownloadING" log line that this Pr

Re: Halve the logging

Maybe we should just move the console listener to a logger usage with this pattern $classname.event, this way configuring the loggers enables any customization and we dont get fishy console outputs too depending the slf4j binding. Le dim. 19 févr. 2023 à 20:57, Benjamin Marwell a écrit : > Sadly

Re: Halve the logging

Sadly, --ntp also disables upload progress and ANY information associated with this. Maybe it would be beneficial to have an option for that. On Sun, 19 Feb 2023, 18:26 Michael Osipov, wrote: > Am 2023-02-19 um 18:17 schrieb Romain Manni-Bucau: > > Not sure we can find an agreement on this to

Re: Halve the logging

Am 2023-02-19 um 18:17 schrieb Romain Manni-Bucau: Not sure we can find an agreement on this topic, both opinions are very valid and depends the persona/case so let's keep our default while it is customizable easily it is fine IMHO. Good point, I could imagine that one could introduce --transfe

Re: Halve the logging

Not sure we can find an agreement on this topic, both opinions are very valid and depends the persona/case so let's keep our default while it is customizable easily it is fine IMHO. Le dim. 19 févr. 2023 à 17:06, Elliotte Rusty Harold a écrit : > On Sun, Feb 19, 2023 at 2:02 PM Michael Osipov >

Re: Halve the logging

On Sun, Feb 19, 2023 at 2:02 PM Michael Osipov wrote: > Use -B or --no-transfer-progress. Cutting in half does not really work > unless you don't want to say that download has started and finished *or* > you provide a custom status listener. Consider that download starts, but > then fails. No way

Re: Halve the logging

Yeah, this is tricky IMO because I would rather know that something has started and is taking a long time rather than staring at an apparently hung console. I think it is fine as it is now and --no-transfer-progress is helpful and also -ntp work the same? AFK. Gary Gary On Sun, Feb 19, 2023, 09

Re: Halve the logging

This is resolver, but the logging listener is provided by maven. I'd +1 for this, as message can be "Downloaded" or "Failed to download..." and imo line for starting of download is chatty, really not needed. T On Sun, Feb 19, 2023, 14:59 Elliotte Rusty Harold wrote: > Typical log message i

Re: Halve the logging

Am 2023-02-19 um 14:58 schrieb Elliotte Rusty Harold: Typical log message in build: Downloading from central: https://repo.maven.apache.org/maven2/commons-lang/commons-lang/2.4/commons-lang-2.4.pom Downloaded from central: https://repo.maven.apache.org/maven2/commons-lang/commons-lang/2.4/common

Halve the logging

Typical log message in build: Downloading from central: https://repo.maven.apache.org/maven2/commons-lang/commons-lang/2.4/commons-lang-2.4.pom Downloaded from central: https://repo.maven.apache.org/maven2/commons-lang/commons-lang/2.4/commons-lang-2.4.pom (14 kB at 776 kB/s) Which plugin does th