Re: Gratuitous refactorings

2023-07-06 Thread Slawomir Jaranowski
+1 czw., 6 lip 2023 o 13:56 Elliotte Rusty Harold napisał(a): > It hadn't occurred to me that it might be a bot. Given that, I'm going > to go ahead and close these when I see them. If an actual human being > objects, it can be reopened. Thanks. > > On Thu, Jul 6, 2023 at 12:10 AM Henning Schmie

Re: Gratuitous refactorings

2023-07-06 Thread Elliotte Rusty Harold
It hadn't occurred to me that it might be a bot. Given that, I'm going to go ahead and close these when I see them. If an actual human being objects, it can be reopened. Thanks. On Thu, Jul 6, 2023 at 12:10 AM Henning Schmiedehausen wrote: > > This is most likely a bot "warming up" by contributin

Re: Gratuitous refactorings

2023-07-05 Thread Henning Schmiedehausen
This is most likely a bot "warming up" by contributing to some well-known (high-reputation) repository. Merging those will allow them to build a reputation for things like "sell stars for github repos". - https://the-guild.dev/blog/judging-open-source-by-github-stars - https://dagster.io/blog/fake

Re: Gratuitous refactorings

2023-07-05 Thread Jeremy Landis
roid<https://aka.ms/AAb9ysg> From: Elliotte Rusty Harold Sent: Wednesday, July 5, 2023 9:04:20 AM To: Maven Developers List Subject: Gratuitous refactorings Lately I've noticed a few random PRs from first time contributors that use some automated refacto

Gratuitous refactorings

2023-07-05 Thread Elliotte Rusty Harold
Lately I've noticed a few random PRs from first time contributors that use some automated refactoring tool on our code for no obvious reason. Here's an example: https://github.com/apache/maven-assembly-plugin/pull/131 These refactorings don't seem helpful and don't IMO improve the code in any way