Re: Github pull requests for Maven Core

2014-05-31 Thread Jason van Zyl
On May 31, 2014, at 11:05 AM, Baptiste Mathus wrote: > Hi, > > What do you mean by "squashing" commits? > That a pull request should consist of a single, coherent commit. So during the development of the pull request it may consist of several commits but in its final form it needs to be a si

Re: Github pull requests for Maven Core

2014-05-31 Thread Baptiste Mathus
Hi, What do you mean by "squashing" commits? Do you mean: * intermediate crappy/local commits that were incorrectly pushed as-is without having been "rebased interactively" to provide a clean and understandable history (see the link provided by Hervé as an example) * or that any PR should be squ

Re: Github pull requests for Maven Core

2014-05-31 Thread Hervé BOUTEMY
http://java.dzone.com/articles/squashing-github-pull-requests ? Regards, Hervé Le vendredi 30 mai 2014 09:57:18 Jason van Zyl a écrit : > I'm happy to look at pull requests but in the future can anyone making a > pull request please squash your commits before making the pull request. > > Eventu

Re: Github pull requests for Maven Core

2014-05-30 Thread Michael Osipov
Am 2014-05-30 15:57, schrieb Jason van Zyl: I'm happy to look at pull requests but in the future can anyone making a pull request please squash your commits before making the pull request. Eventually I want to use Gerrit and create a mechanism where pull requests can be tested against the ITs

Re: Github pull requests for Maven Core

2014-05-30 Thread Jason van Zyl
On May 30, 2014, at 10:42 AM, Stephen Connolly wrote: > On 30 May 2014 14:57, Jason van Zyl wrote: > >> I'm happy to look at pull requests but in the future can anyone making a >> pull request please squash your commits before making the pull request. >> >> Eventually I want to use Gerrit an

Re: Github pull requests for Maven Core

2014-05-30 Thread Stephen Connolly
On 30 May 2014 14:57, Jason van Zyl wrote: > I'm happy to look at pull requests but in the future can anyone making a > pull request please squash your commits before making the pull request. > > Eventually I want to use Gerrit and create a mechanism where pull requests > can be tested against th

Re: Github pull requests for Maven Core

2014-05-30 Thread Michael-O
Am 2014-05-30 15:57, schrieb Jason van Zyl: I'm happy to look at pull requests but in the future can anyone making a pull request please squash your commits before making the pull request. Eventually I want to use Gerrit and create a mechanism where pull requests can be tested against the ITs

Github pull requests for Maven Core

2014-05-30 Thread Jason van Zyl
I'm happy to look at pull requests but in the future can anyone making a pull request please squash your commits before making the pull request. Eventually I want to use Gerrit and create a mechanism where pull requests can be tested against the ITs to make it easier for contributors to know the