Re: MNG-3004 review - (Experimental) multithreading support

2009-11-16 Thread Jason van Zyl
I'm fried at the moment, but I'll take a look tomorrow night and try to comment on Wednesday. On 2009-11-16, at 11:10 PM, Kristian Rosenvold wrote: I have reviewed the changeset made in the MNG-3004 branch. I don't know if the community will accept my review, but I'll make a stab at it anyw

MNG-3004 review - (Experimental) multithreading support

2009-11-16 Thread Kristian Rosenvold
I have reviewed the changeset made in the MNG-3004 branch. I don't know if the community will accept my review, but I'll make a stab at it anyway. I think the implementation overall looks really good. My only real question is about the session cloning and session merging. What's the deal with tha

Re: Proposal after-the-fact: Experimental multithreading support

2009-11-14 Thread Brian Fox
discussed at ApacheCon. On Sat, Nov 14, 2009 at 2:21 PM, Dan Fabulich wrote: > This is now an official proposal here: > > http://cwiki.apache.org/confluence/display/MAVEN/Experimental+Multithreading+Support > > (I didn't have karma to edit this page until a few minutes ago; you mig

Re: Proposal after-the-fact: Experimental multithreading support

2009-11-14 Thread Dan Fabulich
This is now an official proposal here: http://cwiki.apache.org/confluence/display/MAVEN/Experimental+Multithreading+Support (I didn't have karma to edit this page until a few minutes ago; you might need to request karma as well, especially since this the first proposal in this new loc

Re: m2eclipse was: Proposal after-the-fact: Experimental multithreading support

2009-11-11 Thread Igor Fedorenko
Unfortunately m2e will have to wait until alpha-4 due to PLX-444, assuming alpha-3 is not respun that is. Do not break trunk just yet ;-) -- Regards, Igor Dan Fabulich wrote: Brian Fox wrote: Does that mean that changes that we make in the Apache trunk can automatically break people's Eclipse

Re: m2eclipse was: Proposal after-the-fact: Experimental multithreading support

2009-11-10 Thread Dan Fabulich
Brian Fox wrote: Does that mean that changes that we make in the Apache trunk can automatically break people's Eclipse builds out in the wild, even without an official release? No. Igor has to bundle them into M2e before it's directly used, so it could break the next time we update. It's a ps

Re: m2eclipse was: Proposal after-the-fact: Experimental multithreading support

2009-11-10 Thread Brian Fox
On Tue, Nov 10, 2009 at 3:21 PM, Dan Fabulich wrote: > Jason van Zyl wrote: > >> The trunk is now critical for M2Eclipse and anyone else who is embedding >> and new features just aren't going in without adequate ITs. > > m2eclipse depends on the Maven 3.0-SNAPSHOT trunk? > Kinda > Does that mean

Multi-machine support was: Proposal after-the-fact: Experimental multithreading support

2009-11-10 Thread Dan Fabulich
Jorg Heymans wrote: Would the multithreading feature make it easier or harder to implement something like [1], ie distribute the different modules of a reactor build across different machines ? Or is it completely unrelated you think ? No harder, but not much easier. With that said, I do ha

Re: Proposal after-the-fact: Experimental multithreading support

2009-11-10 Thread Jorg Heymans
Hi Dan, Would the multithreading feature make it easier or harder to implement something like [1], ie distribute the different modules of a reactor build across different machines ? Or is it completely unrelated you think ? Thanks, Jorg Heymans [1] http://n4.nabble.com/New-plugin-to-distribute-

m2eclipse was: Proposal after-the-fact: Experimental multithreading support

2009-11-10 Thread Dan Fabulich
Jason van Zyl wrote: The trunk is now critical for M2Eclipse and anyone else who is embedding and new features just aren't going in without adequate ITs. m2eclipse depends on the Maven 3.0-SNAPSHOT trunk? Does that mean that changes that we make in the Apache trunk can automatically break pe

Re: Proposal after-the-fact: Experimental multithreading support

2009-11-10 Thread Dan Fabulich
Jason van Zyl wrote: It's not going in that fast. Fair enough; that seems to be the consensus. Sorry, but passing all the existing ITs is the first step and then there is ITs for the feature you multi-threading feature itself. I've got a couple of ITs for MNG-3004 parallel projects on my m

Re: Proposal after-the-fact: Experimental multithreading support

2009-11-10 Thread Jason van Zyl
On 2009-11-10, at 4:02 AM, Dan Fabulich wrote: On Friday I was playing cowboy with my experimental thread support, but here's a more formal proposal around parallel project support in Maven 3.0. OUTSTANDING ISSUES In my earlier revision 833566, I attempted to fix MNG-3004: "Allow build

Re: Proposal after-the-fact: Experimental multithreading support

2009-11-09 Thread Wendy Smoak
On Mon, Nov 9, 2009 at 8:02 PM, Dan Fabulich wrote: > I attempted to check in the code in time for 3.0-alpha-3 a few days ago. > That code was rolled back over the weekend and now lives in the MNG-3004 > branch, because it broke integration tests.  All integration tests now pass > on my machine wi

Proposal after-the-fact: Experimental multithreading support

2009-11-09 Thread Dan Fabulich
On Friday I was playing cowboy with my experimental thread support, but here's a more formal proposal around parallel project support in Maven 3.0. OUTSTANDING ISSUES In my earlier revision 833566, I attempted to fix MNG-3004: "Allow build lifecycle to execute projects in parallel" http://j

Re: Experimental multithreading support

2009-11-09 Thread Jason van Zyl
Dan, Also curious if you just did this because it was on trunk, or you find working with trunk code easier. On 2009-11-06, at 10:49 PM, Dan Fabulich wrote: In revision 833566, I checked in experimental support for multithreaded builds in Maven 3.0 trunk. This works on my machine: "mvn

Re: Experimental multithreading support

2009-11-09 Thread Jason van Zyl
I think Benjamin already commented on this, but you need to write to keep this on a branch and write a lot of ITs and make sure it all works on the grid before putting this in trunk. It is super, super stable at the moment and we rely on trunk for everything in M2Eclipse so you kill us toss