Re: Edge case in artifact filtering algorithm

2016-06-18 Thread Robert Scholte
Hi, http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html patterns as described on this page look okay to me. So maybe it is not that hard to switch Robert On Wed, 15 Jun 2016 19:59:26 +0200, Robert Scholte wrote: On Wed, 15 Jun 2016 00:02:47 +0200, Michael Osipov wrote:

Re: Edge case in artifact filtering algorithm

2016-06-15 Thread Robert Scholte
On Wed, 15 Jun 2016 00:02:47 +0200, Michael Osipov wrote: Am 2016-06-14 um 23:45 schrieb Robert Scholte: too much fun to fix this. http://svn.apache.org/viewvc?rev=1748472&view=rev should do the trick. Still some doc updates required Good! We still must take great care because throughout

Re: Edge case in artifact filtering algorithm

2016-06-14 Thread Michael Osipov
Am 2016-06-14 um 23:45 schrieb Robert Scholte: too much fun to fix this. http://svn.apache.org/viewvc?rev=1748472&view=rev should do the trick. Still some doc updates required Good! We still must take great care because throughout several places in Aether and Maven coords format with colon m

Re: Edge case in artifact filtering algorithm

2016-06-14 Thread Robert Scholte
too much fun to fix this. http://svn.apache.org/viewvc?rev=1748472&view=rev should do the trick. Still some doc updates required Robert On Tue, 14 Jun 2016 22:10:30 +0200, Robert Scholte wrote: On Tue, 14 Jun 2016 18:59:50 +0200, Michael Osipov wrote: Am 2016-06-14 um 17:34 schrieb

Re: Edge case in artifact filtering algorithm

2016-06-14 Thread Robert Scholte
On Tue, 14 Jun 2016 18:59:50 +0200, Michael Osipov wrote: Am 2016-06-14 um 17:34 schrieb Robert Scholte: I think we're making it ourself very hard if we keep supporting :jar. I would have read it as any groupId + artifactId='jar'. Instead with 3.0 we should switch to the patterns as defined

Re: Edge case in artifact filtering algorithm

2016-06-14 Thread Michael Osipov
Am 2016-06-14 um 17:34 schrieb Robert Scholte: I think we're making it ourself very hard if we keep supporting :jar. I would have read it as any groupId + artifactId='jar'. Instead with 3.0 we should switch to the patterns as defined by Aether[1]; no need to maintain assembly specific patterns, u

Re: Edge case in artifact filtering algorithm

2016-06-14 Thread Robert Scholte
I think we're making it ourself very hard if we keep supporting :jar. I would have read it as any groupId + artifactId='jar'. Instead with 3.0 we should switch to the patterns as defined by Aether[1]; no need to maintain assembly specific patterns, use them as is with Aether. WDYT? Robert [1]

Edge case in artifact filtering algorithm

2016-06-13 Thread Michael Osipov
Hi folks, I am currently investigating https://issues.apache.org/jira/browse/MASSEMBLY-809 After an analysis, I came to the conclusion that Maven Common Artifact Filters apply include filters telescopic for non-wildcard patterns. Consider this in the assembly.xml [1]: test.project:pro