Re: Compiler bug: Issues with JPMS module version

2024-03-05 Thread Sam Gammon
Christian Stein Sent: Tuesday, March 5, 2024 11:28:27 PM To: dev@maven.apache.org Subject: Re: Compiler bug: Issues with JPMS module version On 2024/03/06 07:15:11 Sam Gammon wrote: > I hadn't noticed that test, thank you. That's very helpful, maybe, then, > Guava's string

Re: Compiler bug: Issues with JPMS module version

2024-03-05 Thread Sam Gammon
, 2024 11:28:27 PM To: dev@maven.apache.org Subject: Re: Compiler bug: Issues with JPMS module version On 2024/03/06 07:15:11 Sam Gammon wrote: > I hadn't noticed that test, thank you. That's very helpful, maybe, then, > Guava's string HEAD-jar-SNAPSHOT​ can simply be a

Re: Compiler bug: Issues with JPMS module version

2024-03-05 Thread Christian Stein
On 2024/03/06 07:15:11 Sam Gammon wrote: > I hadn't noticed that test, thank you. That's very helpful, maybe, then, > Guava's string HEAD-jar-SNAPSHOT​ can simply be a change to > 1.0-HEAD-jar-SNAPSHOT​. That feels like the best solution to me: you opt-in to be a Java module, you also provid

Re: Compiler bug: Issues with JPMS module version

2024-03-05 Thread Sam Gammon
e.org Subject: Re: Compiler bug: Issues with JPMS module version Hey Christian, I hadn't noticed that test, thank you. That's very helpful, maybe, then, Guava's string HEAD-jar-SNAPSHOT​ can simply be a change to 1.0-HEAD-jar-SNAPSHOT​. Still, though, I can't help but wond

Re: Compiler bug: Issues with JPMS module version

2024-03-05 Thread Sam Gammon
dback and thank you for your help on this. Sam From: Christian Stein Sent: Tuesday, March 5, 2024 11:08 PM To: dev@maven.apache.org Subject: Re: Compiler bug: Issues with JPMS module version The commit you linked contains a test for "1.0-SNAPSHOT", a v

Re: Compiler bug: Issues with JPMS module version

2024-03-05 Thread Christian Stein
The commit you linked contains a test for "1.0-SNAPSHOT", a valid version string according to Java's module descriptor version schema as defined here: https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/lang/module/ModuleDescriptor.Version.html "HEAD-SNAPSHOT" fails due to it does

Compiler bug: Issues with JPMS module version

2024-03-05 Thread Sam Gammon
Hello Maven devs, Longtime user, first time mailing list subscriber. I was attempting to convert some Java libraries to JPMS modules today, and ran into a compiler issue with Maven version 3.8.1 and above; this deals with the --module-version​ flag. Maven sets the module version to the project