Re: Changing MavenProjectHelper

2012-11-25 Thread Stuart McCulloch
On 25 Nov 2012, at 01:04, Hervé BOUTEMY wrote: > Since this is a plexus component implemented in Maven core [1], I don't see > any problem with adding a new Method: if the method exists in interface, it > exists in implementation. > We would have a problem if it was an interface that is expecte

Re: Changing MavenProjectHelper

2012-11-24 Thread Hervé BOUTEMY
Since this is a plexus component implemented in Maven core [1], I don't see any problem with adding a new Method: if the method exists in interface, it exists in implementation. We would have a problem if it was an interface that is expected to be implemented by external code So I don't see any

Re: Changing MavenProjectHelper

2012-11-24 Thread Jason van Zyl
Please do not change existing signatures. If it's public, you simply never know who's using it. On Nov 24, 2012, at 2:00 PM, Benson Margulies wrote: > I am inclined to also fix a missing exception from one of the existing > methods; comments indicate that someone avoided adding it due to > comp

Re: Changing MavenProjectHelper

2012-11-24 Thread Benson Margulies
I am inclined to also fix a missing exception from one of the existing methods; comments indicate that someone avoided adding it due to compat issues at the time. On Sat, Nov 24, 2012 at 4:58 PM, Olivier Lamy wrote: > 2012/11/24 Benson Margulies : >> MavenProjectHelper lives in the core, and I'd

Re: Changing MavenProjectHelper

2012-11-24 Thread Olivier Lamy
2012/11/24 Benson Margulies : > MavenProjectHelper lives in the core, and I'd like to add another > method. What's the procedure from a compatibility standpoint? Do I > define a MavenProjectHelper2 that inherits from it so that existing > plugins can continue to have refs to the current interface?

Changing MavenProjectHelper

2012-11-24 Thread Benson Margulies
MavenProjectHelper lives in the core, and I'd like to add another method. What's the procedure from a compatibility standpoint? Do I define a MavenProjectHelper2 that inherits from it so that existing plugins can continue to have refs to the current interface? -