Re: Analysis of apache-maven-3.2.3's dependency on JDK-Internal APIs

2014-09-15 Thread Rory O'Donnell Oracle, Dublin Ireland
Thanks for the feedback Guys, if you have a contact at Guava that would be great ? Rgds,Rory On 15/09/2014 12:51, Stuart McCulloch wrote: Just to clarify, Sisu has _never_ used any Guava APIs directly, the use of Guava comes from its use of Guice. In Guice 3.0 Guava was shaded in under an in

Re: Analysis of apache-maven-3.2.3's dependency on JDK-Internal APIs

2014-09-15 Thread Stuart McCulloch
Just to clarify, Sisu has _never_ used any Guava APIs directly, the use of Guava comes from its use of Guice. In Guice 3.0 Guava was shaded in under an internal package, since then Guava is now an external dependency: https://github.com/google/guice/commit/3236b100a95b739577dfcd117c246

Re: Analysis of apache-maven-3.2.3's dependency on JDK-Internal APIs

2014-09-15 Thread Igor Fedorenko
I was not suggesting changing guava, which I agree, is not our problem. I was suggesting using more recent version of guava in maven, which only we can do. -- Regards, Igor On 2014-09-15, 7:42, Kristian Rosenvold wrote: Guava is a general purpose library that contains quite a bunch of stuff. It

Re: Analysis of apache-maven-3.2.3's dependency on JDK-Internal APIs

2014-09-15 Thread Kristian Rosenvold
Guava is a general purpose library that contains quite a bunch of stuff. It seems like the report we're looking at is simply a byte code scan of our "lib" folder looking for undesirables. sun.misc.Unsafe is cookie jar of cool stuff that certain features of guava use. I doubt that /we/ actually use

Re: Analysis of apache-maven-3.2.3's dependency on JDK-Internal APIs

2014-09-15 Thread Igor Fedorenko
We can move to the newer version of guava. This was one of the reasons I updated to the latest sisu, I was told it did not depend on any internal guava apis any more. Of course, somebody will have to check what guava version is compatible with JDK 9 before we upgrade. -- Regards, Igor On 2014-09

Re: Analysis of apache-maven-3.2.3's dependency on JDK-Internal APIs

2014-09-15 Thread Kristian Rosenvold
So if I read your report correctly, our code uses guava, which contains references to sun.misc.Unsafe. Actually it's sisu that uses guava, not maven core itself. Not too much we can do about that, other than consider throwing guava out of sisu. As long as we're on a sub-1.8 minimum language le

Re: Analysis of apache-maven-3.2.3's dependency on JDK-Internal APIs

2014-09-15 Thread Rory O'Donnell Oracle, Dublin Ireland
Hi Stephen, One more time, hope this is ok. Rgds,Rory JDK Internal API Usage Report for apache-maven-3.2.3 The OpenJDK Quality Outreach campaign has run a compatibility report to identify usage of JDK-internal APIs. Usage of these JDK-internal APIs could pose compatibility issues, as the J

Re: Analysis of apache-maven-3.2.3's dependency on JDK-Internal APIs

2014-09-15 Thread Rory O'Donnell Oracle, Dublin Ireland
Ok, here is the text. Rgds,Rory JDK Internal API Usage Report for apache-maven-3.2.3 The OpenJDK Quality Outreach campaign has run a compatibility report to identify usage of JDK-internal APIs. Usage of these JDK-internal APIs could pose compatibility issues, as the Java team explained in 19

Re: Analysis of apache-maven-3.2.3's dependency on JDK-Internal APIs

2014-09-15 Thread Stephen Connolly
I think the mailing list stripped the attachment On Monday, 15 September 2014, Rory O'Donnell Oracle, Dublin Ireland < rory.odonn...@oracle.com> wrote: > Hi Robert,Kristian, > > As part of the preparations for JDK 9, Oracle's engineers have been > analyzing open source projects like yours to unde

Analysis of apache-maven-3.2.3's dependency on JDK-Internal APIs

2014-09-15 Thread Rory O'Donnell Oracle, Dublin Ireland
Hi Robert,Kristian, As part of the preparations for JDK 9, Oracle's engineers have been analyzing open source projects like yours to understand usage. One area of concern involves identifying compatibility problems, such as reliance on JDK-internal APIs. Our engineers have already prepared gu