Re: Adding contributors to pom.xml

2019-05-28 Thread Tibor Digana
We should ask the contributor because some German companies do not allow you to work in OSS unless you have got an internal confirmation from commercial management. My last company had this rule; does not matter if the prodution area is the same with OSS or not. In my case we were in totally differ

Re: Adding contributors to pom.xml

2019-05-28 Thread Robert Scholte
> It was very exciting as a first time contribution for me. This would indeed be a good reason to do so.  With GDPR in mind it is probably better to ask the contributor to add its own name to the pom file. Robert On 28-5-2019 22:24:17, Enrico Olivelli wrote: Hi, Is there any rule to add a refer

Re: Adding contributors to pom.xml

2019-05-28 Thread Tibor Digana
Not sure there is a real limitation to do it. We can at least see new candidates for committers from the group of contributors. The contributors like it of course, and why not, their work is valuable! On Tue, May 28, 2019 at 10:24 PM Enrico Olivelli wrote: > Hi, > Is there any rule to add a refe

Re: Adding contributors to pom.xml

2019-05-28 Thread Michael Osipov
Am 2019-05-28 um 22:17 schrieb Enrico Olivelli: Hi, Is there any rule to add a reference to a contributor in the contributors section of the pom.xml of a plugin. For instance today I have merged a PR from a new time contributor to the maven jdeps plugin. Should I add his email/reference to the p

Adding contributors to pom.xml

2019-05-28 Thread Enrico Olivelli
Hi, Is there any rule to add a reference to a contributor in the contributors section of the pom.xml of a plugin. For instance today I have merged a PR from a new time contributor to the maven jdeps plugin. Should I add his email/reference to the pom of that plugin? I remember that the first time