Re: AbstractCompilerMojo and @component

2008-03-24 Thread Benson Margulies
Jason, It seems to me, and I'm likely to be confused, that what we have here is a collision of maven and plexus. The maven-compiler-plugin is a thin wrapper on the plexus compiler system. The plexus compiler system uses the plexus component model to add new compilers. So, adding a new compiler in

Re: AbstractCompilerMojo and @component

2008-03-24 Thread Jason van Zyl
Where the source of the wiring information comes from and how it's used in Plexus is completely decoupled. What you see for Plexus components does not necessarily hold true for Mojos because the intent is to allow the client, in this case the Mojo system, to define its own APIs and wiring i

Re: AbstractCompilerMojo and @component

2008-03-24 Thread Benson Margulies
I will JIRA a request to make the AbstractCompilerMojo into a component. On Mon, Mar 24, 2008 at 10:12 AM, Stuart McCulloch < [EMAIL PROTECTED]> wrote: > On 24/03/2008, Benson Margulies <[EMAIL PROTECTED]> wrote: > > > > Ah. So one might imagine someone refactoring things so that all the > > inje

Re: AbstractCompilerMojo and @component

2008-03-24 Thread Stuart McCulloch
On 24/03/2008, Benson Margulies <[EMAIL PROTECTED]> wrote: > > Ah. So one might imagine someone refactoring things so that all the > injected > fields of AbstractCompilerMojo were protected, so that an extending class > in > another plugin could have parallel annotations. > while that might look o

Re: AbstractCompilerMojo and @component

2008-03-24 Thread Benson Margulies
Ah. So one might imagine someone refactoring things so that all the injected fields of AbstractCompilerMojo were protected, so that an extending class in another plugin could have parallel annotations.

Re: AbstractCompilerMojo and @component

2008-03-23 Thread Stuart McCulloch
On 24/03/2008, Benson Margulies <[EMAIL PROTECTED]> wrote: > > I defined a new Mojo by extending AbstractCompilerMojo from the > maven-compiler-plugin. > > It doesn't work, because the @component annotation for the compiler > manager > on AbstractCompilerMojo doesn't happen. > > Obviously, it works

AbstractCompilerMojo and @component

2008-03-23 Thread Benson Margulies
I defined a new Mojo by extending AbstractCompilerMojo from the maven-compiler-plugin. It doesn't work, because the @component annotation for the compiler manager on AbstractCompilerMojo doesn't happen. Obviously, it works in the CompilerMojo. As an experiment, I made a copy of AbstractCompilerM