Re: 1.0 branch and dist plugin

2004-07-05 Thread Brett Porter
Fixed in CVS. and now load the plugin if necessary. I'll add a test on the way in for :set and then post some more info - looks like we can ditch those stupid dependency handles though. The fix is something like the last straw the PluginManager camel's back can take, but it's still holding :) P

Re: 1.0 branch and dist plugin

2004-07-04 Thread Brett Porter
Bizarre... I'll take a look tonight. Quoting Dion Gillard <[EMAIL PROTECTED]>: > On Mon, 5 Jul 2004 14:54:38 +1000, Dion Gillard <[EMAIL PROTECTED]> > wrote: > > I'll try adding a prereq of dist:build-setup > > Same sort of failure: > > Tag library requested that is not present: 'dist' in plugi

Re: 1.0 branch and dist plugin

2004-07-04 Thread Dion Gillard
On Mon, 5 Jul 2004 14:54:38 +1000, Dion Gillard <[EMAIL PROTECTED]> wrote: > I'll try adding a prereq of dist:build-setup Same sort of failure: Tag library requested that is not present: 'dist' in plugin: 'maven-nsis-plugin-1.1-SNAPSHOT' INTERNAL ERROR Reference made to goal 'dist:build-setup' wh

Re: 1.0 branch and dist plugin

2004-07-04 Thread Dion Gillard
On Mon, 5 Jul 2004 11:18:26 +1000, Brett Porter <[EMAIL PROTECTED]> wrote: > Quoting Dion Gillard <[EMAIL PROTECTED]>: > > > I'm having problems with maven:get in the latest builds of the 1.0 branch. > > > > In the NSIS plugin I have this: > > > > > plugin="maven-dist-plugin" property="maven.

Re: 1.0 branch and dist plugin

2004-07-04 Thread Brett Porter
Quoting Dion Gillard <[EMAIL PROTECTED]>: > Given Jason's comments last week, I'm trying not to put preGoals in plugins. Yep, that's a good thing. I probably meant prereq though - if there is a goal (like the :init stuff) you can prereq on that'll work (eg war:load was used for this), but the tag

Re: 1.0 branch and dist plugin

2004-07-04 Thread Dion Gillard
On Mon, 5 Jul 2004 11:18:26 +1000, Brett Porter <[EMAIL PROTECTED]> wrote: > Quoting Dion Gillard <[EMAIL PROTECTED]>: > > This stuff has always been flaky. It depends on the plugin already being loaded. > The "documented" fashion of doing so is a taglib dependency handle (see > eclipse's use of

Re: 1.0 branch and dist plugin

2004-07-04 Thread Brett Porter
Quoting Dion Gillard <[EMAIL PROTECTED]>: > I'm having problems with maven:get in the latest builds of the 1.0 branch. > > In the NSIS plugin I have this: > > plugin="maven-dist-plugin" property="maven.dist.bin.assembly.dir"/> > > And it comes back blank. This stuff has always been flaky.

1.0 branch and dist plugin

2004-07-04 Thread Dion Gillard
I'm having problems with maven:get in the latest builds of the 1.0 branch. In the NSIS plugin I have this: And it comes back blank. Thinking it was the variable, I tried: Still no luck. Also, running maven dist by itself works ok, but putting it as a pre-req for a plugin goal fails m