Re: [vote] Create a maven-sources-plugin for m1

2006-01-06 Thread Stephane Nicoll
OK. But would it be possible to have some common place for this piece of code. It will be used by the eclipse and IDEA plugin anyway. WDYT? Stéphane On 1/6/06, Milos Kleint <[EMAIL PROTECTED]> wrote: > > actually this is for maven1 integration. I don't use the embedder there > and > I don't plan

Re: [vote] Create a maven-sources-plugin for m1

2006-01-05 Thread Milos Kleint
actually this is for maven1 integration. I don't use the embedder there and I don't plan to actually, using plain commons-httpclient there.. in m2 impl, the embedder is used to download the sources.. Milos On 1/5/06, Jason van Zyl <[EMAIL PROTECTED]> wrote: > > Brett Porter wrote: > > Just one

Re: [vote] Create a maven-sources-plugin for m1

2006-01-05 Thread Fabrizio Giustina
You can look at EclipsePlugin and EclipseUtils in the m2 eclipse plugin: http://svn.apache.org/viewcvs.cgi/maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/ Actually in m2 the code to download a source artifact is simple, using artifact resolver: Artifact re

Re: [vote] Create a maven-sources-plugin for m1

2006-01-05 Thread Brett Porter
Sorry, I was referring to the mojos. Jason van Zyl wrote: > Brett Porter wrote: >> Just one comment if you start to implement download as part of idea:idea >> or eclipse:eclipse - please make sure it is consistent with the m2 >> implementation. >> >> Stephane Nicoll wrote: >>> dowload is interesti

Re: [vote] Create a maven-sources-plugin for m1

2006-01-05 Thread Stephane Nicoll
On 1/5/06, Jason van Zyl <[EMAIL PROTECTED]> wrote: > > Brett Porter wrote: > > Just one comment if you start to implement download as part of idea:idea > > or eclipse:eclipse - please make sure it is consistent with the m2 > > implementation. > > > > Stephane Nicoll wrote: > >> dowload is interest

Re: [vote] Create a maven-sources-plugin for m1

2006-01-05 Thread Jason van Zyl
Brett Porter wrote: Just one comment if you start to implement download as part of idea:idea or eclipse:eclipse - please make sure it is consistent with the m2 implementation. Stephane Nicoll wrote: dowload is interesting. Example: IDE integration wants to download the source from the repositor

Re: [vote] Create a maven-sources-plugin for m1

2006-01-05 Thread Stephane Nicoll
Brett, Yep. Any pointer to the m2 implementation please? s/ On 1/5/06, Brett Porter <[EMAIL PROTECTED]> wrote: > > Just one comment if you start to implement download as part of idea:idea > or eclipse:eclipse - please make sure it is consistent with the m2 > implementation. > > Stephane Nicoll w

Re: [vote] Create a maven-sources-plugin for m1

2006-01-05 Thread Brett Porter
Just one comment if you start to implement download as part of idea:idea or eclipse:eclipse - please make sure it is consistent with the m2 implementation. Stephane Nicoll wrote: > dowload is interesting. Example: IDE integration wants to download the > source from the repository. Should not fail

Re: [vote] Create a maven-sources-plugin for m1

2006-01-05 Thread Arnaud HERITIER
If we are all agree to push this plugin with other core plugins, I'll create the project on Jira. I'll test it this week. Arnaud On 1/5/06, Stephane Nicoll <[EMAIL PROTECTED]> wrote: > > OK, done. > > Thx, > Stéphane > > On 1/5/06, Lukas Theussl <[EMAIL PROTECTED]> wrote: > > > > Thanks Stephane

Re: [vote] Create a maven-sources-plugin for m1

2006-01-05 Thread Stephane Nicoll
OK, done. Thx, Stéphane On 1/5/06, Lukas Theussl <[EMAIL PROTECTED]> wrote: > > Thanks Stephane! > > One first comment: the artifact:install-snapshot and > artifact:deploy-snapshot tags are deprecated in the artifact plugin, I > think you can just remove these goals (just use a version with SNAPS

Re: [vote] Create a maven-sources-plugin for m1

2006-01-05 Thread Lukas Theussl
Thanks Stephane! One first comment: the artifact:install-snapshot and artifact:deploy-snapshot tags are deprecated in the artifact plugin, I think you can just remove these goals (just use a version with SNAPSHOT)? -Lukas Stephane Nicoll wrote: Guys, Voilà, the plugin has been committed i

Re: [vote] Create a maven-sources-plugin for m1

2006-01-05 Thread Stephane Nicoll
Guys, Voilà, the plugin has been committed in the plugins-sandbox. http://svn.apache.org/viewcvs.cgi/maven/maven-1/plugins-sandbox/trunk/source/ It uses the maven.compile.src.set so any generated code (xdoclet, castor, whathever) will be included automatically. Let me know what you guys think and

Re: [vote] Create a maven-sources-plugin for m1

2006-01-05 Thread Milos Kleint
On 1/5/06, Stephane Nicoll <[EMAIL PROTECTED]> wrote: > > I am thinking about, downloading source for everything or not at all > (that's why I am insist on the warning if the source is not found > instead of a failure :) +1 Milos On 1/5/06, Milos Kleint <[EMAIL PROTECTED]> wrote: > > For examp

Re: [vote] Create a maven-sources-plugin for m1

2006-01-05 Thread Stephane Nicoll
I am thinking about, downloading source for everything or not at all (that's why I am insist on the warning if the source is not found instead of a failure :) On 1/5/06, Milos Kleint <[EMAIL PROTECTED]> wrote: > For example in mevenide/netbeans I'm downloading the sources not through > maven1 its

Re: [vote] Create a maven-sources-plugin for m1

2006-01-05 Thread Milos Kleint
For example in mevenide/netbeans I'm downloading the sources not through maven1 itself but manually for IDE plugin codebase. So a download goal not really a requirement. However having to specify a special source dependency for all binary deps sounds like a bit of overhead.. Milos On 1/5/06, Ste

Re: [vote] Create a maven-sources-plugin for m1

2006-01-05 Thread Stephane Nicoll
Guys, I will try to implement the source plugin today. I am not really sure where the JavaSourceArtifactHandler should be placed. The use cases I have in mind are the following: # Deploy java source code to the repository (easy, from the source plugin using an artifact handler) # Install java sou

Re: [vote] Create a maven-sources-plugin for m1

2006-01-05 Thread Stephane Nicoll
dowload is interesting. Example: IDE integration wants to download the source from the repository. Should not fail if it is not available though. Stéphane On 1/2/06, Arnaud HERITIER <[EMAIL PROTECTED]> wrote: > I thought to jar, install and deploy. > I don't know if there's an interest to manuall

Re: [vote] Create a maven-sources-plugin for m1

2006-01-04 Thread Vincent Siveton
+1 Vincent 2006/1/2, Arnaud HERITIER <[EMAIL PROTECTED]>: > Hi all, > > It seems useful for some users to have a maven-sources-plugin for m1. > http://jira.codehaus.org/browse/MAVEN-1736 > Are you agree if we add it in the m1 plugins ? > > [ ] +1 - It seems to be a good idea. > [ ] +0 - Don'

Re: [vote] Create a maven-sources-plugin for m1

2006-01-03 Thread Stephane Nicoll
Think so too. On 1/3/06, Arnaud HERITIER <[EMAIL PROTECTED]> wrote: > Yes actually it deploys all the project sources tree (to allow a user to > rebuild it). > It's not the same goal. > It's why it could be better to create a new plugin. > > Arnaud > > > On 1/3/06, Stephane Nicoll <[EMAIL PROTECTED

Re: [vote] Create a maven-sources-plugin for m1

2006-01-03 Thread Arnaud HERITIER
Yes actually it deploys all the project sources tree (to allow a user to rebuild it). It's not the same goal. It's why it could be better to create a new plugin. Arnaud On 1/3/06, Stephane Nicoll <[EMAIL PROTECTED]> wrote: > > We need a lightweight way to deploy source code on the repository. I

Re: [vote] Create a maven-sources-plugin for m1

2006-01-03 Thread Stephane Nicoll
We need a lightweight way to deploy source code on the repository. I think the dist plugin is doing much more right? s/ On 1/2/06, Arnaud HERITIER <[EMAIL PROTECTED]> wrote: > It's the doubt I have actually. > We already publish project sources in the dist plugin. > I don't like to create a new p

Re: [vote] Create a maven-sources-plugin for m1

2006-01-02 Thread Arnaud HERITIER
It's the doubt I have actually. We already publish project sources in the dist plugin. I don't like to create a new project (we have already enough plugins to maintain in m1) but it could be a good choice to mimic m2. Arnaud On 1/2/06, Lukas Theussl <[EMAIL PROTECTED]> wrote: > > +0 > > Shouldn'

Re: [vote] Create a maven-sources-plugin for m1

2006-01-02 Thread Arnaud HERITIER
I thought to jar, install and deploy. I don't know if there's an interest to manually download it. It can be done with a dependency. I'll take a look at the m2 plugin to mimic it. Arnaud On 1/2/06, Fabrizio Giustina <[EMAIL PROTECTED]> wrote: > > +1 > > to mimic what we are able to do with m2 it

Re: [vote] Create a maven-sources-plugin for m1

2006-01-02 Thread Stephane Nicoll
+1 definitely. On 1/2/06, Arnaud HERITIER <[EMAIL PROTECTED]> wrote: > Hi all, > > It seems useful for some users to have a maven-sources-plugin for m1. > http://jira.codehaus.org/browse/MAVEN-1736 > Are you agree if we add it in the m1 plugins ? > > [ ] +1 - It seems to be a good idea. >

Re: [vote] Create a maven-sources-plugin for m1

2006-01-02 Thread Jason van Zyl
Arnaud HERITIER wrote: Hi all, It seems useful for some users to have a maven-sources-plugin for m1. http://jira.codehaus.org/browse/MAVEN-1736 Are you agree if we add it in the m1 plugins ? [ ] +1 - It seems to be a good idea. [ ] +0 - Don't know [ ] -1 - No, I prefer . +1

Re: [vote] Create a maven-sources-plugin for m1

2006-01-02 Thread Lukas Theussl
+0 Shouldn't this be part of the dist plugin? We'd just have to add some goals like dist:source-deploy, dist:source-jar, etc? -Lukas Arnaud HERITIER wrote: Hi all, It seems useful for some users to have a maven-sources-plugin for m1. http://jira.codehaus.org/browse/MAVEN-1736 Are you

Re: [vote] Create a maven-sources-plugin for m1

2006-01-02 Thread Fabrizio Giustina
+1 to mimic what we are able to do with m2 it should include the following goals/tags: jar install deploy download is this what you are planning to include in the plugin? fabrizio On 1/2/06, Arnaud HERITIER <[EMAIL PROTECTED]> wrote: > Hi all, > > It seems useful for some users to have a mav

Re: [vote] Create a maven-sources-plugin for m1

2006-01-02 Thread Emmanuel Venisse
+1 Emmanuel Arnaud HERITIER a écrit : Hi all, It seems useful for some users to have a maven-sources-plugin for m1. http://jira.codehaus.org/browse/MAVEN-1736 Are you agree if we add it in the m1 plugins ? [ ] +1 - It seems to be a good idea. [ ] +0 - Don't know [ ] -1 - No, I pre

[vote] Create a maven-sources-plugin for m1

2006-01-02 Thread Arnaud HERITIER
Hi all, It seems useful for some users to have a maven-sources-plugin for m1. http://jira.codehaus.org/browse/MAVEN-1736 Are you agree if we add it in the m1 plugins ? [ ] +1 - It seems to be a good idea. [ ] +0 - Don't know [ ] -1 - No, I prefer . Arnaud