Re: [proposal] AbstractMojo enhancement

2008-04-06 Thread Mark Hobson
+1, I've thought this numerous times in the past. This class may be handy for the new component: http://svn.codehaus.org/mojo/trunk/sandbox/apt-maven-plugin/src/main/java/org/codehaus/mojo/apt/LogUtils.java Mark On 05/04/2008, Jason van Zyl <[EMAIL PROTECTED]> wrote: > > On 5-Apr-08, at 12:21

Re: [proposal] AbstractMojo enhancement

2008-04-05 Thread Jason van Zyl
On 5-Apr-08, at 12:21 PM, Benjamin Bentmann wrote: Could we make the AbstractMojo class more usefull by providing some commonly-used support methods ? +1 on the general idea to avoid copy&paste, -1 on the proposal to share code via AbstractMojo. For some reason, AbstractMojo is part of the

Re: [proposal] AbstractMojo enhancement

2008-04-05 Thread Jason van Zyl
I would use composition instead of inheritance and create helper components for those things. Pushing all the helper methods, when in most cases hardly any of them will be used, is not a good design. We definitely need helps for making classloaders (take the one from jetty run), working wit

Re: [proposal] AbstractMojo enhancement

2008-04-05 Thread Benjamin Bentmann
Could we make the AbstractMojo class more usefull by providing some commonly-used support methods ? +1 on the general idea to avoid copy&paste, -1 on the proposal to share code via AbstractMojo. For some reason, AbstractMojo is part of the uber JAR and as such updates to it would be bound to

[proposal] AbstractMojo enhancement

2008-04-05 Thread nicolas de loof
Hello, Plugin developer only require to implement the Mojo interface, but in most (all ?) the case they extend AbstractMojo. Having myself created or contributed multiple plugins, I had to solve the same issues many time, using an copy/paste. Could we make the AbstractMojo class more usefull by