Re: [maven-maven1-plugin] 3 patches awaiting review

2006-06-03 Thread Dennis Lundberg
I must say that I agree with Brett here. My goal has been to post small specific patches to JIRA, so that they can be easily reviewed. I know, from own experience, how difficult it can be to review a patch that does *everything*. It makes it hard to see what is really going on. However, if Car

Re: [maven-maven1-plugin] 3 patches awaiting review

2006-06-02 Thread Brett Porter
I disagree in general - it's easier to review smaller, specific patches, especially if one were to be rejected and the others accepted. Of course, the danger is that they build on top of each other and then it gets harder. That said, I'm not the one who put my hand up to apply the patches (th

Re: [maven-maven1-plugin] 3 patches awaiting review

2006-06-02 Thread Carlos Sanchez
ASs right now you are the only one working on it you should post a patch every week or so to reduce the amount of effort needed On 6/2/06, Dennis Lundberg <[EMAIL PROTECTED]> wrote: Hello again There are now three more patches available in JIRA, for the maven1-plugin, that needs some tender lov

Re: [maven-maven1-plugin] 3 patches awaiting review

2006-06-02 Thread Dennis Lundberg
Hello again There are now three more patches available in JIRA, for the maven1-plugin, that needs some tender love and care (i.e. review and commit) :) - http://jira.codehaus.org/browse/MNG-2335 - http://jira.codehaus.org/browse/MNG-2336 - http://jira.codehaus.org/browse/MNG-2338 These patche

Re: [maven-maven1-plugin] 3 patches awaiting review

2006-05-31 Thread Dennis Lundberg
Thanks! Carlos Sanchez wrote: Done. Thanks. On 5/31/06, Dennis Lundberg <[EMAIL PROTECTED]> wrote: Hi all Work on the maven-maven1-plugin is coming along nicely. So far I've submitted 3 patches to JIRA and a couple more are in the pipeline. Coming up next are: - use maven-model-converter inst

Re: [maven-maven1-plugin] 3 patches awaiting review

2006-05-31 Thread Carlos Sanchez
Done. Thanks. On 5/31/06, Dennis Lundberg <[EMAIL PROTECTED]> wrote: Hi all Work on the maven-maven1-plugin is coming along nicely. So far I've submitted 3 patches to JIRA and a couple more are in the pipeline. Coming up next are: - use maven-model-converter instead of bundled class - property

[maven-maven1-plugin] 3 patches awaiting review

2006-05-31 Thread Dennis Lundberg
Hi all Work on the maven-maven1-plugin is coming along nicely. So far I've submitted 3 patches to JIRA and a couple more are in the pipeline. Coming up next are: - use maven-model-converter instead of bundled class - property configuration converters for the checkstyle, jar and javadoc plugin