Re: [maven-enforcer] 05/05: Code improvement.

2018-11-09 Thread Eric Lilja
> > > > +private boolean isVersion( String version ) > > +{ > > +return StringUtils.isNotEmpty( version ) && > > !StringUtils.isWhitespace( version ); > > +} > Maybe use StringUtils.isNotBlank() instead? - Eric L

Re: [maven-enforcer] 05/05: Code improvement.

2018-11-09 Thread Karl Heinz Marbaise
Hi Robert, On 09/11/18 10:05, Robert Scholte wrote: Please rename to isValidVersion +    private boolean isVersion( String version ) Really good idea...Thanks for this ... Kind regards Karl Heinz Marbaise +    { +    return StringUtils.isNotEmpty( version ) && !StringUtils.isWhitesp

Re: [maven-enforcer] 05/05: Code improvement.

2018-11-09 Thread Robert Scholte
On Fri, 09 Nov 2018 08:58:49 +0100, wrote: This is an automated email from the ASF dual-hosted git repository. khmarbaise pushed a commit to branch MENFORCER-306 in repository https://gitbox.apache.org/repos/asf/maven-enforcer.git commit e81e13178ae3ea153a0d0c5936ca951b71a73bc3 Author: Karl H