Re: Changed vote Re: [Vote] maven-shade-plugin release 1.0-alpha-14 and move out of sandbox

2007-12-11 Thread Mauro Talevi
Brian E. Fox wrote: It would be cool if you could try the new candidate on 2.0.x also. I had trouble with it excluding tons of stuff when I did 2.0.8. I can try it later today if you can't. Built a 2.0.9 snapshot and try it out on a sample projects. No problems encountered. So it does look pr

Re: Changed vote Re: [Vote] maven-shade-plugin release 1.0-alpha-14 and move out of sandbox

2007-12-11 Thread Dan Fabulich
Daniel Kulp wrote: OK. I fixed one more issue with it. Can you give it another try. :-) Getting closer. Yup, looks good to me. I've closed MSHADE-5 again. -Dan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additi

RE: Changed vote Re: [Vote] maven-shade-plugin release 1.0-alpha-14 and move out of sandbox

2007-12-11 Thread Brian E. Fox
: dev@maven.apache.org Cc: Dan Fabulich Subject: Re: Changed vote Re: [Vote] maven-shade-plugin release 1.0-alpha-14 and move out of sandbox OK. I fixed one more issue with it. Can you give it another try. :-) Getting closer. Dan On Tuesday 11 December 2007, Dan Fabulich wrote: > Fixed o

Re: Changed vote Re: [Vote] maven-shade-plugin release 1.0-alpha-14 and move out of sandbox

2007-12-11 Thread Daniel Kulp
OK. I fixed one more issue with it. Can you give it another try. :-) Getting closer. Dan On Tuesday 11 December 2007, Dan Fabulich wrote: > Fixed on my end (I think... this bug is finicky); try it on your end > to make sure I didn't break anything further? > > -Dan > > Dan Fabulich wro

Re: Changed vote Re: [Vote] maven-shade-plugin release 1.0-alpha-14 and move out of sandbox

2007-12-11 Thread Dan Fabulich
Fixed on my end (I think... this bug is finicky); try it on your end to make sure I didn't break anything further? -Dan Dan Fabulich wrote: Daniel Kulp wrote: I changed the rename logic to do a whole bunch of fallback things if the first rename fails. It first will try a gc to see if any

Re: Changed vote Re: [Vote] maven-shade-plugin release 1.0-alpha-14 and move out of sandbox

2007-12-11 Thread Dan Fabulich
Mauro Talevi wrote: I've commented on MSHADE-7 - as far as I can tell, feature is already implemented, via shadedArtifact attachment. Please try out the configuration in: MSHADE-7 is a very different feature from shadedArtifactAttached. MSHADE-7 suggests that the generated classes just get

Re: Changed vote Re: [Vote] maven-shade-plugin release 1.0-alpha-14 and move out of sandbox

2007-12-11 Thread Dan Fabulich
Daniel Kulp wrote: I changed the rename logic to do a whole bunch of fallback things if the first rename fails. It first will try a gc to see if any Streams that are holding it locked can be cleaned up. If that still fails, then it will just copy the new file over the old file. Not ideal, b

Re: Changed vote Re: [Vote] maven-shade-plugin release 1.0-alpha-14 and move out of sandbox

2007-12-11 Thread Daniel Kulp
Dan, Can you try a deploy with 1.0-alpha-15-SNAPSHOT? I changed the rename logic to do a whole bunch of fallback things if the first rename fails. It first will try a gc to see if any Streams that are holding it locked can be cleaned up. If that still fails, then it will just copy the new

Re: Changed vote Re: [Vote] maven-shade-plugin release 1.0-alpha-14 and move out of sandbox

2007-12-11 Thread Mauro Talevi
Dan Fabulich wrote: Uh, actually, I need to turn my vote to a -1. :-( I just discovered that I'm being bitten by MSHADE-5 (and MSHADE-6) every time I go to deploy the Surefire 2.4-SNAPSHOT. As a result, I deployed a corrupted SNAPSHOT... yuck! I just fixed MSHADE-6 in the sandbox, which wo

Changed vote Re: [Vote] maven-shade-plugin release 1.0-alpha-14 and move out of sandbox

2007-12-11 Thread Dan Fabulich
Uh, actually, I need to turn my vote to a -1. :-( I just discovered that I'm being bitten by MSHADE-5 (and MSHADE-6) every time I go to deploy the Surefire 2.4-SNAPSHOT. As a result, I deployed a corrupted SNAPSHOT... yuck! I just fixed MSHADE-6 in the sandbox, which would have at least pre

Re: [Vote] maven-shade-plugin release 1.0-alpha-14 and move out of sandbox

2007-12-10 Thread Dan Fabulich
+1. This works with the latest Surefire trunk. (It's a pity MSHADE-9 is still broken, but I think it's OK for another alpha; we should fix it for beta-1.) -Dan Mauro Talevi wrote: As version 1.0-alpha-14 has been staged for release, I'd like to call a vote for its release and the move out

[Vote] maven-shade-plugin release 1.0-alpha-14 and move out of sandbox

2007-12-10 Thread Mauro Talevi
As version 1.0-alpha-14 has been staged for release, I'd like to call a vote for its release and the move out of the sandbox and to version 1.0-beta-1-SNAPSHOT. Staging area: http://people.apache.org/~mauro/staging-repo/ Tag: http://svn.apache.org/repos/asf/maven/plugins/tags/maven-shade-plug