[CANCELED] [VOTE] Release Maven Resolver version 1.6.0

2020-09-27 Thread Michael Osipov
The vote has been canceled! Luckily, Dan was able to find the offending commit. At the end, this does not look very good for the community because SHA-2, in some cases, is unusable to due to tremendous calculation overhead. I wil rework and reoll after Dan has verified another patch. Michael

Re: [VOTE] Release Maven Resolver version 1.6.0

2020-09-26 Thread Michael Osipov
Alright, thanks! I know what to do now. Will work on this next week and let you know. Thank you very much again for your support! Am 2020-09-27 um 00:14 schrieb Dan Tran: without -Daether.checksums.algorithms=SHA1,MD5, very slow -D On Sat, Sep 26, 2020 at 3:11 PM Michael Osipov wrote: Aw

Re: [VOTE] Release Maven Resolver version 1.6.0

2020-09-26 Thread Dan Tran
without -Daether.checksums.algorithms=SHA1,MD5, very slow -D On Sat, Sep 26, 2020 at 3:11 PM Michael Osipov wrote: > Awesome, what about with the fix, but with the default list of hashing > algos (SHA-512, SHA-256, SHA-1, MD5) in place? > > Am 2020-09-27 um 00:07 schrieb Dan Tran: > > it work

Re: [VOTE] Release Maven Resolver version 1.6.0

2020-09-26 Thread Michael Osipov
Awesome, what about with the fix, but with the default list of hashing algos (SHA-512, SHA-256, SHA-1, MD5) in place? Am 2020-09-27 um 00:07 schrieb Dan Tran: it works using the provided commitID + -Daether.checksums.algorithms=SHA1,MD5 -D On Sat, Sep 26, 2020 at 2:25 PM Michael Osipov wr

Re: [VOTE] Release Maven Resolver version 1.6.0

2020-09-26 Thread Dan Tran
it works using the provided commitID + -Daether.checksums.algorithms=SHA1,MD5 -D On Sat, Sep 26, 2020 at 2:25 PM Michael Osipov wrote: > Gosh, I assumed so. Every SHA family is horrible in terms of > performance. This is going to be a huge problem for the community, I > would prefer Blake2 or

Re: [VOTE] Release Maven Resolver version 1.6.0

2020-09-26 Thread Michael Osipov
Gosh, I assumed so. Every SHA family is horrible in terms of performance. This is going to be a huge problem for the community, I would prefer Blake2 or Blake3 for this. Anyway, I think this is the root cause, actually the fix: https://github.com/apache/maven-resolver/commit/a9e0ca8307e532fc30

Re: [VOTE] Release Maven Resolver version 1.6.0

2020-09-26 Thread Dan Tran
I am able to pin down the problematic commit: https://github.com/apache/maven-resolver/commit/8e8a4f1944a0589397e36a5dd049ec765424e863 Adding -Daether.checksums.algorithms=SHA1,MD5 to maven command line does not help Sorry about the delay -D On Wed, Sep 16, 2020 at 1:57 AM Michael Osipov wrot

Re: [VOTE] Release Maven Resolver version 1.6.0

2020-09-16 Thread Michael Osipov
Your logging config is sound, so appearently nothing is wrong. You see no trace because DefaultSyncContextFactory is empty and there is nothing to trace. Something else is the cause. Can you git bisect 1.4.2 and 1.6.0 to find the offending commit? Otherwise I have no idea and we are searching

Re: [VOTE] Release Maven Resolver version 1.6.0

2020-09-15 Thread Dan Tran
this is my log config org.slf4j.simpleLogger.defaultLogLevel=info org.slf4j.simpleLogger.showDateTime=true org.slf4j.simpleLogger.showThreadName=true org.slf4j.simpleLogger.showShortLogName=true org.slf4j.simpleLogger.showLogName=false org.slf4j.simpleLogger.logFile=System.out org.slf4j.simpleLogg

Re: [VOTE] Release Maven Resolver version 1.6.0

2020-09-15 Thread Dan Tran
Maven 3.7.0 with Resolver 1.4.2 - no issue Maven 3.7.0 with Resolver 1.6.0 + trace. I cant get any indication about 4626 [main] [TRACE] GlobalSyncContextFactory$GlobalSyncContext - Acquiring global... 35318 [main] [TRACE] GlobalSyncContextFactory$GlobalSyncContext - Releasing global... Ver

Re: [VOTE] Release Maven Resolver version 1.6.0

2020-09-15 Thread Michael Osipov
There is no new feature active in 1.6.0 in this regard. Here is the diff: https://github.com/apache/maven-resolver/compare/maven-resolver-1.4.2...maven-resolver-1.6.0?w=1 Since I do not have access to your project, can you please try the following: * Maven 3.7.0 with Resolver 1.4.2 * Maven 3.

Re: [VOTE] Release Maven Resolver version 1.6.0

2020-09-15 Thread Dan Tran
I build maven 3.7.0 + MResolve 1.6.0. The same slow build observed at my 300+ modules ( 60min versus 5min) -1 ( non-binding) from me. there must and option to disable this new feature -D On Mon, Sep 14, 2020 at 4:33 AM Michael Osipov wrote: > Am 2020-09-14 um 10:57 schrieb Dan Tran: > > sor

Re: [VOTE] Release Maven Resolver version 1.6.0

2020-09-14 Thread Michael Osipov
Am 2020-09-14 um 10:57 schrieb Dan Tran: sorry about the fast finger, my test shows a huge increase in build time for large builds. Possible to disable this feature? This cannot be. It has been superceded by https://issues.apache.org/jira/browse/MRESOLVER-130. The GlobalSyncContextFactory h

Re: [VOTE] Release Maven Resolver version 1.6.0

2020-09-14 Thread Dan Tran
sorry about the fast finger, my test shows a huge increase in build time for large builds. Possible to disable this feature? Thanks -D On Mon, Sep 14, 2020 at 1:49 AM Dan Tran wrote: > possible to disable this feature > https://issues.apache.org/jira/browse/MRESOLVER-123 ? > > On Mon, Sep 14

Re: [VOTE] Release Maven Resolver version 1.6.0

2020-09-14 Thread Dan Tran
possible to disable this feature https://issues.apache.org/jira/browse/MRESOLVER-123 ? On Mon, Sep 14, 2020 at 12:06 AM Romain Manni-Bucau wrote: > +1, tested in java 8 with mvn 3.6.3. > > Romain Manni-Bucau > @rmannibucau | Blog >

Re: [VOTE] Release Maven Resolver version 1.6.0

2020-09-14 Thread Romain Manni-Bucau
+1, tested in java 8 with mvn 3.6.3. Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn | Book

Re: [VOTE] Release Maven Resolver version 1.6.0

2020-09-13 Thread Enrico Olivelli
+1 checked checksum and run tests on JDK14 + Mac mvn -v Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: xx Java version: 14, vendor: AdoptOpenJDK, runtime: /Library/Java/JavaVirtualMachines/adoptopenjdk-14.jdk/Contents/Home Default locale: it_IT, platform encodin

Re: [VOTE] Release Maven Resolver version 1.6.0

2020-09-13 Thread Hervé BOUTEMY
+1 sadly, the build is not reproducible: reference build done with JDK 8 on Windows, but Felix Maven Bundle Plugin is causing issues in generated META- INF/MANIFEST.MF (contains username, detailed JDK version, and order or Private Package not reproducible): I'll have a look to check if recent up

Re: [VOTE] Release Maven Resolver version 1.6.0

2020-09-13 Thread Michael Osipov
Am 2020-09-11 um 20:19 schrieb Michael Osipov: Hi, We solved 19 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12348666 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/projects/MRESOLVER/issues?filter=allopenissues

[VOTE] Release Maven Resolver version 1.6.0

2020-09-11 Thread Michael Osipov
Hi, We solved 19 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12348666 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/projects/MRESOLVER/issues?filter=allopenissues Staging repo: https://repository.apache.org/content/