Re: [VOTE] Release Maven Javadoc plugin version 2.5 (take 2)

2008-08-26 Thread Vincent Siveton
The vote has passed with the following votes: +1 binding Olivier, Lukas, Arnaud, Vincent +1 non binding Benjamin Voigt, Annies Sebastian, Hervé Boutemy, Nicolas de loof I'll move the artifacts over. Cheers, Vincent 2008/8/22 Vincent Siveton <[EMAIL PROTECTED]>: > Hi, > > We solved more than 30

Re: [VOTE] Release Maven Javadoc plugin version 2.5 (take 2)

2008-08-25 Thread nicolas de loof
+1 2008/8/25 Arnaud HERITIER <[EMAIL PROTECTED]> > +1 > > Arnaud > > On Mon, Aug 25, 2008 at 10:41 AM, Lukas Theussl <[EMAIL PROTECTED]> > wrote: > > > +1 > > > > -Lukas > > > > > > > > Vincent Siveton wrote: > > > >> Hi, > >> > >> We solved more than 30 issues: > >> > >> > http://jira.codehaus.o

Re: [VOTE] Release Maven Javadoc plugin version 2.5 (take 2)

2008-08-25 Thread Arnaud HERITIER
+1 Arnaud On Mon, Aug 25, 2008 at 10:41 AM, Lukas Theussl <[EMAIL PROTECTED]> wrote: > +1 > > -Lukas > > > > Vincent Siveton wrote: > >> Hi, >> >> We solved more than 30 issues: >> >> http://jira.codehaus.org/secure/ReleaseNote.jspa?version=14120&styleName=Html&projectId=11138 >> >> There are st

Re: [VOTE] Release Maven Javadoc plugin version 2.5 (take 2)

2008-08-25 Thread Lukas Theussl
+1 -Lukas Vincent Siveton wrote: Hi, We solved more than 30 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?version=14120&styleName=Html&projectId=11138 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=true&pid=11138&status=1

Re: [VOTE] Release Maven Javadoc plugin version 2.5 (take 2)

2008-08-24 Thread Hervé BOUTEMY
+1 (non-binding) Hervé Le vendredi 22 août 2008, Vincent Siveton a écrit : > Hi, > > We solved more than 30 issues: > http://jira.codehaus.org/secure/ReleaseNote.jspa?version=14120&styleName=Ht >ml&projectId=11138 > > There are still a couple of issues left in JIRA: > http://jira.codehaus.org/sec

Re: [VOTE] Release Maven Javadoc plugin version 2.5 (take 2)

2008-08-24 Thread Olivier Lamy
+1 -- Olivier 2008/8/22 Vincent Siveton <[EMAIL PROTECTED]>: > Hi, > > We solved more than 30 issues: > http://jira.codehaus.org/secure/ReleaseNote.jspa?version=14120&styleName=Html&projectId=11138 > > There are still a couple of issues left in JIRA: > http://jira.codehaus.org/secure/IssueNavigato

AW: [VOTE] Release Maven Javadoc plugin version 2.5 (take 2)

2008-08-22 Thread Annies, Sebastian
Great. No problems with our 40+ modules. A non-binding +1 >From me. -Ursprüngliche Nachricht- Von: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Im Auftrag von Vincent Siveton Gesendet: Freitag, 22. August 2008 14:53 An: Maven Developers List Betreff: [VOTE] Release Maven Javadoc plu

Re: [VOTE] Release Maven Javadoc plugin version 2.5 (take 2)

2008-08-22 Thread Benjamin Voigt
Vincent Siveton schrieb: > Hi, > > We solved more than 30 issues: > http://jira.codehaus.org/secure/ReleaseNote.jspa?version=14120&styleName=Html&projectId=11138 > > There are still a couple of issues left in JIRA: > http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=true&pid=11138&status=

[VOTE] Release Maven Javadoc plugin version 2.5 (take 2)

2008-08-22 Thread Vincent Siveton
Hi, We solved more than 30 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?version=14120&styleName=Html&projectId=11138 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=true&pid=11138&status=1 Staging repo: http://people.apache.o

Re: [VOTE] Release Maven Javadoc Plugin version 2.5

2008-08-02 Thread Vincent Siveton
2008/8/2 Benjamin Bentmann <[EMAIL PROTECTED]>: > Vincent Siveton wrote: > >> Definitely. I think each plugins should have a faq/page about encoding >> and of course in the general site. > > I assume a user looking for configuration documentation is first checking > the mojo documentation, so we sh

Re: [VOTE] Release Maven Javadoc Plugin version 2.5

2008-08-02 Thread Benjamin Bentmann
Vincent Siveton wrote: Definitely. I think each plugins should have a faq/page about encoding and of course in the general site. I assume a user looking for configuration documentation is first checking the mojo documentation, so we should aim at proper javadocs directly at the mojo paramete

Re: [VOTE] Release Maven Javadoc Plugin version 2.5

2008-08-02 Thread Vincent Siveton
2008/8/2 Benjamin Bentmann <[EMAIL PROTECTED]>: > Hervé BOUTEMY wrote: > >> from a user point of view, why not: it will require more code from us to >> mimic this, but the logic seems ok for me > > You're right, the logic itself is not that bad. My remaining concern is the > minimal POM where we do

Re: [VOTE] Release Maven Javadoc Plugin version 2.5

2008-08-02 Thread Vincent Siveton
Hi Benjamin, 2008/8/2 Benjamin Bentmann <[EMAIL PROTECTED]>: > Vincent Siveton wrote: > >> Nope. The code passed the encoding parameter *only* if it was not empty. > > You're right, I forgot that the Maven JVM might be running with a different > default encoding than the system default that would

Re: [VOTE] Release Maven Javadoc Plugin version 2.5

2008-08-02 Thread Benjamin Bentmann
Hervé BOUTEMY wrote: from a user point of view, why not: it will require more code from us to mimic this, but the logic seems ok for me You're right, the logic itself is not that bad. My remaining concern is the minimal POM where we don't have a fixed source encoding, causing platform-depend

Re: [VOTE] Release Maven Javadoc Plugin version 2.5

2008-08-02 Thread Hervé BOUTEMY
Le samedi 02 août 2008, Benjamin Bentmann a écrit : > The Javadoc plugin is currently breaking with the proposal. As a matter > of consistency, we might need to adjust the proposal if the community > doesn't accept it's current form. But I wonder how the alternative would > look like? Have all repo

Re: [VOTE] Release Maven Javadoc Plugin version 2.5

2008-08-02 Thread Hervé BOUTEMY
Le samedi 02 août 2008, Vincent Siveton a écrit : > >> -docencoding "If you omit this option but use -encoding, then the > >> encoding of the generated HTML files is determined by -encoding." > >> We need to reflect this logic and NOT using UTF-8 which is actually the > >> default. > > > > But usin

Re: [VOTE] Release Maven Javadoc Plugin version 2.5

2008-08-02 Thread Benjamin Bentmann
Vincent Siveton wrote: Nope. The code passed the encoding parameter *only* if it was not empty. You're right, I forgot that the Maven JVM might be running with a different default encoding than the system default that would be picked by javadoc if "encoding" wasn't specified. Yes but I th

Re: [VOTE] Release Maven Javadoc Plugin version 2.5

2008-08-02 Thread Hervé BOUTEMY
Le samedi 02 août 2008, Benjamin Bentmann a écrit : > Vincent Siveton wrote: > > So by default, we have now: > > - encoding = ${project.build.sourceEncoding} > > - docencoding = ${project.reporting.outputEncoding} > > - charset = null > > > > And if charset == null, charset = docencoding > > Yes, a

Re: [VOTE] Release Maven Javadoc Plugin version 2.5

2008-08-02 Thread Vincent Siveton
2008/8/2 Benjamin Bentmann <[EMAIL PROTECTED]>: > Vincent Siveton wrote: > >> So by default, we have now: >> - encoding = ${project.build.sourceEncoding} >> - docencoding = ${project.reporting.outputEncoding} >> - charset = null >> >> And if charset == null, charset = docencoding > > Yes, as per MJ

Re: [VOTE] Release Maven Javadoc Plugin version 2.5

2008-08-02 Thread Benjamin Bentmann
Vincent Siveton wrote: So by default, we have now: - encoding = ${project.build.sourceEncoding} - docencoding = ${project.reporting.outputEncoding} - charset = null And if charset == null, charset = docencoding Yes, as per MJAVADOC-182 and MJAVADOC-206, i.e. setting "docencoding" is usually

Re: [VOTE] Release Maven Javadoc Plugin version 2.5

2008-08-02 Thread Vincent Siveton
Hi Benjamin, Thanks to spot it! I will revert the release and call a new one. So by default, we have now: - encoding = ${project.build.sourceEncoding} - docencoding = ${project.reporting.outputEncoding} - charset = null And if charset == null, charset = docencoding I will add a faq about this l

Re: [VOTE] Release Maven Javadoc Plugin version 2.5

2008-08-02 Thread Benjamin Bentmann
Hi Vincent, We solved around 30 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?version=14120&styleName=Text&projectId=11138 The handling of the charset parameter I proposed to Hervé in MJAVADOC-206 gives rise to misbehavior. Imagine the following plugin configuration: ISO-

[VOTE] Release Maven Javadoc Plugin version 2.5

2008-08-01 Thread Vincent Siveton
Hi, We solved around 30 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?version=14120&styleName=Text&projectId=11138 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=true&pid=11138&status=1 Staging repo: http://people.apache.org/