Re: [VOTE] Release Maven Help plugin version 2.1 (take 2)

2008-09-04 Thread Vincent Siveton
The vote has passed with the following votes: +1 brett, olivier, emmanuel, arnaud, vincent I'll move the artifacts over. Cheers, Vincent 2008/8/31 Vincent Siveton <[EMAIL PROTECTED]>: > Hi, > > We solved more than 20 issues: > http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11141&sty

Re: [VOTE] Release Maven Help plugin version 2.1 (take 2)

2008-09-02 Thread Arnaud HERITIER
Ok. You're right Benjamin. This code is only used in internal to not duplicate the code already generated by the Help Mojo. Thue, without MNG-3284 it's an non-issue. it's just a build bug. I tested it. You have my +1. On Tue, Sep 2, 2008 at 4:41 PM, Arnau

Re: [VOTE] Release Maven Help plugin version 2.1 (take 2)

2008-09-02 Thread Arnaud HERITIER
It's what I'm seeing Thus this test reveals that the help plugin will fail on a plugin generated with a maven-plugin-plugin < 2.4.3 I think it's an important issue I'm trying to patch it... On Tue, Sep 2, 2008 at 4:25 PM, Benjamin Bentmann <[EMAIL PROTECTED] > wrote: > Arnaud HERITIER schrieb: >

Re: [VOTE] Release Maven Help plugin version 2.1 (take 2)

2008-09-02 Thread Benjamin Bentmann
Arnaud HERITIER schrieb: There's no toLines method with 4 args This is true for the help mojo generated by maven-plugin-tools:2.4.2, version 2.4.3 will output the 4 arg methods. Just try it locally by switching versions in the Help Plugin's POM and compare the HelpMojo. This clearly indica

Re: [VOTE] Release Maven Help plugin version 2.1 (take 2)

2008-09-02 Thread Arnaud HERITIER
-1 (I hate to do that) I didn't test it but I tried to build all our plugins and a test is failing if we are in the reactor If I build only the plugin, tests pass. We have the same error in hudson : https://ci.sonatype.org/view/Plugins/job/plugins-CI-with-maven-2.0.x/org.apache.maven.plugins$maven-

Re: [VOTE] Release Maven Help plugin version 2.1 (take 2)

2008-09-02 Thread Emmanuel Venisse
+1 Emmanuel On Mon, Sep 1, 2008 at 1:29 AM, Vincent Siveton <[EMAIL PROTECTED]> wrote: > Hi, > > We solved more than 20 issues: > > http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11141&styleName=Html&version=12300 > > There are still a couple of issues left in JIRA: > > http://jira.c

Re: [VOTE] Release Maven Help plugin version 2.1 (take 2)

2008-09-02 Thread Olivier Lamy
+1 -- Olivier 2008/9/1 Vincent Siveton <[EMAIL PROTECTED]>: > Hi, > > We solved more than 20 issues: > http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11141&styleName=Html&version=12300 > > There are still a couple of issues left in JIRA: > http://jira.codehaus.org/secure/IssueNavigato

Re: [VOTE] Release Maven Help plugin version 2.1 (take 2)

2008-09-01 Thread Brett Porter
+1 On 01/09/2008, at 9:29 AM, Vincent Siveton wrote: Hi, We solved more than 20 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11141&styleName=Html&version=12300 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=true

[VOTE] Release Maven Help plugin version 2.1 (take 2)

2008-08-31 Thread Vincent Siveton
Hi, We solved more than 20 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11141&styleName=Html&version=12300 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=true&pid=11141&status=1 Staging repo: http://people.apache.o

Re: [VOTE] Release Maven Help plugin version 2.1

2008-08-29 Thread Vincent Siveton
Hi Dan, Thanks to take time to test it and fix issues! I will revert the release, fix some pbs and propose a new release soon. Cheers, Vincent 2008/8/29 Dan Fabulich <[EMAIL PROTECTED]>: > OK, I've added fixes I care about. > > -Dan > > Dan Fabulich wrote: > >> -1, though I could be convinced t

Re: [VOTE] Release Maven Help plugin version 2.1

2008-08-28 Thread Dan Fabulich
OK, I've added fixes I care about. -Dan Dan Fabulich wrote: -1, though I could be convinced to change my mind if we felt like we were in a rush for some reason. I found a number of documentation-level bugs that I think should be straightforward to fix... I'm checking in a few fixes now. -

Re: [VOTE] Release Maven Help plugin version 2.1

2008-08-28 Thread Dan Fabulich
-1, though I could be convinced to change my mind if we felt like we were in a rush for some reason. I found a number of documentation-level bugs that I think should be straightforward to fix... I'm checking in a few fixes now. -Dan Vincent Siveton wrote: Hi, We solved less than 20 issues

[VOTE] Release Maven Help plugin version 2.1

2008-08-28 Thread Vincent Siveton
Hi, We solved less than 20 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11141&styleName=Html&version=12300 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=true&pid=11141&status=1 Staging repo: http://people.apache.o