Re: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-04-08 Thread Rahul Thakur
08 4:33 AM To: Maven Developers List Subject: Re: [VOTE] Release Maven Eclipse plugin version 2.5.1 On Wed, Apr 2, 2008 at 11:13 AM, Arnaud HERITIER<[EMAIL PROTECTED]> wrote: Hi Jerome, As you noticed, this plugin requires to be build with maven>= 2.0.8 because of some tests with encodin

Re: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-04-08 Thread Arnaud HERITIER
e: > > > This only works on single module builds, the prerequisite field is not > > inherited. > > > > -Original Message- > > From: Jerome Lacoste [mailto:[EMAIL PROTECTED] > > Sent: Thursday, April 03, 2008 4:33 AM > > To: Maven Developers Li

Re: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-04-08 Thread Rahul Thakur
Rahul Brian E. Fox wrote: This only works on single module builds, the prerequisite field is not inherited. -Original Message- From: Jerome Lacoste [mailto:[EMAIL PROTECTED] Sent: Thursday, April 03, 2008 4:33 AM To: Maven Developers List Subject: Re: [VOTE] Release Maven Eclipse plugin v

Re: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-04-04 Thread Arnaud HERITIER
nded for tools and isn't > > > > inherited (making it not good for normal builds) but does apply at > > > > runtime. In this instance, the prerequisite is the most appropriate > way > > > > to require the maven version. > > > > >

Re: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-04-04 Thread Olivier Lamy
rerequisite is the most appropriate way > > > to require the maven version. > > > > > > > > > -Original Message----- > > > From: Richard van Nieuwenhoven [mailto:[EMAIL PROTECTED] > > > Sent: Thursday, April 03, 2008 6:08

Re: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-04-04 Thread Arnaud HERITIER
normal builds) but does apply at > > > > runtime. In this instance, the prerequisite is the most appropriate > way > > > > to require the maven version. > > > > > > > > > > > > -Original Message- > > > > Fro

Re: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-04-04 Thread Siarhei Dudzin
ce, the prerequisite is the most appropriate > way > > > to require the maven version. > > > > > > > > > -----Original Message----- > > > From: Richard van Nieuwenhoven [mailto:[EMAIL PROTECTED] > > > Sent: Thursday, April 03, 2008

Re: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-04-04 Thread Lukas Theussl
Maven Developers List Subject: Re: [VOTE] Release Maven Eclipse plugin version 2.5.1 Hi, the requireMavenVersion also applies to the runtime, but 2.0.8 is just required for the testing during the build. As far as i know not for the runtime. We use the plugin in a lot of projects that are locke

Re: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-04-04 Thread Stefan Bley
OTECTED] > Sent: Thursday, April 03, 2008 6:08 AM > To: Maven Developers List > Subject: Re: [VOTE] Release Maven Eclipse plugin version 2.5.1 > > > > Hi, > > the requireMavenVersion also applies to the runtime, but 2.0.8 is just > required for the testing

Re: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-04-04 Thread Arnaud HERITIER
IL PROTECTED] > > Sent: Thursday, April 03, 2008 6:08 AM > > To: Maven Developers List > > Subject: Re: [VOTE] Release Maven Eclipse plugin version 2.5.1 > > > > > > > > Hi, > > > > the requireMavenVersion also applies to the runti

Re: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-04-03 Thread Arnaud HERITIER
> To: Maven Developers List > Subject: Re: [VOTE] Release Maven Eclipse plugin version 2.5.1 > > > > Hi, > > the requireMavenVersion also applies to the runtime, but 2.0.8 is just > required for the testing during the build. As far as i know not for the > runtime.

RE: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-04-03 Thread Brian E. Fox
euwenhoven [mailto:[EMAIL PROTECTED] Sent: Thursday, April 03, 2008 6:08 AM To: Maven Developers List Subject: Re: [VOTE] Release Maven Eclipse plugin version 2.5.1 Hi, the requireMavenVersion also applies to the runtime, but 2.0.8 is just required for the testing during the build. As far as i know n

RE: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-04-03 Thread Brian E. Fox
This only works on single module builds, the prerequisite field is not inherited. -Original Message- From: Jerome Lacoste [mailto:[EMAIL PROTECTED] Sent: Thursday, April 03, 2008 4:33 AM To: Maven Developers List Subject: Re: [VOTE] Release Maven Eclipse plugin version 2.5.1 On Wed, Apr

Re: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-04-03 Thread Richard van Nieuwenhoven
Hi, the requireMavenVersion also applies to the runtime, but 2.0.8 is just required for the testing during the build. As far as i know not for the runtime. We use the plugin in a lot of projects that are locked to maven 2.0.7. So please limit it only for the build time. regards, Ritchie Jerom

Re: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-04-03 Thread Arnaud HERITIER
ok thanks. I'll close the vote this evening and I'll release it. I'll probably release a version 2.5.2 the next week. cheers arnaud On Thu, Apr 3, 2008 at 10:32 AM, Jerome Lacoste <[EMAIL PROTECTED]> wrote: > On Wed, Apr 2, 2008 at 11:13 AM, Arnaud HERITIER <[EMAIL PROTECTED]> wrote: > > Hi Jer

Re: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-04-03 Thread Jerome Lacoste
On Wed, Apr 2, 2008 at 11:13 AM, Arnaud HERITIER <[EMAIL PROTECTED]> wrote: > Hi Jerome, > > As you noticed, this plugin requires to be build with maven >= 2.0.8 > because of some tests with encodings. > I'll add an enforcer rule as Benjamin proposed. I had added a patch to the issue hat use

Re: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-04-02 Thread Arnaud HERITIER
Hi Jerome, As you noticed, this plugin requires to be build with maven >= 2.0.8 because of some tests with encodings. I'll add an enforcer rule as Benjamin proposed. Arnaud On Mon, Mar 31, 2008 at 12:55 PM, Jerome Lacoste <[EMAIL PROTECTED]> wrote: > On Fri, Mar 28, 2008 at 2:37 AM, Arnaud HER

Re: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-03-31 Thread Jerome Lacoste
On Fri, Mar 28, 2008 at 2:37 AM, Arnaud HERITIER <[EMAIL PROTECTED]> wrote: > Hi, > > Since the 2.5 release we did 10 days ago, we solved 3 annoying issues: >* [MECLIPSE-266] - plugin applies java facet to ear project >* [MECLIPSE-411] - manifest property usage is only for ogsi maifests >

Re: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-03-28 Thread John Casey
I think I've found a fix for the issue in the 2.0.9 code. I've committed it along with two new integration tests under the issue MNG-3221. Hopefully there will be a new RC soon that you can check against. Thanks, -john On Mar 28, 2008, at 6:06 AM, nicolas de loof wrote: I found the caus

Re: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-03-28 Thread John Casey
I think the issue probably has something to do with the fix I added to maven-core for MNG-3221. I'm looking into that code now to see if I can figure out how the modification breaks this case. -john On Mar 28, 2008, at 6:06 AM, nicolas de loof wrote: I found the cause of this issue : As I

Re: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-03-28 Thread Arnaud HERITIER
It's on my todo list. I began to prepare a big refactoring/rewrite of this plugin. it will be a 3.0. I'll give more details about what I have in mind in some weeks cheers arnaud On Fri, Mar 28, 2008 at 6:03 PM, nicolas de loof <[EMAIL PROTECTED]> wrote: > +1 > > please cleanup the plugin that is

Re: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-03-28 Thread nicolas de loof
+1 please cleanup the plugin that is allready not so simple to maintain ;-p 2008/3/28, Richard van Nieuwenhoven <[EMAIL PROTECTED]>: > > Hi, > > just created the JIRA http://jira.codehaus.org/browse/MECLIPSE-415 and > attached the patch. This problem seems to be connected to the wrongly > used e

Re: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-03-28 Thread Richard van Nieuwenhoven
Hi, just created the JIRA http://jira.codehaus.org/browse/MECLIPSE-415 and attached the patch. This problem seems to be connected to the wrongly used executedProject parameter and maven 2.0.9. The stage thing is that "testProject11" fails when i remove the usage of the executedProject. Also i am

Re: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-03-28 Thread Arnaud HERITIER
Ok. Thx a lot. I'll fix it with the executedProject the next week. Arnaud On Fri, Mar 28, 2008 at 12:16 PM, Richard van Nieuwenhoven <[EMAIL PROTECTED]> wrote: > hmmm, that seems to be a relict of the old usage of the workspace > variable usage (that Arnaud removed). Later today i will create a

Re: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-03-28 Thread Richard van Nieuwenhoven
hmmm, that seems to be a relict of the old usage of the workspace variable usage (that Arnaud removed). Later today i will create an jira issue and a patch. (this should not be hard to find). Ritchie nicolas de loof wrote: > Also had this issue since 2.5-SNAPSHOTs, but never took the time to repo

Re: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-03-28 Thread nicolas de loof
Also had this issue since 2.5-SNAPSHOTs, but never took the time to report in Jira :-/ Setting eclipse.projectDir=${basedir} in the POM eclipse-plugin configuration solves this, but this is only a workaround. Nicolas. 2008/3/28, Arnaud HERITIER <[EMAIL PROTECTED]>: > > Hi all, > > I just disco

Re: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-03-28 Thread Stuart McCulloch
On 28/03/2008, nicolas de loof <[EMAIL PROTECTED]> wrote: > > I found the cause of this issue : > > As I added the SysdeoMojo.generate execution to this setup profile, two > plugins (eclipse + sysdeo-tomcat) request for a forked @execute > phase="generate-resources". > > In both case, maven remove

Re: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-03-28 Thread nicolas de loof
I found the cause of this issue : As I added the SysdeoMojo.generate execution to this setup profile, two plugins (eclipse + sysdeo-tomcat) request for a forked @execute phase="generate-resources". In both case, maven remove the requesting plugin from the forked lifecycle to prevent recursive cal

Re: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-03-28 Thread Arnaud HERITIER
On Fri, Mar 28, 2008 at 10:09 AM, nicolas de loof <[EMAIL PROTECTED]> wrote: > I've got an issue with eclipse plugin 2.5 & 2.5.1 combined with latest maven > 2.0.9 RC4 : > > I've set a custom profile in my corporate POM to setup eclipse. It runs the > validate phase and attach eclipse:eclipse pl

Re: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-03-28 Thread Arnaud HERITIER
Hi all, I just discovered a bug, or an hidden feature in 2.5 :-) Richard, I think it is related to MECLIPSE-344. I store my projects in a directory which isn't my eclipse workspace. If I define the workspace attribute to be able to read its settings, when I call eclipse:eclipse, my projec

Re: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-03-28 Thread nicolas de loof
I've got an issue with eclipse plugin 2.5 & 2.5.1 combined with latest maven 2.0.9 RC4 : I've set a custom profile in my corporate POM to setup eclipse. It runs the validate phase and attach eclipse:eclipse plugin goal to this phase. Using this, a fresh SVN checkout can configure eclipse by runnin

Re: [VOTE] Release Maven Eclipse plugin version 2.5.1

2008-03-28 Thread Richard van Nieuwenhoven
Hi, here is my +1 Thanks for the fast release! Ritchie Arnaud HERITIER wrote: > Hi, > > Since the 2.5 release we did 10 days ago, we solved 3 annoying issues: > * [MECLIPSE-266] - plugin applies java facet to ear project > * [MECLIPSE-411] - manifest property usage is only for ogsi m

[VOTE] Release Maven Eclipse plugin version 2.5.1

2008-03-27 Thread Arnaud HERITIER
Hi, Since the 2.5 release we did 10 days ago, we solved 3 annoying issues: * [MECLIPSE-266] - plugin applies java facet to ear project * [MECLIPSE-411] - manifest property usage is only for ogsi maifests * [MECLIPSE-413] - EclipseOSGiManifestWriter uses the artifact id and not the Ec