Re: [RESULT] [VOTE] Release Apache Maven Wrapper Plugin version 3.0.1

2020-06-03 Thread Robert Scholte
Based on https://www.apache.org/dev/licensing-howto.html [https://www.apache.org/dev/licensing-howto.html] it looks like I should add these to the distributions as well, but to me it doesn't make sense to unpack these files into the targeted directory. Robert On 3-6-2020 21:00:47, Christofer Du

Re: [RESULT] [VOTE] Release Apache Maven Wrapper Plugin version 3.0.1

2020-06-03 Thread Christofer Dutz
Well doesn't have to be compatible as long as it does what it's supposed to. Was just asking as I wrote the Downloader to enable Apache projects to use the maven wrapper (No checked in binaries) Unfortunately we always were required to maintain the NOTICE reference that the scripts and the java

Re: [RESULT] [VOTE] Release Apache Maven Wrapper Plugin version 3.0.1

2020-06-03 Thread Robert Scholte
Starting with Maven 3.7.0 there will be 3 wrapper distributions, org.apache.maven:apache-maven-wrapper and with the following classifiers: script: mvnw, mvnw.cmd, mvnwDebug, mvnwDebug.cmd, .mvn/wrapper/maven-wrapper.properties bin: like script, but also .mvn/wrapper/maven-wrapper.jar source: lik

Re: [RESULT] [VOTE] Release Apache Maven Wrapper Plugin version 3.0.1

2020-06-03 Thread Christofer Dutz
Congrats on this ... As the rest is usually just dropping the mwnw scripts, the config file and my downloader.java ... is there an apache package we can now just drop in to replace the old and get rid of the Notice stuff? Chris Am 02.06.20, 22:36 schrieb "Robert Scholte" : Hi, Th

[RESULT] [VOTE] Release Apache Maven Wrapper Plugin version 3.0.1

2020-06-02 Thread Robert Scholte
Hi, The vote has passed with the following result: +1 : Robert Scholte, Romain Manni-Bucau, Olivier Lamy, Hervé BOUTEMY, Maarten Mulders PMC quorum: reached I will promote the artifacts to the central repo. On 30-5-2020 11:17:43, Robert Scholte wrote: Hi, I'd like to do a bootstrap release

Re: [VOTE] Release Apache Maven Wrapper Plugin version 3.0.1

2020-06-01 Thread Maarten Mulders
Tested from behind an enterprise artifact repository, works fine. Wrappers and .mvn/wrapper/wrapper.properties are correctly generated. +1 Maarten On June 2, 2020, at 00:26, Hervé BOUTEMY wrote: ok then +1 Regards, Hervé Le lundi 1 juin 2020, 23:44:07 CEST Robert Scholte a écrit : if you

Re: [VOTE] Release Apache Maven Wrapper Plugin version 3.0.1

2020-06-01 Thread Hervé BOUTEMY
ok then +1 Regards, Hervé Le lundi 1 juin 2020, 23:44:07 CEST Robert Scholte a écrit : > if you call ./mvnw, then you are already beyond the purpose of the plugin. > The maven-wrapper-plugin is about an easy way to download and unpack the > wrapper distribution. What you are facing is an issue

Re: [VOTE] Release Apache Maven Wrapper Plugin version 3.0.1

2020-06-01 Thread Robert Scholte
if you call ./mvnw, then you are already beyond the purpose of the plugin. The maven-wrapper-plugin is about an easy way to download and unpack the wrapper distribution.  What you are facing is an issue in the maven wrapper distribution, hence unrelated to the release of the maven-wrapper-plugin.

Re: [VOTE] Release Apache Maven Wrapper Plugin version 3.0.1

2020-06-01 Thread Hervé BOUTEMY
I fear there is a major issue: I could not make the injected scripts work because of a Windows newline: $ ./mvnw clean --2020-06-01 18:19:55-- https://repository.apache.org/snapshots/org/apache/maven/maven-wrapper/3.7.0-SNAPSHOT/maven-wrapper-3.7.0-20200527.125905-8.jar%0D Resolving repository.

Re: [VOTE] Release Apache Maven Wrapper Plugin version 3.0.1

2020-06-01 Thread Olivier Lamy
+1 On Sat, 30 May 2020 at 19:17, Robert Scholte wrote: > Hi, > > I'd like to do a bootstrap release of the maven-wrapper-plugin, in order > to configure it in the next maven-core. > > We solved 1 issue: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721&version=1234834

Re: [VOTE] Release Apache Maven Wrapper Plugin version 3.0.1

2020-06-01 Thread Romain Manni-Bucau
+1 (non binding) Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn | Book

Re: [VOTE] Release Apache Maven Wrapper Plugin version 3.0.1

2020-06-01 Thread Robert Scholte
+1 On 30-5-2020 11:17:43, Robert Scholte wrote: Hi, I'd like to do a bootstrap release of the maven-wrapper-plugin, in order to configure it in the next maven-core.  We solved 1 issue: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721&version=12348346&styleName=Text T

[VOTE] Release Apache Maven Wrapper Plugin version 3.0.1

2020-05-30 Thread Robert Scholte
Hi, I'd like to do a bootstrap release of the maven-wrapper-plugin, in order to configure it in the next maven-core.  We solved 1 issue: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721&version=12348346&styleName=Text There are no issues in JIRA: https://issues.apache.o