[RESULT] [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0 (take 3)

2017-12-06 Thread Robert Scholte
Hi, The vote has passed with the following result: +1 : Mark Raynsford, Robert Scholte, Hervé BOUTEMY, Olivier Lamy PMC quorum: reached I will promote the artifacts to the central repo. On Sun, 03 Dec 2017 22:50:42 +0100, Robert Scholte wrote: Hi, We solved 27 issues: https://issues.ap

Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0 (take 3)

2017-12-06 Thread Olivier Lamy
+1 On 4 December 2017 at 08:50, Robert Scholte wrote: > Hi, > > We solved 27 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje > ctId=12317529&version=12330875&styleName=Text > > There are still a couple of issues left in JIRA: > https://issues.apache.org/jira/issues/?jql=pr

Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0 (take 3)

2017-12-05 Thread Hervé BOUTEMY
+1 tried to reproduce the build and check the result with diffoscope: just found know little files dates noise Regards, Hervé Le dimanche 3 décembre 2017, 22:50:42 CET Robert Scholte a écrit : > Hi, > > We solved 27 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12

Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0 (take 3)

2017-12-05 Thread Robert Scholte
+1 On Sun, 03 Dec 2017 22:50:42 +0100, Robert Scholte wrote: Hi, We solved 27 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317529&version=12330875&styleName=Text There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=proje

Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0 (take 3)

2017-12-03 Thread Mark Raynsford
On 2017-12-03T22:50:42 +0100 "Robert Scholte" wrote: > > We solved 27 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317529&version=12330875&styleName=Text > +1 (non-binding) Pretty heavily tested on multiple projects. Both the javadoc and aggregation goals have be

[VOTE] Release Apache Maven Javadoc Plugin version 3.0.0 (take 3)

2017-12-03 Thread Robert Scholte
Hi, We solved 27 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317529&version=12330875&styleName=Text There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%2012317529%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%2

[CANCELED] [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0 (take 2)

2017-11-21 Thread Robert Scholte
I'm going to cancel this vote. The modules + aggregators is a valid find and it is quite easy to fix. I'd prefer to add it for 3.0.0, otherwise others will hit it too. Robert On Sat, 18 Nov 2017 16:10:34 +0100, Robert Scholte wrote: Hi, We solved 27 issues: https://issues.apache.org/jira

Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0 (take 2)

2017-11-18 Thread Robert Scholte
that works because OpenJDK uses module-source-path, i.e. src//<*.java> Maven uses source-path because it matches exactly one module , i.e. src/main/java/<*.java> Aggregator for modules requires to make use of module-source-paths. I guess we need to consider to make use of symbolic links :( t

Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0 (take 2)

2017-11-18 Thread Mark Raynsford
On 2017-11-18T17:44:23 +0100 Hervé BOUTEMY wrote: > JDK javadoc seems to cover the "aggregated javadocs" scenario: in Java 9 > terms, that's "multi-modules" = exactly the case for JDK 9 javadoc [1] > I don't know what's the command line to produce this, but looks feasible from > javadoc side >

Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0 (take 2)

2017-11-18 Thread Hervé BOUTEMY
JDK javadoc seems to cover the "aggregated javadocs" scenario: in Java 9 terms, that's "multi-modules" = exactly the case for JDK 9 javadoc [1] I don't know what's the command line to produce this, but looks feasible from javadoc side Regards, Hervé [1] https://docs.oracle.com/javase/9/docs/ap

Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0 (take 2)

2017-11-18 Thread Hervé BOUTEMY
Le samedi 18 novembre 2017, 17:18:06 CET Mark Raynsford a écrit : > On 2017-11-18T16:14:04 + > > Mark Raynsford wrote: > > Presumably, with the module-info.java files > > excluded, it reverts back to plain classpath style JavaDoc. > > Actually, it results in sort of weird looking JavaDoc tha

Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0 (take 2)

2017-11-18 Thread Mark Raynsford
On 2017-11-18T16:14:04 + Mark Raynsford wrote: > Presumably, with the module-info.java files > excluded, it reverts back to plain classpath style JavaDoc. Actually, it results in sort of weird looking JavaDoc that only contains a single module, and claims that all packages are in that module:

Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0 (take 2)

2017-11-18 Thread Mark Raynsford
On 2017-11-18T17:04:12 +0100 "Robert Scholte" wrote: > That's similar to MJAVADOC-479[1] > > Seems like all Java 9 issues are not resolved yet. > I don't mind canceling the vote if we can fix this as well. > > thanks, > Robert > > [1] https://issues.apache.org/jira/browse/MJAVADOC-479 Yeah, t

Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0 (take 2)

2017-11-18 Thread Robert Scholte
That's similar to MJAVADOC-479[1] Seems like all Java 9 issues are not resolved yet. I don't mind canceling the vote if we can fix this as well. thanks, Robert [1] https://issues.apache.org/jira/browse/MJAVADOC-479 On Sat, 18 Nov 2017 16:57:36 +0100, Mark Raynsford wrote: Hello! I'd lik

Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0 (take 2)

2017-11-18 Thread Mark Raynsford
Hello! I'd like to vote on this issue, but I still have a remaining problem and am not sure if it's because the plugin is broken due to the new module changes, or just because my project setup is slightly unusual. See here: https://github.com/io7m/maven-javadoc-bug-20171118 The "c" module attem

[VOTE] Release Apache Maven Javadoc Plugin version 3.0.0 (take 2)

2017-11-18 Thread Robert Scholte
Hi, We solved 27 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317529&version=12330875&styleName=Text There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%2012317529%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%2

[CANCELED] [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0

2017-11-18 Thread Robert Scholte
Issue found related to a Maven multimodule projects and Java 9 module descriptors. This needs to be fixed for 3.0.0. thanks, Robert On Fri, 17 Nov 2017 18:37:16 +0100, Robert Scholte wrote: Hi, We solved 26 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=123175

Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0

2017-11-18 Thread Robert Scholte
Hi Mark, thanks for testing. I can confirm the problem. I'll cancel the vote and roll out another release based on your patch. thanks, Robert On Sat, 18 Nov 2017 12:46:51 +0100, Mark Raynsford wrote: On 2017-11-17T19:00:54 + Mark Raynsford wrote: -1 (non-binding) The staged versio

Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0

2017-11-18 Thread Mark Raynsford
On 2017-11-17T19:00:54 + Mark Raynsford wrote: > -1 (non-binding) > > The staged version still fails with a basic module setup: > > https://github.com/io7m/maven-javadoc-bug-20171117 I've submitted a PR that I believe fixes the issue, but I'm not sure if it's already too late to get it i

Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0

2017-11-17 Thread Mark Raynsford
-1 (non-binding) The staged version still fails with a basic module setup: https://github.com/io7m/maven-javadoc-bug-20171117 -- Mark Raynsford | http://www.io7m.com pgpI76h0Nsf03.pgp Description: OpenPGP digital signature

[VOTE] Release Apache Maven Javadoc Plugin version 3.0.0

2017-11-17 Thread Robert Scholte
Hi, We solved 26 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317529&version=12330875&styleName=Text There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%2012317529%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%2

Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0-M1

2017-07-21 Thread Robert Scholte
Hi, The vote has passed with the following result: +1 : Peter Ansell, Olivier Lamy, Anders Hammar, Hervé BOUTEMY, Robert Scholte PMC quorum: reached I will promote the artifacts to the central repo. On Mon, 17 Jul 2017 22:05:42 +0200, Robert Scholte wrote: Hi, We solved 18 issues:

Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0-M1

2017-07-21 Thread Robert Scholte
+1 On Mon, 17 Jul 2017 22:05:42 +0200, Robert Scholte wrote: Hi, We solved 18 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317529&version=12330875&styleName=Text There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=proje

Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0-M1

2017-07-20 Thread Hervé BOUTEMY
+1 Regards, Hervé Le lundi 17 juillet 2017, 22:05:42 CEST Robert Scholte a écrit : > Hi, > > We solved 18 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317529&ve > rsion=12330875&styleName=Text > > There are still a couple of issues left in JIRA: > https://issues

Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0-M1

2017-07-20 Thread Anders Hammar
+1 Tested with Maven 3.3.3 and IBM JDK 7.1 on Windows 7. /Anders On Mon, Jul 17, 2017 at 10:05 PM, Robert Scholte wrote: > Hi, > > We solved 18 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje > ctId=12317529&version=12330875&styleName=Text > > There are still a couple of

Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0-M1

2017-07-19 Thread Olivier Lamy
+1 On 18 July 2017 at 06:05, Robert Scholte wrote: > Hi, > > We solved 18 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje > ctId=12317529&version=12330875&styleName=Text > > There are still a couple of issues left in JIRA: > https://issues.apache.org/jira/issues/?jql=proje

Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0-M1

2017-07-17 Thread Peter Ansell
+1 Checksum for the source release matches the given sha1. Plugin works as intended to create valid site (javadoc:javadoc) and javadoc jars (javadoc:jar) using both JDK-8u131 and JDK-9b177 Only question is whether the Release Notes page on the staging site is intentionally empty at this point in

[VOTE] Release Apache Maven Javadoc Plugin version 3.0.0-M1

2017-07-17 Thread Robert Scholte
Hi, We solved 18 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317529&version=12330875&styleName=Text There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%2012317529%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%2