Re[2]: [VOTE] Release Apache Maven Javadoc Plugin version 2.10.4

2016-07-08 Thread Richard Sand
obert Scholte" To: "Maven Developers List" Sent: 6/29/2016 1:34:19 PM Subject: Re: [VOTE] Release Apache Maven Javadoc Plugin version 2.10.4 Let's start with a simple segment: don't update the file if there are no changes. That's an isolated issue. You suggestion is

Re: Re[2]: [VOTE] Release Apache Maven Javadoc Plugin version 2.10.4

2016-06-29 Thread Robert Scholte
6/29/2016 1:34:19 PM Subject: Re: [VOTE] Release Apache Maven Javadoc Plugin version 2.10.4 Let's start with a simple segment: don't update the file if there are no changes. That's an isolated issue. You suggestion is to do a String compare, which seems to me quite expensiv

Re[2]: [VOTE] Release Apache Maven Javadoc Plugin version 2.10.4

2016-06-29 Thread Richard Sand
OK I can do that, agreed that is an isolated change. Should I go off the trunk or the 2.10.4 tag? -Richard -- Original Message -- From: "Robert Scholte" To: "Maven Developers List" Sent: 6/29/2016 1:34:19 PM Subject: Re: [VOTE] Release Apache Maven Javadoc P

Re: [VOTE] Release Apache Maven Javadoc Plugin version 2.10.4

2016-06-29 Thread Robert Scholte
Let's start with a simple segment: don't update the file if there are no changes. That's an isolated issue. You suggestion is to do a String compare, which seems to me quite expensive with large files. Instead I would introduce a changed-flag. AFAIK all rewriting methods are now void-methods.

Re: [VOTE] Release Apache Maven Javadoc Plugin version 2.10.4

2016-06-28 Thread Richard Sand
Hi Maven Developers - now that Javadoc plugin 2.10.4 is released and work has commenced on the 3.0 version, can we revisit the patch I submitted for MJAVADOC-452? Its difficult to break the patch into smaller patches because most of the fixes are interrelated, but I'd be happy to recreate the

[RESULT] [VOTE] Release Apache Maven Javadoc Plugin version 2.10.4

2016-06-10 Thread Robert Scholte
Hi, The vote has passed with the following result: +1 : Karl Heinz Marbaise, Hervé BOUTEMY, Robert Scholte PMC quorum: reached I will promote the artifacts to the central repo. On Tue, 07 Jun 2016 20:39:52 +0200, Robert Scholte wrote: Hi, We solved 12 issues: https://issues.apache.org

Re: [VOTE] Release Apache Maven Javadoc Plugin version 2.10.4

2016-06-10 Thread Robert Scholte
+1 On Tue, 07 Jun 2016 20:39:52 +0200, Robert Scholte wrote: Hi, We solved 12 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317529&version=12331967&styleName=Text There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=proje

Re: [VOTE] Release Apache Maven Javadoc Plugin version 2.10.4

2016-06-09 Thread Hervé BOUTEMY
+1 Regards, Hervé Le mardi 7 juin 2016 20:39:52 Robert Scholte a écrit : > Hi, > > We solved 12 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317529&ve > rsion=12331967&styleName=Text > > There are still a couple of issues left in JIRA: > https://issues.apache.or

Re: [VOTE] Release Apache Maven Javadoc Plugin version 2.10.4

2016-06-09 Thread Karl Heinz Marbaise
Hi, +1 from me. On 6/7/16 8:39 PM, Robert Scholte wrote: Hi, We solved 12 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317529&version=12331967&styleName=Text There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%

Re: [VOTE] Release Apache Maven Javadoc Plugin version 2.10.4

2016-06-08 Thread Richard Sand
Hi Robert, For the skip parameter, the test is very simple. Usage of the fix goal without disabling CLIRR will result in a loop where fix invokes clirr, and clirr runs fix. I understand your reticence about this skip option - but in scenarios where one wants to have the plugin execute automa

Re: [VOTE] Release Apache Maven Javadoc Plugin version 2.10.4

2016-06-08 Thread Robert Scholte
Hi Richard, this release is to push the final 2.x version before moving to a pure Maven 3 implementation (there were quite some fixed issues waiting to be released). Once released I will continue, also including some Java9 related improvements. That will give me enough time to go through yo

Re: [VOTE] Release Apache Maven Javadoc Plugin version 2.10.4

2016-06-07 Thread Richard Sand
The patch I supplied for MJAVADOC-452, 451, 434 and 420 won't be considered for inclusion? I can recreate the patch off of the latest trunk if it would help Best regards, Richard Sent from my iPhone > On Jun 7, 2016, at 2:39 PM, Robert Scholte wrote: > > Hi, > > We solved 12 issues: > htt

[VOTE] Release Apache Maven Javadoc Plugin version 2.10.4

2016-06-07 Thread Robert Scholte
Hi, We solved 12 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317529&version=12331967&styleName=Text There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%2012317529%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%2