[RESULT] [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.2

Hi, The vote has passed with the following result: +1 : Tibor Digana, Romain Manni-Bucau, Benjamin Marwell,Mark Struberg, Hervé BOUTEMY, Enrico Olivelli, Sylwester Lachiewicz -1: Elliotte Rusty Harold PMC quorum: reached I will promote the artifacts to the central repo. ---

Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.2

+1 Sylwester niedz., 24 sty 2021 o 13:33 Benjamin Marwell napisał(a): > > [X] +1 (non binding) > > sha512 is correct for me > Works in a sample project. > > Am So., 24. Jan. 2021 um 00:02 Uhr schrieb Sylwester Lachiewicz > : > > > > Hi, > > > > We solved 5 issues: > > https://issues.apache.org/ji

Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.2

+1 Enrico Il giorno mer 27 gen 2021 alle ore 00:51 Hervé BOUTEMY < herve.bout...@free.fr> ha scritto: > +1 > > checked that the build is reproducible, built with JDK 11 on Windows > > Regards, > > Hervé > > Le dimanche 24 janvier 2021, 00:02:19 CET Sylwester Lachiewicz a écrit : > > Hi, > > > >

Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.2

+1 checked that the build is reproducible, built with JDK 11 on Windows Regards, Hervé Le dimanche 24 janvier 2021, 00:02:19 CET Sylwester Lachiewicz a écrit : > Hi, > > We solved 5 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317223&ve > rsion=12347024&styleNam

Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.2

+1 LieGrue,strub On Sunday, 24 January 2021, 00:02:35 CET, Sylwester Lachiewicz wrote: Hi, We solved 5 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317223&version=12347024&styleName=Text There are still a couple of issues left in JIRA: https://issues.apa

Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.2

Depends. But good catch anyway. Offending line: && file.equals( violation.file ) The only field without null check in the constructor or using Objects.equals. Can there be a violation without a file though? Ie outside a file? If not, let's "fix" it in the next release. On Sun, 24 Jan 2

Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.2

There's at least one NullPointerException in the new Violation class's equals method, possibly others. I'm -1. package org.apache.maven.plugins.checkstyle; import org.junit.Assert; import org.junit.Test; public class ViolationTest { @Test public void testEquals() { Violation v1

Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.2

[X] +1 (non binding) sha512 is correct for me Works in a sample project. Am So., 24. Jan. 2021 um 00:02 Uhr schrieb Sylwester Lachiewicz : > > Hi, > > We solved 5 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317223&version=12347024&styleName=Text > > There are stil

Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.2

+1 (non binding) Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn | Book

Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.2

+1 Cheers Tibor On Sun, Jan 24, 2021 at 12:02 AM Sylwester Lachiewicz < slachiew...@apache.org> wrote: > Hi, > > We solved 5 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317223&version=12347024&styleName=Text > > There are still a couple of issues left in JIRA:

[VOTE] Release Apache Maven Checkstyle Plugin version 3.1.2

Hi, We solved 5 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317223&version=12347024&styleName=Text There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%20MCHECKSTYLE%20AND%20resolution%20%3D%20Unresolved%20ORDER%2