Re: [VOTE] Maven 3.3.8

2015-11-03 Thread Stephen Connolly
git;a=blobdiff;f=maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java;h=3bddfd329ba3b7c584f54a75e5d27bd829b9b56c;hp=ab00fef6d533c03a8e7bafc714450a663f320518;hb=618e62dd3315b4cb5b0f7dcdd37fc787c44b2ade;hpb=b9cc9c3652d43f0efce36d57c0ec1de35d4e7c56 >>>>> whic

Re: [VOTE] Maven 3.3.8

2015-11-03 Thread Jason van Zyl
618e62dd3315b4cb5b0f7dcdd37fc787c44b2ade;hpb=b9cc9c3652d43f0efce36d57c0ec1de35d4e7c56 >>>> which certainly does not affect this code at all >>>> >>>> On 2 November 2015 at 14:49, Robert Scholte >>> wrote: >>>>> IIRC, somebody provided a patch to remove this if-stateme

Re: [VOTE] Maven 3.3.8

2015-11-03 Thread Jason van Zyl
cc9c3652d43f0efce36d57c0ec1de35d4e7c56 >>> which certainly does not affect this code at all >>> >>> On 2 November 2015 at 14:49, Robert Scholte >> wrote: >>>> IIRC, somebody provided a patch to remove this if-statement. Not sure >> if it was applied

Re: [VOTE] Maven 3.3.8

2015-11-03 Thread Mark Derricutt
f it was applied. > >> > >> Robert > >> > >> Verzonden vanaf Samsung Mobile. > >> > >> Oorspronkelijk bericht Van: Stephen > Connolly Datum:02-11-2015 04:18 > (GMT-08:00) Aan: Maven Developers

Re: [VOTE] Maven 3.3.8

2015-11-02 Thread Kristian Rosenvold
rt Scholte > wrote: > >> IIRC, somebody provided a patch to remove this if-statement. Not sure > if it was applied. > >> > >> Robert > >> > >> Verzonden vanaf Samsung Mobile. > >> > >> Oorspronkelijk bericht Van: Stephen > Con

Re: [VOTE] Maven 3.3.8

2015-11-02 Thread Jason van Zyl
Oorspronkelijk bericht Van: Stephen >> Connolly Datum:02-11-2015 04:18 >> (GMT-08:00) Aan: Maven Developers List >> Onderwerp: Re: [VOTE] Maven 3.3.8 >> https://git1-us-west.apache.org/repos/asf?p=maven.git;a=commit;h=19532849 >> is the fix >> >> On

Re: [VOTE] Maven 3.3.8

2015-11-02 Thread Stephen Connolly
rt > > Verzonden vanaf Samsung Mobile. > > Oorspronkelijk bericht Van: Stephen Connolly > Datum:02-11-2015 04:18 > (GMT-08:00) Aan: Maven Developers List > Onderwerp: Re: [VOTE] Maven 3.3.8 > https://git1-us-west.apache.org/repos/asf?p=maven.git;a=commit;h=1

Re: [VOTE] Maven 3.3.8

2015-11-02 Thread Robert Scholte
IIRC, somebody provided a patch to remove this if-statement. Not sure if it was applied. Robert Verzonden vanaf Samsung Mobile. Oorspronkelijk bericht Van: Stephen Connolly Datum:02-11-2015 04:18 (GMT-08:00) Aan: Maven Developers List Onderwerp: Re: [VOTE] Maven 3.3.8

Re: [VOTE] Maven 3.3.8

2015-11-02 Thread Stephen Connolly
https://git1-us-west.apache.org/repos/asf?p=maven.git;a=commit;h=19532849 is the fix On 2 November 2015 at 12:05, Stephen Connolly wrote: > -1 technical > > mng5840ParentVersionRanges(ParentRangeRelativePathPointsToWrongVersion)OK > (5.6 s) > mng5840ParentVersionRanges(ParentRangeRelativePathPoin

Re: [VOTE] Maven 3.3.8

2015-11-02 Thread Stephen Connolly
-1 technical mng5840ParentVersionRanges(ParentRangeRelativePathPointsToWrongVersion)OK (5.6 s) mng5840ParentVersionRanges(ParentRangeRelativePathPointsToCorrectVersion)OK (0.4 s) mng5840RelativePathReactorMatching(RelativePathPointsToWrongVersion)FAILURE (0.4 s) On 2 November 2015 at 11:48, Ste

Re: [VOTE] Maven 3.3.8

2015-11-02 Thread Stephen Connolly
Hmmm I may have to change my vote, looking like there is a regression on the MNG-5840 fix from 3.3.6-SNAPSHOT On 30 October 2015 at 17:38, Stephen Connolly wrote: > +1 technical - works on my critical big build > +1 legal umbrella - on the diff of this since 3.3.7 (thankfully only 1 > commit to r

Re: [VOTE] Maven 3.3.8

2015-11-01 Thread Hervé BOUTEMY
+1 using it without any issue notice I updated LATEST site http://maven.apache.org/ref/3-LATEST/ (just using deploySite.sh script) Regards, Hervé Le vendredi 30 octobre 2015 09:58:11 Jason van Zyl a écrit : > Hi, > > Time to release Maven 3.3.8! > > Here is a link to the issues resolved: > ht

Re: [VOTE] Maven 3.3.8

2015-11-01 Thread Mark Derricutt
On 31 Oct 2015, at 5:58, Jason van Zyl wrote: > Vote open for 72 hours. +1 here. Looking good from my builds... -- Mark Derricutt http://www.theoryinpractice.net http://www.chaliceofblood.net http://plus.google.com/+MarkDerricutt http://twitter.com/talios http://facebook.com/mderricutt sign

Re: [VOTE] Maven 3.3.8

2015-10-31 Thread Mirko Friedenhagen
+1 non-binding, tested with some projects. Regards Mirko -- http://illegalstateexception.blogspot.com/ https://github.com/mfriedenhagen/ (http://osrc.dfm.io/mfriedenhagen) https://bitbucket.org/mfriedenhagen/ On Fri, Oct 30, 2015 at 10:26 PM, Arnaud Héritier wrote: > +1 > > On Fri, Oct 30, 2015

Re: [VOTE] Maven 3.3.8

2015-10-30 Thread Arnaud Héritier
+1 On Fri, Oct 30, 2015 at 6:38 PM, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > +1 technical - works on my critical big build > +1 legal umbrella - on the diff of this since 3.3.7 (thankfully only 1 > commit to review there ;-) > > -Stephen > > On 30 October 2015 at 17:01, Jason

Re: [VOTE] Maven 3.3.8

2015-10-30 Thread Tamás Cservenák
+1 beer, again On Fri, Oct 30, 2015 at 7:38 PM Igor Fedorenko wrote: > +1 > > -- > Regards, > Igor > > On Fri, Oct 30, 2015, at 12:58 PM, Jason van Zyl wrote: > > Hi, > > > > Time to release Maven 3.3.8! > > > > Here is a link to the issues resolved: > > > https://issues.apache.org/jira/secure/R

Re: [VOTE] Maven 3.3.8

2015-10-30 Thread Igor Fedorenko
+1 -- Regards, Igor On Fri, Oct 30, 2015, at 12:58 PM, Jason van Zyl wrote: > Hi, > > Time to release Maven 3.3.8! > > Here is a link to the issues resolved: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12333074 > > Staging repo: > https://repository.apa

Re: [VOTE] Maven 3.3.8

2015-10-30 Thread Stephen Connolly
+1 technical - works on my critical big build +1 legal umbrella - on the diff of this since 3.3.7 (thankfully only 1 commit to review there ;-) -Stephen On 30 October 2015 at 17:01, Jason van Zyl wrote: > +1 > > Analyzing release validity... > > stagingUrl: https://repository.apache.org/content/

Re: [VOTE] Maven 3.3.8

2015-10-30 Thread Jason van Zyl
+1 Analyzing release validity... stagingUrl: https://repository.apache.org/content/repositories/maven-1230 groupId: org.apache.maven artifactId: apache-maven version: 3.3.8 Source ZIP url exists. https://repository.apache.org/content/repositories/maven-1230/org/apache/maven/apache-maven/3.3.8/ap

[VOTE] Maven 3.3.8

2015-10-30 Thread Jason van Zyl
Hi, Time to release Maven 3.3.8! Here is a link to the issues resolved: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12333074 Staging repo: https://repository.apache.org/content/repositories/maven-1230/ The distributable binaries and sources for testing can