Re: [QUESTION] maven-resolver verbosity

2023-04-28 Thread Alexey Venderov
Hi Tamás, Looks great! Thank you for the lightning-fast fix! Best regards, Alexey Venderov mailto: avende...@gmail.com On Fri, Apr 28, 2023 at 1:47 PM Tamás Cservenák wrote: > This is now the output I get with Maven 3.9.2-SNAPSHOT (that contains > patched 1.9.10-SNAPSHOT of resolver): > > [cs

Re: [QUESTION] maven-resolver verbosity

2023-04-28 Thread Tamás Cservenák
This is now the output I get with Maven 3.9.2-SNAPSHOT (that contains patched 1.9.10-SNAPSHOT of resolver): [cstamas@urnebes simple-maven-project (verbose-graph)]$ mvn -V -Daether.conflictResolver.verbose dependency:tree Apache Maven 3.9.2-SNAPSHOT (19eb566c58314249c2006f6749c4a29e56f3e094) Maven

Re: [QUESTION] maven-resolver verbosity

2023-04-28 Thread Tamás Cservenák
Howdy, :beer: (or any other award you'd like, :wine:?) Thanks for spotting and reporting this. Yes, there is a problem. Created issue https://issues.apache.org/jira/browse/MRESOLVER-357 In short, the problem lies here: https://github.com/apache/maven-resolver/blob/maven-resolver-1.9.9/maven-res

Re: [QUESTION] maven-resolver verbosity

2023-04-28 Thread Alexey Venderov
Tamás, Thank you for the detailed explanation! One more question regarding the verbose mode in the old implementation vs. the new implementation. I have this simple project https://github.com/c00ler/simple-maven-project/tree/verbose-graph (all the relevant code in the verbose-graph branch) where

Re: [QUESTION] maven-resolver verbosity

2023-04-25 Thread Tamás Cservenák
Sorry, series of lapsues: so, verbose modes are: NONE, STANDARD and FULL. Wherever I wrote "DEFAULT" I meant "STANDARD" instead. The enum in question: /** * The enum representing verbosity levels of conflict resolver. * * @since 1.9.8 */ public enum Verbosity {

Re: [QUESTION] maven-resolver verbosity

2023-04-25 Thread Tamás Cservenák
Howdy, 1. Historically (and today) users (and client code needing verbose tree, like enforcer convergence rule) sets `aether.conflictResolver.verbose=true` in config properties of resolver session. Again, as this may happen by user on CLI, or in code, like plugins, this part is unchanged. And as

[QUESTION] maven-resolver verbosity

2023-04-25 Thread Alexey Venderov
Hi, I have a couple of questions regarding the recent changes to how *aether.conflictResolver.verbose* property is set: https://github.com/apache/maven-resolver/blob/master/maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/transformer/ConflictResolver.java#L106 . 1. To be able to se