Re: [PROPOSAL] Java 5 Annotations for Plugins

2011-11-07 Thread Ansgar Konermann
Am 07.11.2011 16:31 schrieb "Jesse Glick" : > I do not think Phase should be an enum, just a list of String constants - you are permitted to define alternative lifecycles, right? > New lifecycles: yes, possible (i. e.: which action to perform in which phase). New lifecycle *phases*: no, not to my

Re: [PROPOSAL] Java 5 Annotations for Plugins

2011-11-07 Thread Jason van Zyl
There is code here which I will propose as a candidate of part of what I call Tesla. I hope that this can be integrated into Maven: https://github.com/etesla/tesla-plugin-api On Nov 7, 2011, at 10:30 AM, Jesse Glick wrote: > On 11/04/2011 07:13 AM, Stephen Connolly wrote: >> you generate a clas

Re: [PROPOSAL] Java 5 Annotations for Plugins

2011-11-07 Thread Jesse Glick
On 11/04/2011 07:13 AM, Stephen Connolly wrote: you generate a class that extends AbstractMojo, has the required injection fields for all the @parameters and has an execute method that passes through all the injection fields and then invokes the required method. By the way this (as well as Help

Re: [PROPOSAL] Java 5 Annotations for Plugins

2011-11-04 Thread Stephen Connolly
to clarify what I mean, you generate a class that extends AbstractMojo, has the required injection fields for all the @parameters and has an execute method that passes through all the injection fields and then invokes the required method. On 4 November 2011 11:11, Stephen Connolly wrote: > Syntet

Re: [PROPOSAL] Java 5 Annotations for Plugins

2011-11-04 Thread Stephen Connolly
Syntetic bridging classes solves that issue and keeps 2.2.1 compat (as 2.0.x is JDK 1.4) On 4 November 2011 11:09, Olivier Lamy wrote: > Hello, > > Things like below will need some changes in core, IMHO we need to be > compliant with core 2.x and 3.x : > >  @Goal(name="foo") >  public void doExec

Re: [PROPOSAL] Java 5 Annotations for Plugins

2011-11-04 Thread Olivier Lamy
Hello, Things like below will need some changes in core, IMHO we need to be compliant with core 2.x and 3.x : @Goal(name="foo") public void doExecuteGoal() { // equiv of AbstractMojo.execute without requiring the interface } @Goal(name="bar") public void doOtherExecuteGoal() {

Re: [PROPOSAL] Java 5 Annotations for Plugins

2011-11-04 Thread Mark Derricutt
+3 ( why does every only +1 on these things - this aint Google folks! ). Love the last example with multiple @Goal annotations on methods. -- "Great artists are extremely selfish and arrogant things" — Steven Wilson, Porcupine Tree On Fri, Nov 4, 2011 at 11:49 PM, Simone Tripodi wrote: > +1 t

Re: [PROPOSAL] Java 5 Annotations for Plugins

2011-11-04 Thread Simone Tripodi
+1 to Stephen's comment, that looks even better! Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Fri, Nov 4, 2011 at 11:09 AM, Stephen Connolly wrote: > added a comment > > On 3 November 2011 23:18,

Re: [PROPOSAL] Java 5 Annotations for Plugins

2011-11-04 Thread Stephen Connolly
added a comment On 3 November 2011 23:18, Hervé BOUTEMY wrote: > Hi, > > I reworked on Java 5 Annotations for Plugins proposal started a while ago: [1] > > Before going deeper into code, I'd like to have some review of the proposed > form of the tool. Any comment is welcome. > > Regards, > > Herv

Re: [PROPOSAL] Java 5 Annotations for Plugins

2011-11-04 Thread Simone Tripodi
Salut Hervé! I developed a Maven plugin only once[1] but I would loved to use those annotations instead of Javadoc. The benefits I would have got are exactly the ones you described in the Wiki - IMHO this work has to be part of a required innovation in therms of simplification of plugin development

[PROPOSAL] Java 5 Annotations for Plugins

2011-11-03 Thread Hervé BOUTEMY
Hi, I reworked on Java 5 Annotations for Plugins proposal started a while ago: [1] Before going deeper into code, I'd like to have some review of the proposed form of the tool. Any comment is welcome. Regards, Hervé [1] https://cwiki.apache.org/confluence/display/MAVEN/Java+5+Annotations+fo