GitHub user ChristianSchulte opened a pull request:
https://github.com/apache/maven/pull/141
[MNG-6164] Collections inconsistently immutable.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ChristianSchulte/maven MNG-6164
Am 2017-05-28 um 20:55 schrieb Hervé BOUTEMY:
Le dimanche 28 mai 2017, 19:50:03 CEST Michael Osipov a écrit :
How many cases are changed? In which areas of Maven API?
That is the information I need to vote for this change, knowing the
effective impact it will have
As far as I can see for the c
Using immutable collections in Maven was exactly my advice in 2013/2014.
Usually it is bad to share collections especially when using concurrent
Threads.
Normally there should be service methods which change some object state
*safely* or thread safe. Personally I think plugins will break with
immut
Le dimanche 28 mai 2017, 19:50:03 CEST Michael Osipov a écrit :
> > How many cases are changed? In which areas of Maven API?
> > That is the information I need to vote for this change, knowing the
> > effective impact it will have
>
> As far as I can see for the changes, they all look like read-on
Am 2017-05-28 um 13:01 schrieb Hervé BOUTEMY:
I'm not confident on this one.
I understand the inconsistency issue, that may lead to edge-case issues in
plugins or extensions (that unexpectedly get an immutable empty list when they
usually get a modifiable non-empty list)
Is it the right solutio
I started to review each modification in depth and write a summary, but I
stopped since I know nobody will read it because of TLDR;
I preferred rewrite the issue description as:
"All those methods should return a collection with consistent "mutability":
either mutable, either immutable.
Given e
I think we should do this step, either now or with a next major release.
And it's about the *returned* Lists which now become unmodifiable. As far
as I can see all these changes have a setter which should be used to
specify a new list.
These changes should protect developers which use the ret
I'm not confident on this one.
I understand the inconsistency issue, that may lead to edge-case issues in
plugins or extensions (that unexpectedly get an immutable empty list when they
usually get a modifiable non-empty list)
Is it the right solution to change every non-empty list to immutable?
+1
Robert
On Sun, 28 May 2017 12:01:20 +0200, Michael Osipov
wrote:
Am 2017-05-25 um 21:12 schrieb Michael Osipov:
Who seconds MNG-6164 for 3.5.1?
This is a non-functional consistency fix. All ITs pass.
Anyone?
-
To
Am 2017-05-25 um 21:12 schrieb Michael Osipov:
Who seconds MNG-6164 for 3.5.1?
This is a non-functional consistency fix. All ITs pass.
Anyone?
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional command
Who seconds MNG-6164 for 3.5.1?
This is a non-functional consistency fix. All ITs pass.
Michael
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
11 matches
Mail list logo
