Github user asfgit closed the pull request at:
https://github.com/apache/maven/pull/45
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enable
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/45#issuecomment-97418800
Thanks for the clarification. I'm not too concerned about not being able to
@Inject SLFJ loggers any longer but we can't break components that might be
doing it.
---
If y
Github user mcculls commented on the pull request:
https://github.com/apache/maven/pull/45#issuecomment-97418554
To be absolutely clear:
* injection of SLF4J loggers using `@Inject` is not supported in the
official Guice library
* injection of SLF4J loggers using `@Requirement`
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/45#issuecomment-97413566
To be clear are you saying that the injection of loggers is not supported
with Guice 4? I don't think it's used much but I believe it is used. Yes, I
have been using the st
Github user mcculls commented on the pull request:
https://github.com/apache/maven/pull/45#issuecomment-97376230
The only difference remaining between this and sisu-guice is support for
`@Inject`ion of SLF4J loggers, but I don't believe that's used much, if at all.
Personally these da
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/45#issuecomment-97274498
Would be a nice change. Anything of note we should be concerned about
API/SPI, or performance wise?
---
If your project is set up for it, you can reply to this email and h
GitHub user mcculls opened a pull request:
https://github.com/apache/maven/pull/45
Switch to official Guice 4.0
For anyone interested in using Guice 4.0 with Maven :)
PS. you should use Eclipse/Sisu 0.3.1 with Guice 4.0, luckily master branch
is already using that version
