[GitHub] maven pull request: MNG-5786: Fix edge case in determining maven.m...

2015-09-14 Thread Stephan202
Github user Stephan202 closed the pull request at: https://github.com/apache/maven/pull/40 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] maven pull request: MNG-5786: Fix edge case in determining maven.m...

2015-09-14 Thread Stephan202
Github user Stephan202 commented on the pull request: https://github.com/apache/maven/pull/40#issuecomment-140189697 A variation on the proposed fix was merged in #58. So I'll close this PR. (I'll also delete by branch/fork, but the diff can still be viewed in [MNG-5786](https

[GitHub] maven pull request: MNG-5786: Fix edge case in determining maven.m...

2015-04-05 Thread ifedorenko
Github user ifedorenko commented on the pull request: https://github.com/apache/maven/pull/40#issuecomment-89838717 @Stephan202 what is your usecase for having multiple maven or jvm options for the same codebase? Is this to support svn (and similar) repositories that effectively host

[GitHub] maven pull request: MNG-5786: Fix edge case in determining maven.m...

2015-04-05 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/40#issuecomment-89769509 I'll take a look at try to incorporate into the 3.3.2 release which I'd like to get our next week. --- If your project is set up for it, you can reply to this email and ha

[GitHub] maven pull request: MNG-5786: Fix edge case in determining maven.m...

2015-04-05 Thread Stephan202
Github user Stephan202 commented on the pull request: https://github.com/apache/maven/pull/40#issuecomment-89738913 I can't seem to comment on [MNG-5786](https://jira.codehaus.org/browse/MNG-5786) anymore (comment button missing), presumably because of the impending Codehaus shutdown.

[GitHub] maven pull request: MNG-5786: Fix edge case in determining maven.m...

2015-03-18 Thread Stephan202
GitHub user Stephan202 opened a pull request: https://github.com/apache/maven/pull/40 MNG-5786: Fix edge case in determining maven.multiModuleProjectDirectory. See [MNG-5786](https://jira.codehaus.org/browse/MNG-5786) for details. The commit message explains the issue in different w