[GitHub] maven pull request: MNG-4463: Version ranges cannot be used for ar...

2016-01-31 Thread phang98
Github user phang98 commented on the pull request: https://github.com/apache/maven/pull/64#issuecomment-177814889 Thanks for the effort. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] maven pull request: MNG-4463: Version ranges cannot be used for ar...

2016-01-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven/pull/64 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] maven pull request: MNG-4463: Version ranges cannot be used for ar...

2016-01-23 Thread tomdw
Github user tomdw commented on the pull request: https://github.com/apache/maven/pull/64#issuecomment-174163794 @phang98 any idea when this will get integrated in a maven release? Preferably already in an small 3.0.x maven version as our setup currently requires it. --- If your proj

[GitHub] maven pull request: MNG-4463: Version ranges cannot be used for ar...

2016-01-06 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/64#issuecomment-169312032 No problem, many of us were on holiday and we'll sort it out eventually. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] maven pull request: MNG-4463: Version ranges cannot be used for ar...

2016-01-05 Thread phang98
Github user phang98 commented on the pull request: https://github.com/apache/maven/pull/64#issuecomment-169261641 I apologize for not fulfill my earlier commitment. :( Happy new year and get the new traction again on this topic. Will spend some time this weekend if possible.

[GitHub] maven pull request: MNG-4463: Version ranges cannot be used for ar...

2015-12-21 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/64#issuecomment-166335655 Also, is there a corresponding integration test? I will be offline for the most part over the next two weeks. I'm working on a Maven 4.x branch that touches almost everyth

[GitHub] maven pull request: MNG-4463: Version ranges cannot be used for ar...

2015-12-21 Thread tomdw
Github user tomdw commented on the pull request: https://github.com/apache/maven/pull/64#issuecomment-166318189 @phang98 any news yet on merging this pull request and getting it into the different 3.0.x, 3.1.x, ... maven versions? --- If your project is set up for it, you can reply t

[GitHub] maven pull request: MNG-4463: Version ranges cannot be used for ar...

2015-11-24 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/64#issuecomment-159242816 No problem, the 3.3.10 release took so much longer than expected so everyone's schedules got thrown off. Either @michael-o or myself will look at it when you're ready. No

[GitHub] maven pull request: MNG-4463: Version ranges cannot be used for ar...

2015-11-23 Thread phang98
Github user phang98 commented on the pull request: https://github.com/apache/maven/pull/64#issuecomment-159179107 Hi guys, I was away to focus on other critical project for the past few months. I'll get it done by this week. Sorry for the long waiting. --- If your project is set

[GitHub] maven pull request: MNG-4463: Version ranges cannot be used for ar...

2015-11-23 Thread michael-o
Github user michael-o commented on the pull request: https://github.com/apache/maven/pull/64#issuecomment-159060418 @barthel Sorry, messed you up. @phang98 Can you make the requested changes? --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] maven pull request: MNG-4463: Version ranges cannot be used for ar...

2015-11-23 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/64#issuecomment-159057440 @michael-o Sorry. I'm not the owner of this PR. I only push that change forward. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] maven pull request: MNG-4463: Version ranges cannot be used for ar...

2015-11-23 Thread michael-o
Github user michael-o commented on the pull request: https://github.com/apache/maven/pull/64#issuecomment-159045917 @barthel Please squash! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] maven pull request: MNG-4463: Version ranges cannot be used for ar...

2015-11-23 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/64#issuecomment-159010718 I would like to see this behaviour in the next Maven (3.3.10) release. @phang98 What's the status of the integration tests? @jvanzyl Do you like to merge this change

[GitHub] maven pull request: MNG-4463: Version ranges cannot be used for ar...

2015-10-24 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/64#issuecomment-150790373 Since ``org.apache.maven.repository.internal.DefaultModelResolver.resolveModel(Parent)`` handles the version range and ``org.apache.maven.repository.internal.DefaultModel

[GitHub] maven pull request: MNG-4463: Version ranges cannot be used for ar...

2015-09-27 Thread phang98
Github user phang98 commented on the pull request: https://github.com/apache/maven/pull/64#issuecomment-143642743 I'll look into the integration test part. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] maven pull request: MNG-4463: Version ranges cannot be used for ar...

2015-09-22 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/64#issuecomment-142240976 Generally the changes need to be squashed into a single commit and for changes to core you need a corresponding integration test. The integration tests can be found here h

[GitHub] maven pull request: MNG-4463: Version ranges cannot be used for ar...

2015-09-22 Thread phang98
Github user phang98 commented on the pull request: https://github.com/apache/maven/pull/64#issuecomment-142225342 The other commit is on branch, does it matter? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] maven pull request: MNG-4463: Version ranges cannot be used for ar...

2015-09-11 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/64#issuecomment-139687217 Please squash your commits into a single commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] maven pull request: MNG-4463: Version ranges cannot be used for ar...

2015-09-03 Thread phang98
GitHub user phang98 opened a pull request: https://github.com/apache/maven/pull/64 MNG-4463: Version ranges cannot be used for artifacts with 'import' scope MNG-4463: Version ranges cannot be used for artifacts with 'import' scope This is a quick patch to support version range r