[GitHub] maven pull request: MNG-3525-maven-settings - settings.xml allowin...

2015-12-12 Thread nitram509
Github user nitram509 commented on the pull request: https://github.com/apache/maven/pull/71#issuecomment-164198985 @jvanzyl For me it's to late now, let's talk tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] maven pull request: MNG-3525-maven-settings - settings.xml allowin...

2015-12-11 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/71#issuecomment-163965483 @nitram509 while i'm in California meeting up is a bit tough, but I will be back in Toronto tomorrow and then I'll email you and we'll figure out a time. --- If your proj

[GitHub] maven pull request: MNG-3525-maven-settings - settings.xml allowin...

2015-12-11 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/71#issuecomment-163962240 @michael-o the model change will be all right provided the reader ignores fields it doesn't understand. So newer versions that understand the change can deal with it accor

[GitHub] maven pull request: MNG-3525-maven-settings - settings.xml allowin...

2015-12-11 Thread michael-o
Github user michael-o commented on the pull request: https://github.com/apache/maven/pull/71#issuecomment-163879891 @jvanzyl Without looking deeply into this, it looks like a massive commit with a model change. This should be in 3.4 or later. @nitram509 You have refomatted som

[GitHub] maven pull request: MNG-3525-maven-settings - settings.xml allowin...

2015-12-11 Thread nitram509
Github user nitram509 commented on the pull request: https://github.com/apache/maven/pull/71#issuecomment-163871636 Sure. Btw.my timezone is UTC+1 ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] maven pull request: MNG-3525-maven-settings - settings.xml allowin...

2015-12-10 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/71#issuecomment-163810810 If you're around tomorrow I can spare an hour if you want to work together in a hangout to try and get this merged. It's a good feature, I just have some questions and we

[GitHub] maven pull request: MNG-3525-maven-settings - settings.xml allowin...

2015-12-10 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/71#issuecomment-163790796 I suggested the link on how to make comments so you would adjust them. Nothing is easy to read with the way they currently are. For example, I'm not sure why you introduce

[GitHub] maven pull request: MNG-3525-maven-settings - settings.xml allowin...

2015-12-10 Thread nitram509
Github user nitram509 commented on the pull request: https://github.com/apache/maven/pull/71#issuecomment-163789774 Is there anything I miss, that this PR can be merged? Or is there a plan/roadmap when merge could happen? --- If your project is set up for it, you can reply to this

[GitHub] maven pull request: MNG-3525-maven-settings - settings.xml allowin...

2015-11-15 Thread nitram509
Github user nitram509 commented on the pull request: https://github.com/apache/maven/pull/71#issuecomment-156813724 I've just rebased the latest commits from master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] maven pull request: MNG-3525-maven-settings - settings.xml allowin...

2015-11-01 Thread nitram509
Github user nitram509 commented on the pull request: https://github.com/apache/maven/pull/71#issuecomment-152829442 Thank you for this fast feedback. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] maven pull request: MNG-3525-maven-settings - settings.xml allowin...

2015-11-01 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/71#issuecomment-152828665 Looking through the changes, definitely useful. Just a suggestion for your for your Git commit messages: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.ht

[GitHub] maven pull request: MNG-3525-maven-settings - settings.xml allowin...

2015-11-01 Thread nitram509
GitHub user nitram509 opened a pull request: https://github.com/apache/maven/pull/71 MNG-3525-maven-settings - settings.xml allowing mirror definitions inside profiles This improves user settings to have a mirrors list switched on/off via Maven profile. See commit messages for