[GitHub] maven pull request: [MNG-5958] restore binary compatibility of Lif...

2016-02-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven/pull/77 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] maven pull request: [MNG-5958] restore binary compatibility of Lif...

2016-01-07 Thread atanasenko
Github user atanasenko commented on the pull request: https://github.com/apache/maven/pull/77#issuecomment-169636108 This change actually breaks MNG-5805 test since plexus can no longer call setPhases with Lifecycle map. However, I think changing the functionality (and test) to use i

[GitHub] maven pull request: [MNG-5958] restore binary compatibility of Lif...

2016-01-06 Thread michael-o
Github user michael-o commented on the pull request: https://github.com/apache/maven/pull/77#issuecomment-169481891 Great, I will wait for the ITs and try both and merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] maven pull request: [MNG-5958] restore binary compatibility of Lif...

2016-01-06 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/77#issuecomment-169376675 @michael-o +1, thanks very much! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] maven pull request: [MNG-5958] restore binary compatibility of Lif...

2016-01-06 Thread mcculls
Github user mcculls commented on the pull request: https://github.com/apache/maven/pull/77#issuecomment-169349800 @atanasenko thanks, that would be helpful --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] maven pull request: [MNG-5958] restore binary compatibility of Lif...

2016-01-06 Thread michael-o
Github user michael-o commented on the pull request: https://github.com/apache/maven/pull/77#issuecomment-169349132 @atanasenko Давай, спасибо! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] maven pull request: [MNG-5958] restore binary compatibility of Lif...

2016-01-06 Thread atanasenko
Github user atanasenko commented on the pull request: https://github.com/apache/maven/pull/77#issuecomment-169332865 @michael-o, @mcculls I can also assist with tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] maven pull request: [MNG-5958] restore binary compatibility of Lif...

2016-01-06 Thread michael-o
Github user michael-o commented on the pull request: https://github.com/apache/maven/pull/77#issuecomment-169331588 @mcculls It would be great if you could an IT to the Core IT Suite. A negative and positive one. --- If your project is set up for it, you can reply to this email and h

[GitHub] maven pull request: [MNG-5958] restore binary compatibility of Lif...

2016-01-06 Thread michael-o
Github user michael-o commented on the pull request: https://github.com/apache/maven/pull/77#issuecomment-169331471 @jvanzyl This looks like a safe merge. I would pull if you don't mind. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] maven pull request: [MNG-5958] restore binary compatibility of Lif...

2016-01-06 Thread atanasenko
Github user atanasenko commented on the pull request: https://github.com/apache/maven/pull/77#issuecomment-169321926 +1 Turns out people do use this method.. Stuart, thanks for fixing! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] maven pull request: [MNG-5958] restore binary compatibility of Lif...

2016-01-06 Thread mcculls
GitHub user mcculls opened a pull request: https://github.com/apache/maven/pull/77 [MNG-5958] restore binary compatibility of Lifecycle.setPhases https://issues.apache.org/jira/browse/MNG-5958 While MNG-5805 restored binary compatibility of Lifecycle.getPhases it didn't do