[GitHub] maven pull request: [MNG-5812] Project base dir not fully working ...

2015-06-23 Thread tssp
Github user tssp commented on the pull request: https://github.com/apache/maven/pull/46#issuecomment-114745829 Thank you very much for integrating it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] maven pull request: [MNG-5812] Project base dir not fully working ...

2015-06-23 Thread tssp
Github user tssp closed the pull request at: https://github.com/apache/maven/pull/46 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled

[GitHub] maven pull request: [MNG-5812] Project base dir not fully working ...

2015-06-22 Thread agudian
Github user agudian commented on the pull request: https://github.com/apache/maven/pull/46#issuecomment-114251594 Works as it should, I'd say... :grinning: @tssp, I have rebased your commit, so this PR won't close automatically. Would you please close it? And thanks f

[GitHub] maven pull request: [MNG-5812] Project base dir not fully working ...

2015-06-22 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/46#issuecomment-114224088 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] maven pull request: [MNG-5812] Project base dir not fully working ...

2015-06-22 Thread agudian
Github user agudian commented on the pull request: https://github.com/apache/maven/pull/46#issuecomment-114223364 Sure, I'll take care of it. :wink: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] maven pull request: [MNG-5812] Project base dir not fully working ...

2015-06-22 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/46#issuecomment-114211764 @agudian think you might be able to validate this? And close out MNG-5812. Sorry, you're the go-to Windows committer :-) --- If your project is set up for it, you can rep

[GitHub] maven pull request: [MNG-5812] Project base dir not fully working ...

2015-04-29 Thread tssp
GitHub user tssp opened a pull request: https://github.com/apache/maven/pull/46 [MNG-5812] Project base dir not fully working in Cygwin Converted project base dir from Cygwin path to Windows path before executing Maven when running Maven in a Cygwin environment. You can merge t