[GitHub] maven pull request: [MNG-5640] Make sure participants are called a...

2014-06-10 Thread cstamas
Github user cstamas commented on the pull request: https://github.com/apache/maven/pull/18#issuecomment-45644872 FTR, Manually merged as 18964baa25e9c071d13186e4c03e3957b9381961 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] maven pull request: [MNG-5640] Make sure participants are called a...

2014-06-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] maven pull request: [MNG-5640] Make sure participants are called a...

2014-06-10 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/18#issuecomment-45641594 Can you close your pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] maven pull request: [MNG-5640] Make sure participants are called a...

2014-06-10 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/18#issuecomment-45608955 Patch applied, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] maven pull request: [MNG-5640] Make sure participants are called a...

2014-06-02 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/18#issuecomment-44840927 Awesome, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] maven pull request: [MNG-5640] Make sure participants are called a...

2014-06-02 Thread cstamas
Github user cstamas commented on the pull request: https://github.com/apache/maven/pull/18#issuecomment-44840750 New IT added https://github.com/apache/maven-integration-testing/pull/6 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] maven pull request: [MNG-5640] Make sure participants are called a...

2014-06-02 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/18#issuecomment-44829347 Cool, now you just need a test :-) I would look at one of Igor's related ITs. Some of the most recent ITs that have been added. --- If your project is set up for it, you c

[GitHub] maven pull request: [MNG-5640] Make sure participants are called a...

2014-06-02 Thread cstamas
Github user cstamas commented on the pull request: https://github.com/apache/maven/pull/18#issuecomment-44824659 ITs passed on this PR :+1: https://gist.github.com/cstamas/5873e5413da65a5258c5 --- If your project is set up for it, you can reply to this email and have your re

[GitHub] maven pull request: [MNG-5640] Make sure participants are called a...

2014-05-30 Thread cstamas
Github user cstamas commented on the pull request: https://github.com/apache/maven/pull/18#issuecomment-44653198 Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] maven pull request: [MNG-5640] Make sure participants are called a...

2014-05-30 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/18#issuecomment-44653025 Can you squash this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th