[GitHub] maven issue #100: Spelling non-API change

2017-02-02 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/maven/pull/100 Testing your changes now: https://builds.apache.org/job/maven-3.x-jenkinsfile/job/MNG-6146/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] maven issue #100: Spelling non-API change

2017-02-01 Thread jsoref
Github user jsoref commented on the issue: https://github.com/apache/maven/pull/100 Updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] maven issue #100: Spelling non-API change

2017-02-01 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/maven/pull/100 Testing your PR, two issues: 1. Please resolve the marked conflicts from above 2. One test fails because you missed to rename a directory: ---

[GitHub] maven issue #100: Spelling non-API change

2017-01-31 Thread jsoref
Github user jsoref commented on the issue: https://github.com/apache/maven/pull/100 done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] maven issue #100: Spelling non-API change

2017-01-31 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/maven/pull/100 Can you rebase your changes and squash into one commit? I want to pull them in with [MNG-6146](https://issues.apache.org/jira/browse/MNG-6146?src=confmacro). --- If your project is set up for it,

[GitHub] maven issue #100: Spelling non-API change

2017-01-29 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/maven/pull/100 You have renamed to `mngt`, but missed to rename physical directories also. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] maven issue #100: Spelling non-API change

2017-01-29 Thread jsoref
Github user jsoref commented on the issue: https://github.com/apache/maven/pull/100 sonatype/plexus-sec-dispatcher#4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] maven issue #100: Spelling non-API change

2017-01-29 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/maven/pull/100 I am about to mere this PR, but for one commit which has to be undone. Then I will check the rest. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] maven issue #100: Spelling non-API change

2017-01-28 Thread jsoref
Github user jsoref commented on the issue: https://github.com/apache/maven/pull/100 @michael-o : this PR is roughly "non-API change". I split off #101 for the API change (and included deprecation, but not docs, that's too much to ask). #102 is a bug fix, I think, so I split it out.