[GitHub] maven-wagon pull request: Prevent fingerprints loss in known_hosts

Github user marob commented on the pull request: https://github.com/apache/maven-wagon/pull/16#issuecomment-141778410 OK. I've tested 2.11-SNAPSHOT and can confirm the FIX is OK. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] maven-wagon pull request: Prevent fingerprints loss in known_hosts

Github user dantran commented on the pull request: https://github.com/apache/maven-wagon/pull/16#issuecomment-141748659 please test wagon-2.11-SNAPSHOT --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] maven-wagon pull request: Prevent fingerprints loss in known_hosts

Github user dantran commented on the pull request: https://github.com/apache/maven-wagon/pull/16#issuecomment-141748169 it is fixed and test with wagon-maven-plugin. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] maven-wagon pull request: Prevent fingerprints loss in known_hosts

Github user dantran commented on the pull request: https://github.com/apache/maven-wagon/pull/16#issuecomment-141742580 hkr.getHostKey( host, null ) can return null where to orignal code does handle --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] maven-wagon pull request: Prevent fingerprints loss in known_hosts

Github user dantran commented on the pull request: https://github.com/apache/maven-wagon/pull/16#issuecomment-141740614 I had to revert the change, its NPE wagon-ssh at wagon-maven-plugin/src/it/ssh-it test. --- If your project is set up for it, you can reply to this email and have

[GitHub] maven-wagon pull request: Prevent fingerprints loss in known_hosts

Github user asfgit closed the pull request at: https://github.com/apache/maven-wagon/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] maven-wagon pull request: Prevent fingerprints loss in known_hosts

Github user marob commented on the pull request: https://github.com/apache/maven-wagon/pull/16#issuecomment-141720699 All lines with non recognized algorithms are deleted. So the newly added line and all other ecdsa fingerprints (if any). Rsa and dsa fingerprints are kept, with our

[GitHub] maven-wagon pull request: Prevent fingerprints loss in known_hosts

Github user dantran commented on the pull request: https://github.com/apache/maven-wagon/pull/16#issuecomment-141720614 Just want confirm, only the addional line that inserted prior to your test get removed, or the entire file is empty out --- If your project is set up for it, you ca

[GitHub] maven-wagon pull request: Prevent fingerprints loss in known_hosts

Github user marob commented on the pull request: https://github.com/apache/maven-wagon/pull/16#issuecomment-141702559 As you can see, my modifications are in the AbstractJschWagon.openConnectionInternal method. This method launches a real connection and cannot be easily tested. Fo

[GitHub] maven-wagon pull request: Prevent fingerprints loss in known_hosts

Github user dantran commented on the pull request: https://github.com/apache/maven-wagon/pull/16#issuecomment-141582086 I will take a look. Please bare with me on my ignorance, and provide me a test case, promise to push 2.10.1 out for you. Even a pom using wagon-wagon-plugin also fin

[GitHub] maven-wagon pull request: Prevent fingerprints loss in known_hosts

Github user didlich commented on the pull request: https://github.com/apache/maven-wagon/pull/16#issuecomment-141548490 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] maven-wagon pull request: Prevent fingerprints loss in known_hosts

Github user marob commented on the pull request: https://github.com/apache/maven-wagon/pull/16#issuecomment-141385842 It's been months... can we expect any merge one day? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If