[GitHub] maven-surefire pull request: SUREFIRE-1250: add exceptions to desc...

2016-05-26 Thread kgyrtkirk
Github user kgyrtkirk commented on the pull request: https://github.com/apache/maven-surefire/pull/113#issuecomment-222059866 i've moved the check into `ResolvedTest`. I now use the `MatchedPattern`...to check for exceptions. I've squashed my changes into one commit; becaus

[GitHub] maven-surefire pull request: SUREFIRE-1250: add exceptions to desc...

2016-05-25 Thread kgyrtkirk
Github user kgyrtkirk commented on the pull request: https://github.com/apache/maven-surefire/pull/113#issuecomment-221739676 I've used `Pattern.compile` to keep the regexp's problem description; i thinked it makes it more clear how it will be used eventually. I picked `TestLi

[GitHub] maven-surefire pull request: SUREFIRE-1250: add exceptions to desc...

2016-05-25 Thread Tibor17
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/113#discussion_r64666590 --- Diff: surefire-api/src/main/java/org/apache/maven/surefire/testset/TestListResolver.java --- @@ -479,6 +481,27 @@ else if ( hasMethod )

[GitHub] maven-surefire pull request: SUREFIRE-1250: add exceptions to desc...

2016-05-24 Thread kgyrtkirk
GitHub user kgyrtkirk opened a pull request: https://github.com/apache/maven-surefire/pull/113 SUREFIRE-1250: add exceptions to describe usage rules of %regex @Tibor17 i've cleaned it up a bit; and added exception for multiple hashmarks too. tests have passed on my machine. You can