[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-164705763 >>Ok. But I still don't understand why it is working on my computers: I don't have guice-2.0.jar and exclude it was enough. Hm, that's strange but the im

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-164675576 @Tibor17 Ok. But I still don't understand why it is working on my computers: I don't have guice-2.0.jar and exclude it was enough. For my information, why

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user juherr closed the pull request at: https://github.com/apache/maven-surefire/pull/107 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-164604785 @juherr Pls close this issue. I made additional updates and pushed your commit to the master. Thx for contributing. --- If your project is set up for i

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-164324781 @juherr Do you have this file on your file system? `/Users/cbeust/java/testng/target/checkout/lib-supplied/guice-2.0.jar` I guess you have it and that

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-164317823 @juherr How did you solve https://github.com/apache/maven-surefire/pull/107#issuecomment-160169598 ? It's the same problem with the exception I have now.

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-164302659 @agudian Hi Andreas, We have here different test result. After I launched `CheckTestNgListenerReporterIT` in your environment? You should make this clone

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-164302567 Yes. I tried first by removing testng from local repo + full it-repo. Then I tried by removing full local repo + full it-repo. CheckTestNgListenerReport

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-164301644 Did you delete both repositories? 1. Maven local repository 2. surefire-setup-integration-tests/target/it-repo --- If your project is set up for it, you

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-164301074 > Do you have this path? Yes > I use Java 7 which is maybe the only one difference. Ok. But it is working well on my side with `openjdk

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-164299962 After deleting both repositories and using maven 3.3.9 still bad result in `surefire-integration-tests/target/CheckTestNgListenerReporterIT_testNgListenerRepo

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-164299087 I use Maven 3.3.9 like you use. Do you have this path `surefire-integration-tests/target/CheckTestNgListenerReporterIT_testNgListenerReporter_5.14.4`

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-164294388 I've just followed your process and it's working well for me with `maven 3.0.5` and `Oracle JDK 1.8.0_66` on `Linux Mint 17.2 Rafaela`. I tried on 2 different

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-164288512 `com/beust/jcommander/ParameterException` comes from jcommander which is a TestNG dependency. If it is missing, that means the dependency resolution is falling. A

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-164279434 I have reproduced the issue and the error is really true because the `testng-5.14.4.jar` really does not contain the class `com/beust/jcommander/ParameterExcepti

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-164274018 @juherr Please try to test with official Version Maven 3.0.5 which should be used in Surefire project. I used 3.2.1. I will try with 3.0.5 as well and let you kn

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-164262422 > committer in Maven ASF I'm open :) > Tests in error I confirm it is working for me with maven 3.3.9 and 3.2.5. ``` --

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-164238653 @juherr @cbeust Yeasterday I made big refactoring on TestNG provider. This is old project which started in Codehaus and the provider contained unused code, e

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-164238142 @cdeneux @juherr I am thinking about asking and introducing @juherr committer in Maven ASF. --- If your project is set up for it, you can reply to this

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-164237916 @juherr I am running the build in command line. This is the command I use `mvn -P run-its install`. This means the build result should be same in your case

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-164237383 5.14.4 is not supposed to fail and excluding the bad dependency worked for me. I'll try again with an up2date maven. Which one are you using? --- If your p

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user cbeust commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-164237025 @Tibor17 Yes, @juherr is a committer. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-164236988 @juherr Are you a committer at TestNG project? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-164236954 I was about to push your commit and start the release Vote. Please run the ITs. I found a problem in IT Tests in error: testNgListenerReporter[4: Te

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-162858740 Thx, try to squash them. On Tue, Dec 8, 2015 at 11:21 AM, Julien Herr wrote: > @Tibor17 Done. Are the commits o

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-162840938 @Tibor17 Done. Are the commits ok for you, or do you want I try to squash and/or reword them? --- If your project is set up for it, you can reply to this email a

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-162320804 @juherr I updated the comment. I don't mean this weekend. We still have one week left. --- If your project is set up for it, you can reply to this email and hav

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-162313840 Ok, I will. But I'm not available today. Is tomorrow still ok for you? --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-162312898 @juherr I want to make a release during weekend. Can you please update the section (Line 228) of reporters? This is the document. `maven-surefire-plu

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-161557229 You mean 5.14.4 or higher. But I'm agree, and I hope nobody is using TestNG 5.x :D --- If your project is set up for it, you can reply to this email and have you

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-161556711 @juherr I guess nobody is using buggy library 5.14.1 or 5.14.2. Since we did rely on separator "," the users were facing this issue and most probably used 5.14.3

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-161556520 > What about to replace "," with ", " in surefire parameter It won't work because TestNG need a `List in these 2 versions. > I guess configure(Com

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-16178 @juherr What about to replace `","` with `", "` in surefire parameter value in TestNG provider. Do you think this would come over the issue and would work in

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-161554781 > What exactly the bug is? `configure(Map)` from 5.14.1 and 5.14.2 is transforming `List` into a `String` with a space as separator. Then, `configure(Comm

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-161430409 @juherr IIUC testng 5.14.1 - 5.14.3 are buggy and can be excluded from the test set. What exactly the bug is? You mean the ClassLoader issue? What did you

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160478603 Let me see tomorrow or on Tuesday. You did a lot today :+1: but It's time to sleep. Good progress. Thx. --- If your project is set up for it, you can re

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160476785 In fact, `configure(CommandLineArgs)` may help to fix 5.14.1 and 5.14.2. But it will be more work and time. --- If your project is set up for it, you can repl

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160476223 > Do you need any help from my side? Yes, decide something :) Currently, the 5.14.2 and 5.14.3 tests are disable because of TestNG issues. 5.14.1 is

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160475738 @juherr Excellent! Do you need any help from my side? --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160474911 Current status: 5.14.3 --- The jar is still available: https://github.com/cbeust/testng/blob/master/lib-supplied/guice-2.0.jar It's a s

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160430883 We can add system-dependency to the pom.xml of IT and add guice-2.0.jar on the same level with pom.xml of the IT in the file system. You can extract the ja

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160427809 > [WARNING] The POM for org.testng:testng:jar:5.14.3 is invalid, transitive dependencies (if any) will not be available: 1 problem was encountered while building

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160416265 @juherr Please mention the configuration of reported in surefire documentation. I guess the returned value from `convertReporterConfig()` method should be di

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160397879 It's hard to debug the IT because @After cleaned up previous tests in `target`. Good inspiration is `Surefire1158RemoveInfoLinesIT` and method `unpack` becau

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160395575 As you proposed before `resetInitialGoals( version )` seems to work as expected. I'm not sure more profiles will help here. I'm trying `addGoal( "-e -X" )`.

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160393834 Your IT has this POM https://github.com/apache/maven-surefire/blob/master/surefire-integration-tests/src/test/resources/testng-listener-reporter/pom.xml D

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160335576 No worries. :-) I am glad that you continue with this issue. Btw I finished previous fix in surefire and I am trying to dig into this issue. On Sa

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160335454 I got it for 5.13 and 5.14.2: like reporter, listener attribute has changed too. I will fix it asap. I'm open for help with 5.14.3 --- If your proje

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160334856 Some artifacts was corrupted before. Now, they are the same than central. For 5.14.3: - > [WARNING] The POM for org.testng:testng:jar:5.14.3 is

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160195132 @juherr Try to commit what you have and I will check it out. Overriding last commit is just fine. --- If your project is set up for it, you can reply to this em

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160193148 6.9.9 works in my dummy project, then yes. Latest greatest. Feel free to override the last commit. On Fri, Nov 27, 2015 at 8:10 PM, Julien Herr w

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160191413 I'm not sure to understand. The test with TestNG 6.0 and 6.9.9 is working, right? --- If your project is set up for it, you can reply to this email and have

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160173397 Alright I go it. You must use profile instead: `.addGoal( "-P testng6" )` and the profile `testng6` should have dependencies with testng 6.0. This was you

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160169598 Current status: ``` Tests in error: testNgListenerReporter[3: TestNG 5.13](org.apache.maven.surefire.its.CheckTestNgListenerReporterIT): Exit c

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-16224 Thank! I missed `resetInitialGoals( version )` before. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-159998029 You can override the TestNG version by `resetInitialGoals( version )` method and you can see the usage of the method in `CheckTestNgVersionsIT`. The version is p

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-159995366 @Tibor17 I tried to add some test cases in `TestNgListenerReporter` but I don't know how to override the testng version used by the test. Currently, it is defined

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-159816428 @juherr Can you add an integration test. I guess there is another API for reporter so that maybe we are missing one of them in our integration tests (testng 6.0)

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-158758087 @juherr the build is successful, I will check the changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

Github user Tibor17 commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-158545841 @juherr I will run the build and i will check the code. Thx for the effort. --- If your project is set up for it, you can reply to this email and have your

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

GitHub user juherr opened a pull request: https://github.com/apache/maven-surefire/pull/107 [SUREFIRE-1194] reporter argument does not work for TestNG You can merge this pull request into a Git repository by running: $ git pull https://github.com/juherr/maven-surefire surefire