Github user Tibor17 closed the pull request at:
https://github.com/apache/maven-surefire/pull/106
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven-surefire/pull/106#issuecomment-162525723
@juherr Sorry :), really it was me, sorry again :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user juherr commented on the pull request:
https://github.com/apache/maven-surefire/pull/106#issuecomment-162522326
@Tibor17 No, I can't! YOU created this pull-request ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven-surefire/pull/106#issuecomment-162337794
@juherr I guess this was already merged in Version 2.19. You can close the
pull-request. Thx
---
If your project is set up for it, you can reply to this email a
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven-surefire/pull/106#issuecomment-143793736
There is already version range [5.3,6.4] you should split which means to
split in
[5.3,5.10) and
[5.10,6.4] update only `TestNGMapConfigurator`.
Do y
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven-surefire/pull/106#issuecomment-143791336
The style with reflection is usually in junit provider, but you'r right,
forget reflection in testng.
---
If your project is set up for it, you can reply to thi
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven-surefire/pull/106#issuecomment-143790836
Alright create `TestNG510Configurator` and register it in
`AbstractSurefireMojo` and increate the version in surefire-testng POM.
---
If your project is set up
Github user juherr commented on the pull request:
https://github.com/apache/maven-surefire/pull/106#issuecomment-143768585
It's not a problem of time but I just want to understand what I'm doing.
I'm talking about an compile dependency (scoped provided) where, as I
understand,
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven-surefire/pull/106#issuecomment-143766756
Because we were always dependent on 5.7 and the users may still rely on it.
It is question of one minute to crate Utility class in the module
surefire-testng-
Github user juherr commented on the pull request:
https://github.com/apache/maven-surefire/pull/106#issuecomment-143764774
For my information, why not updating the testng dependency as I did it in
#105?
I'll try to add some tests for suite thread count.
---
If your project i
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven-surefire/pull/106#issuecomment-143760174
Is there the same principle with thread count for suites?
I did not test suite thread count because I do not have IT.
Can you try?
On Mon, Sep 28,
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven-surefire/pull/106#issuecomment-143758786
All you need to do is to call this method with Java Reflection.
There is `surefire-testng-util` module.
You should create reflection utility in there.
Github user juherr commented on the pull request:
https://github.com/apache/maven-surefire/pull/106#issuecomment-143743363
Sometime code is easier than explainations :) I updated #105. Feel free to
comment.
---
If your project is set up for it, you can reply to this email and have yo
Github user juherr commented on the pull request:
https://github.com/apache/maven-surefire/pull/106#issuecomment-143733741
Since 5.10, `suite.setDataProviderThreadCount()` is available but surefire
doesn't use it.
I'd like to add
```
String dataProviderThr
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven-surefire/pull/106#issuecomment-143683397
Since 5.10?
Hm, I was testing with 6.9.x and the number of threads was 10 instead of 30
configured in `dataproviderthreadCount`.
Pending question - we use
Github user juherr commented on the pull request:
https://github.com/apache/maven-surefire/pull/106#issuecomment-143677343
I had time to analyze and I found that `dataProviderThreadCount` is taken
into account only when `m_commandLineTestClasses != null ||
m_commandLineMethods != null
Github user juherr commented on the pull request:
https://github.com/apache/maven-surefire/pull/106#issuecomment-143522916
Awesome! I should have time this week to close it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven-surefire/pull/106#issuecomment-143505456
@juherr
This is the IT, but the problem is in TestNG because the concurrency
remains 10 even if dataproviderthreadcount=30.
Meanwhile I reported issue in
GitHub user Tibor17 opened a pull request:
https://github.com/apache/maven-surefire/pull/106
[SUREFIRE-1179] integration test
for #105
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Tibor17/maven-surefire s4
Alternatively you c
19 matches
Mail list logo
