Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/118
@Tibor17 Thank you! I'll continue with the next more complex examples.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/118
@britter The branch is ready for use.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/118
@britter Sorry I was busy this week. I am going to push this branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/118
@Tibor17 any chance this can land on it's own feature branch, so that I can
start with the next tests? I don't want to bloat this PR.
---
If your project is set up for it, you can reply to t
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/118
@Tibor17 I've assed the assume statement using the API introduced in #120.
I propose that you create a new branch for JUnit 5, where we can merge this PR
and all follow up PRs for JUnit 5 int
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/118
@Tibor17 yes I need #120 to finish this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/118
@britter
I see the CI https://builds.apache.org/job/maven-surefire/ already has JDK8.
:+1: after adding `assumeThat(java.specification.version,
is(greaterThan(1.7)));` from https://gi
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/118
One more job to do in *IT.java. Can you please add
`assumeThat(java.specification.version, is(greaterThan(1.7)));`.
A hint: Just lookup the text "java.specification.version" in ITs.
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/118
@tibor this PR is only about introducing ITs. The M2 release of the
provider is pulled in via maven as dependency, see the test pom.xml. I agree
that surefire should not ship with a have fini
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/118
We cannot really marge the external provider to master if it is alpha or
beta version and if we do not have ITs.
We in hurry too much however we take full responsibility for the quality
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/118
@Tibor17 worked through all your comments. Can this be merged as a first
starter for JUnit 5 ITs?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/118
@Tibor17 thank you for the input. I'd like to take have small PRs, so my
proposal is to introduce this first PR and merge it to the code base after your
comments have been resolved and then w
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/118
I did not notice you was @IRC. The build take 40 minutes to complete :) We
have many tests :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/118
@brianf
In generally this is a good starting point of course.
We should have such ITs which cover the functionality of provider from the
configuration point of view. So as for instanc
14 matches
Mail list logo
